From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id ABAFE374 for ; Tue, 27 Jun 2017 17:05:23 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id 62so27452231wmw.1 for ; Tue, 27 Jun 2017 08:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=rah7a/0rG9KyH8LuS7ptTFG+KsrbzA9MJvitntCDT8E=; b=oI7i/lar+aX7BDZpmx4+CaejesrstQGLXeCqS9YFYpseUXnaej0Fn/82SqZdCp7dNx 8YvYEv+UG7D5cz2A0EKuk6gOcXYGw8etwW+3bhzui/oajr3d/TE2wSqXFZ3M9sU+Bsfb sAyE5YNuvMLJxawuz/X8A/HR3vJgnOMavsKnquZSWbClf+rtnpptNNIv49nSKN2VAI4m eaj1WUP4F0Nio/2w1BT2OlJsotmInjVzIimo2I2r+puBw6GKTINWldlw1iF59kZzwO8i GIbu7vUrEQI4zkfQqI8k1tXb7IoiQQQ2DgQ1Y0KOM01LLvA83UQlzxbShP6VifATWrnh WbJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=rah7a/0rG9KyH8LuS7ptTFG+KsrbzA9MJvitntCDT8E=; b=MBYH4njH0j2/jRjVlIZXKgZZVQizvxRuXNcp2IrP09xAfqZaT+9TN3+ueaPK7O4BCJ 692E/iNCuYS5Q5224iPzvsR4PKRqOUXDfZUkwCWaXHPo8EdfFv4X/p97oTe4t8Rcfwp+ yl2pnj/J44pJmBWTFrOoKe5Cz/AQsIGC6fAl6QJ/hGmdCKql/sqjsGrV/Bu8ZXL0pAPy bHaz2uxfTPWFdcKcF//LyeMO/vSg8LVX0ACYVzimTznMGLz8LVej3n7jMByS67bCMyTl ULz/OW24orQ5HoyhDsTVqyIo5qVZKQs4N+gbPnJtzvol8c1QGh4jTgxVTYTmhfVqCIRI Uw/A== X-Gm-Message-State: AKS2vOykwSWN0Q5tfdlsEabgLq8VkjUDG7CszdnI0t1/dkJ9X+3W59zj +4fNy9EReGrPQ5iu X-Received: by 10.28.230.89 with SMTP id d86mr3981547wmh.80.1498575922978; Tue, 27 Jun 2017 08:05:22 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z75sm2832288wmz.8.2017.06.27.08.05.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Jun 2017 08:05:22 -0700 (PDT) Date: Tue, 27 Jun 2017 17:05:14 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Bruce Richardson Cc: dev@dpdk.org, Jan Blunck Message-ID: <20170627150514.GE13355@bidouze.vm.6wind.com> References: <0094d130d0bc93de5d676b67aa28acf6dc81d37b.1498436062.git.gaetan.rivet@6wind.com> <20170627135434.GH104744@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170627135434.GH104744@bricha3-MOBL3.ger.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v5 04/12] bus: add bus iterator to find a device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 15:05:23 -0000 On Tue, Jun 27, 2017 at 02:54:34PM +0100, Bruce Richardson wrote: > On Mon, Jun 26, 2017 at 02:22:02AM +0200, Gaetan Rivet wrote: > > From: Jan Blunck > > > > Signed-off-by: Jan Blunck > > Signed-off-by: Gaetan Rivet > > --- > > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 1 + > > lib/librte_eal/common/eal_common_bus.c | 24 +++++++++++++++++++++++ > > lib/librte_eal/common/include/rte_bus.h | 26 +++++++++++++++++++++++++ > > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 1 + > > 4 files changed, 52 insertions(+) > > > > diff --git a/lib/librte_eal/bsdapp/eal/rte_eal_version.map b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > index f1a0765..21640d6 100644 > > --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map > > @@ -164,6 +164,7 @@ DPDK_17.05 { > > > > rte_bus_find; > > rte_bus_find_by_device; > > + rte_bus_find_device; > > rte_cpu_is_supported; > > rte_log_dump; > > rte_log_register; > > diff --git a/lib/librte_eal/common/eal_common_bus.c b/lib/librte_eal/common/eal_common_bus.c > > index d208214..63fd9f1 100644 > > --- a/lib/librte_eal/common/eal_common_bus.c > > +++ b/lib/librte_eal/common/eal_common_bus.c > > @@ -190,3 +190,27 @@ rte_bus_find_by_device(const struct rte_device *dev) > > { > > return rte_bus_find(bus_find_device, (const void *)dev, NULL); > > } > > + > > +struct rte_device * > > +rte_bus_find_device(rte_dev_cmp_t cmp, const void *data, > > + const struct rte_device *start) > > One additional suggestion: might it be worthwhile also returning the bus > for the device here, in an optional 4th parameter. This is, after all, > a bus API. :-) > > /Bruce I think having the bus is a good info. However, 1. This makes this API slightly less clean I think. A subjective matter, but I don't like adding cruft without good justification. 2. The bus will be made accessible by my future patches. The series afterward are introducing a generic device type representation, which is composed of the bus. This type info is integral to the device and thus the bus can be read from within the resulting rte_device here. So, I won't add this parameter right now. If we have issues with the rte_devargs series, it might be interesting to come back on this and edit this API. -- Gaëtan Rivet 6WIND