From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id 2EF7B2BE1 for ; Wed, 28 Jun 2017 00:26:20 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id j186so22034730pge.2 for ; Tue, 27 Jun 2017 15:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bKvGHc/6HgltlAuxVCoDWfEh292wp38CK2aSjFA81ak=; b=n4PQkLFrBy5zfFu5C1iB8yOyty5jMWEyPubbdlSZAgUWc1NkXuXS3mb4VH53bt576Q n7nPc6iMnykkaDsabbQXrz4xVVY3/ReWhOiHSwq42ji2yY96sTNa/BmT7IUYivUh7ghe MUu/u1pMEaqsDUJcotQrWcw0kja5jA7tvu14nwufhRUxLIYlF+9z6TFzSBSW/OA4nTEB m5LoJBNJ/IDxLtMiTx3b7eyd6cNCneDFEsuM+/K701Yyy9TYsv4oe1cO68ch2FzGk2qO IRhHooYcgl9DMvAZ4aB0KtPwKsvh2SmYC0Wpou8Gn14RTo/yx8sRkMfn4W5CUI3sJEIh OAZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bKvGHc/6HgltlAuxVCoDWfEh292wp38CK2aSjFA81ak=; b=tmIScDtI1bhkkSWq1hcqwlkK0etAF8fBami0LoLM0U6iDVHAdvtG4ur1LEqrPxvNnn jfpGOC68Qm9kHcPYj+7lBKH19FTbZAoAPyV9fbQIse+bwEJxF/bEvN0VUMfRotTz0k9b KE5MR1g0GH5SJbAPyHICT5qFLXjkS3fv9VaqTy+qeTzQalOx4G6UZBSOX8IlwEPqY8qw 5hq0mBH9Ifk9BZL4lLd9U2SA4ZHBK6X2IDvQRGnr+4y1BdeSa2iULl8xOHjyL3nZ01Iq 5shTf+qcJz0Uj0kqKVujAdxWmpqln4zg4Qf7UokhtDJLf+lHNO2BskyJVoCLICAfBw16 vj3A== X-Gm-Message-State: AKS2vOyay2+alZgUoZBaue5J9MlxO+9iQm1JTU2GHRNiRFLRmFnZY8tu dagzD0GZ4najRG/f X-Received: by 10.84.231.130 with SMTP id g2mr8364553plk.2.1498602379284; Tue, 27 Jun 2017 15:26:19 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id q19sm540402pfd.24.2017.06.27.15.26.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Jun 2017 15:26:19 -0700 (PDT) Date: Tue, 27 Jun 2017 15:26:12 -0700 From: Stephen Hemminger To: Radu Nicolau Cc: dev@dpdk.org, wenzhuo.lu@intel.com, reshma.pattan@intel.com, michalx.k.jastrzebski@intel.com, deepak.k.jain@intel.com, harry.van.haaren@intel.com, piotrx.t.azarewicz@intel.com Message-ID: <20170627152612.3fabf6fd@xeon-e3> In-Reply-To: <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> References: <20170522143202.22424-2-michalx.k.jastrzebski@intel.com> <1498470133-29788-1-git-send-email-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2017 22:26:20 -0000 On Mon, 26 Jun 2017 10:42:13 +0100 Radu Nicolau wrote: > From: Michal Jastrzebski > > If-MIB xstats: > ifNumber > ifIndex > ifType > ifMtu > ifSpeed > ifPhysAddress > ifOperStatus > ifLastChange > ifHighSpeed > ifConnectorPresent > ifCounterDiscontinuityTime > > EtherLike-MIB xstats: > dot3PauseOperMode > dot3StatsDuplexStatus > dot3StatsRateControlAbility > dot3StatsRateControlStatus > dot3ControlFunctionsSupported > > -updated in v2: coding style > > Signed-off-by: Piotr Azarewicz > Signed-off-by: Michal Jastrzebski > Signed-off-by: Radu Nicolau Although this maybe the easiest way for Intel, and satisfy a specific user's request. It is not a good way forward for the DPDK project. This must be generic, not specific to device drivers. If implementing a MIB variable requires more information than ethdev API has now, then extend ethdev API first. One of the common things in open source projects, is that when you want to add one new feature for one constrained portion; the maintainers require you to implement a generic solution. This falls into that category.