From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f170.google.com (mail-pf0-f170.google.com
[209.85.192.170]) by dpdk.org (Postfix) with ESMTP id A66572BE1
for <dev@dpdk.org>; Wed, 28 Jun 2017 00:27:29 +0200 (CEST)
Received: by mail-pf0-f170.google.com with SMTP id c73so23203532pfk.2
for <dev@dpdk.org>; Tue, 27 Jun 2017 15:27:29 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=TiLbMnNk29POFbtgwEOedSR8xECNXcMHtbzHsyd4SGk=;
b=jtuOJjL2n9hcWVmZie6ZukUCdYuqKV6yKMQa2/t693CgUT+Gnd8hM2sXveEEGZ8ylk
KsJhEOUM0LL1uFVOmtTeJ6IULVhSDaQcAcBaqHm6VHPZHFZIJtAeqouS4ey/5vd9EpYo
C8wCmUy46auTMfLwXwDYwnYP/RFKSHfoen3dkME0T/eaylNpsuzdz4LXpdh5kv1E3sfe
dzHjqsdM7ryMUl6IzZmUS23iXrimZIFtk1v06YrltKw9pcFD2yqf+jw+8Nkw05rZFlJq
fXe8DY5YsIsb5/spgqdy99KcKLBbWXiqZEgWwrz5mAHe5XpTkgziWOKBMZrxTzsmFO7O
NdxA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=TiLbMnNk29POFbtgwEOedSR8xECNXcMHtbzHsyd4SGk=;
b=DqFmhUhxVRnnnBOxYB/dvjWTqOir8pDq3p3DC+n4E2PTxLEYgewjfX+xXkCts6HLoS
8ynvc47V5WyuEn58JmDGrmPF2jc5kH3SjbDRCSOZ91pnGR+VsA+3TH972BLY1G9KqSy0
G/4VWN772bLwi3zKQyZb098u6WcZSpGyU6PRM57vBBd/vH5JkSsgdRPRn5LtC7wG4jxw
TP8Ng5fP0+w/WysTQIoYMohrQrdZDGDhRUVb6Hi7RKev9DvCjBxLOnA66takwqTCIIAj
4c+KCBiEjPfuVRSoycIaYDXA326FGo1zbZ1lpODT2XbsqbTWNuOjGnEq2GLzHhLJHcjK
taPQ==
X-Gm-Message-State: AKS2vOwP0LFKspaZq++94pcoQdBy64vFvhCTjz9SrWHqAegSL+QAcK1H
4bb+S9c7bBbEME7B5G1H5w==
X-Received: by 10.99.44.209 with SMTP id s200mr5625301pgs.101.1498602448854;
Tue, 27 Jun 2017 15:27:28 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
by smtp.gmail.com with ESMTPSA id w123sm464119pfb.101.2017.06.27.15.27.28
(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
Tue, 27 Jun 2017 15:27:28 -0700 (PDT)
Date: Tue, 27 Jun 2017 15:27:27 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: dev@dpdk.org, wenzhuo.lu@intel.com, reshma.pattan@intel.com,
michalx.k.jastrzebski@intel.com, deepak.k.jain@intel.com,
harry.van.haaren@intel.com, piotrx.t.azarewicz@intel.com
Message-ID: <20170627152727.269f6f52@xeon-e3>
In-Reply-To: <1498469947-29496-1-git-send-email-radu.nicolau@intel.com>
References: <20170522143202.22424-4-michalx.k.jastrzebski@intel.com>
<1498469947-29496-1-git-send-email-radu.nicolau@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and
EtherLike-MIB for ixgbe
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jun 2017 22:27:30 -0000
On Mon, 26 Jun 2017 10:39:07 +0100
Radu Nicolau <radu.nicolau@intel.com> wrote:
> +static const struct rte_ixgbe_xstats_name_off ixgbe_if_mib_strings[] = {
> + {"ifNumber", offsetof(struct ixgbe_if_mib_stats, if_number)},
> + {"ifIndex", offsetof(struct ixgbe_if_mib_stats, if_index)},
> + {"ifType", offsetof(struct ixgbe_if_mib_stats, if_type)},
> + {"ifMtu", offsetof(struct ixgbe_if_mib_stats, if_mtu)},
> + {"ifSpeed", offsetof(struct ixgbe_if_mib_stats, if_speed)},
> + {"ifPhysAddress", offsetof(struct ixgbe_if_mib_stats, if_phys_address)},
> + {"ifOperStatus", offsetof(struct ixgbe_if_mib_stats, if_oper_status)},
> + {"ifLastChange", offsetof(struct ixgbe_if_mib_stats, if_last_change)},
> + {"ifHighSpeed", offsetof(struct ixgbe_if_mib_stats, if_high_speed)},
> + {"ifConnectorPresent", offsetof(struct ixgbe_if_mib_stats,
> + if_connector_present)},
> + {"ifCounterDiscontinuityTime", offsetof(struct ixgbe_if_mib_stats,
> + if_counter_discontinuity_time)},
Most of these should not be xstats. Things like if_index, type and MTU are available
through other API's already.