From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2E1FE271 for ; Wed, 28 Jun 2017 16:18:42 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BA19D20A53; Wed, 28 Jun 2017 10:18:41 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 28 Jun 2017 10:18:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=sg7 3WX4F/CW8K4Kz5J1lOlNJcdD3r1NOFNERbvOV8qo=; b=IkfsNWXRzE3QkH2+Z0Y 7JE9qkMHE6XvKu25DJI81FkJPIxLQT/u9+0VgyEuRBrQaKS0YjQUiPMAiTDGoBTB XjNGACArTvNoB1ipr3gdAfnJNxh0PDctOfoNsG9OAbryVtLb33TCCARzbAzSDAd7 t7Xe31swjPdSvILkBD/oZgXg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=sg73WX4F/CW8K4Kz5J1lOlNJcdD3r1NOFNERbvOV8 qo=; b=SW8hrP7Nb4fAUmtBMDzSkW1lqLiZkmBkP+DgB+O8XxHyAKmn9LlRNCqTc ceEar3uU3dQjEZscD5v+LujDG77OLK17NczrmqWcvu4DsveYJ+UROrvR+FyrAcWK KcLdAykQ24TEsBJhxLVeE/yTUAnprGTjPby+QH8De7F7LjKItXvB5IFIAjeHJNOj ZVTbN5hbaqBbYrydvJJ12DX7YxxphGaWvi58oCDK+mPYGdjuVMblHuqHjqiXdWTo QPNwGSAJrldVuLrgCUsoXmmMVwl/LbtCS17+VXSgZHltgpniKzJrGwl9apig9RSQ FgbzZ7vgW3RUdh7ohB8BqCsSEyW7g== X-ME-Sender: X-Sasl-enc: EIoXCUntP4/0NvLW/Y+F+YWy/4lY1V2OPGJDMRcU03xP 1498659521 Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2C41C240AF; Wed, 28 Jun 2017 10:18:41 -0400 (EDT) From: Thomas Monjalon To: gaetan.rivet@6wind.com Cc: dev@dpdk.org Date: Wed, 28 Jun 2017 16:18:19 +0200 Message-Id: <20170628141819.17360-1-thomas@monjalon.net> X-Mailer: git-send-email 2.13.1 In-Reply-To: References: Subject: [dpdk-dev] [PATCH] examples/ethtool: explicit PCI header dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 14:18:42 -0000 In devargs rework, rte_pci.h won't be included by rte_ethdev.h (via rte_devargs.h) anymore. rte_ethtool_get_drvinfo() could use rte_devargs.name instead of creating equivalent bus specific name. For now, it is workarounded by just including rte_pci.h. Signed-off-by: Thomas Monjalon --- examples/ethtool/lib/rte_ethtool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c index fabfcb2ba..252382cb5 100644 --- a/examples/ethtool/lib/rte_ethtool.c +++ b/examples/ethtool/lib/rte_ethtool.c @@ -36,6 +36,7 @@ #include #include #include +#include #ifdef RTE_LIBRTE_IXGBE_PMD #include #endif @@ -73,6 +74,7 @@ rte_ethtool_get_drvinfo(uint8_t port_id, struct ethtool_drvinfo *drvinfo) dev_info.driver_name); snprintf(drvinfo->version, sizeof(drvinfo->version), "%s", rte_version()); + /* TODO: replace bus_info by rte_devargs.name */ if (dev_info.pci_dev) snprintf(drvinfo->bus_info, sizeof(drvinfo->bus_info), "%04x:%02x:%02x.%x", -- 2.13.1