From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stephen@networkplumber.org> Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id B1D7D29CA for <dev@dpdk.org>; Thu, 29 Jun 2017 05:34:50 +0200 (CEST) Received: by mail-pf0-f174.google.com with SMTP id s66so43237428pfs.1 for <dev@dpdk.org>; Wed, 28 Jun 2017 20:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RXcYVIZChodZfq3HILr68cEeRsQ70oRkQ8LEVortVpU=; b=FpcTlQRhnf6dsAogwBK2ur1jwooPV0BKBg0ca/T3B66a8Rt8WCCrdzQjwHIEw95OPD A9AudLpJjClpoS6wYN8K1B8Mh8Cmmd22nxqjRiRWm34QsUuI3I9I4wRsOkfTjzoNWclT yMoatQDfWAD5TIdHT840F+p+fnAnlfrjE0Zk/gjdMsEtxqkcXzWlH2Xn6eKfI88n+gwG Om+u/CZNauVsO+61ISK7in5pqKExgvsoEonwYJgbV/0YXzm/iSShYD25gKD8QMjLdLjw 4bbF4smxbf3o2KyF3LllIKyscPblC4YP3rXFqisk8M7KC5Lzgjb3jc3PRTcDYF6VRq8X I39Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RXcYVIZChodZfq3HILr68cEeRsQ70oRkQ8LEVortVpU=; b=nZ1StzDcLmPtpWW/JQoZf/nIe+YLA7Ii8e7rZn/bExvA3w2HVTD6e5podoxMZT4ACP GqsgslFMRWUXTBC+SQD93sqagZhxZfWogYC+EkrvuWYvLumK0SWJ3SO+tBB50mCwGSZc LDe+P1hmTtLeSz7EhuAZhNAUchX9kEsGjIvv3gqa1tnixewsn8cCpU62iRtUXRYbGHr9 Sni1Yh/xCE5VMUQJJHxNy2KBNNcbfSzN4jm4yD6pHaR1btcbjSm51v3EeEFSDX6sWZyj 0fFQSByIObaCKUw/8IOrvJACiyLVRFMJvhY4k2X4rICDZIEZggwaImVcgnRKXDwdEx0x x+sA== X-Gm-Message-State: AKS2vOxWpHJyID3ibNqU1AdnFN1m8PghSfz8R8zUpTVGMuNZ2RbvBwBF TMy0zm+8ZMH0Mnfl X-Received: by 10.84.128.78 with SMTP id 72mr15441583pla.161.1498707289910; Wed, 28 Jun 2017 20:34:49 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id o6sm6858608pfb.110.2017.06.28.20.34.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 28 Jun 2017 20:34:49 -0700 (PDT) Date: Wed, 28 Jun 2017 20:34:41 -0700 From: Stephen Hemminger <stephen@networkplumber.org> To: Jeff Guo <jia.guo@intel.com> Cc: helin.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org Message-ID: <20170628203441.22e9dbb8@xeon-e3> In-Reply-To: <1498648044-57541-2-git-send-email-jia.guo@intel.com> References: <1495986280-26207-1-git-send-email-jia.guo@intel.com> <1498648044-57541-1-git-send-email-jia.guo@intel.com> <1498648044-57541-2-git-send-email-jia.guo@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: add hot plug monitor in i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 29 Jun 2017 03:34:51 -0000 On Wed, 28 Jun 2017 19:07:24 +0800 Jeff Guo <jia.guo@intel.com> wrote: > From: "Guo, Jia" <jia.guo@intel.com> > > This patch enable the hot plug feature in i40e, by monitoring the > hot plug uevent of the device. When remove event got, call the app > callback function to handle the detach process. > > Signed-off-by: Guo, Jia <jia.guo@intel.com> > --- Hot plug is good and needed. But it needs to be done in a generic fashion in the bus layer. There is nothing about uevents that are unique to i40e or even Intel devices. Plus the way hotplug is handled is OS specific, so this isn't going to work well on BSD. Sorry if I sound like a broken record but there has been a repeated pattern of Intel developers putting their head down (or in the sand) and creating functionality inside device driver.