From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id C191C3772 for ; Fri, 30 Jun 2017 11:11:50 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id c11so201163366wrc.3 for ; Fri, 30 Jun 2017 02:11:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=zAifJDT4aa77ROc5wX1qcMMHaX96CSAN4UOOJ63WizY=; b=0qzAVlYaRoU0UzQGU45liyiLIZP6XgwRBVuDUIf4lSa8YbGEBgZG32MjYhpXcPRW6E Qp4ECZxNs4cErsl4X31+aWUnSNJA9yumXKybKbZ4SOxFZAoA7Zg+8dBpqO997lV3APmO 4BoAakDxQTxbkP2h0OwP/XHJajenCkLmUW7sZWBy3Ls7u8bExxRla7gq2ONCQ7kmRSQU nNcM63LcsFgzD5a/sTcjQvBDaVHBGoTH6It4DHh3vVDkBlJl5Yoif2o1DijKtd1eclg1 oIPdieLbnNsOcsDQsAa87InIxY9VMeA34ivQmmIOaI8FitW4kGonCY1k/pNBcK8iv65m UoLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=zAifJDT4aa77ROc5wX1qcMMHaX96CSAN4UOOJ63WizY=; b=B+xK9WjR5kM84i5tLo9Ktwl3n3ovJT/DOxWB1uFJmtSlg8XUFeXDuiwOuqe9YPByyG LHR8FAnN3pfGbiwYBpLggUGKHkVGGi7yCEozzg/5BFmTpS+PCW4ZUveB2fJI3ZWfbPeb 5Lr3fsx993GfoguSQLFKuAQgZi4/SNWLzpPi09CsQYIp5PV8AmS4Pk4PlcCdGK/2P8v4 tC7RzLBtyLpjOxUxXlbsZ1LPHsXN3PF6fstRNd2IwypJEJrLUm0cgQFhYSK/pubtTJMM i/vYbYAvFHEbs02UIsipo4WWh8b7r4C10hgqDNQJiZf1jrU1b2CxOsxZIUmfeWberkFv H8NA== X-Gm-Message-State: AKS2vOzJQst5+S3gdhG0vDJ/PmSbplBAX6cc/t92wmFXXE89p7IYhEsZ sY8otvx88wuN8QnH X-Received: by 10.223.163.85 with SMTP id d21mr27256689wrb.95.1498813910415; Fri, 30 Jun 2017 02:11:50 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q30sm6469158wrc.65.2017.06.30.02.11.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jun 2017 02:11:49 -0700 (PDT) Date: Fri, 30 Jun 2017 11:11:42 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: Jan Blunck , dev@dpdk.org, shreyansh.jain@nxp.com Message-ID: <20170630091141.GM13355@bidouze.vm.6wind.com> References: <20170629182206.1072-1-jblunck@infradead.org> <20170629182206.1072-14-jblunck@infradead.org> <2830134.KdhWyS32Ir@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2830134.KdhWyS32Ir@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v7 13/15] eal: add hotplug add/remove functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Jun 2017 09:11:51 -0000 On Fri, Jun 30, 2017 at 11:06:03AM +0200, Thomas Monjalon wrote: > 29/06/2017 20:22, Jan Blunck: > > /** > > + * Hotplug add a given device to a specific bus. > > + * > > + * @param busname > > + * The bus name the device is added to. > > + * @param devname > > + * The device name. Based on this device name, eal will identify a driver > > + * capable of handling it and pass it to the driver probing function. > > + * @param devargs > > + * Device arguments to be passed to the driver. > > + * @return > > + * 0 on success, negative on error. > > + */ > > +int rte_eal_hotplug_add(const char *busname, const char *devname, > > + const char *devargs); > > After the hotplug, we may need to get the rte_device. > Should we add a struct **rte_device as parameter, > or should we add a helper function to get the rte_device > from busname and devname? Also possible: return a struct *rte_device and set rte_errno on error. -- Gaëtan Rivet 6WIND