From: Yuanhan Liu <yliu@fridaylinux.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Jianfeng Tan <jianfeng.tan@intel.com>,
dev@dpdk.org, stable@dpdk.org, Jiayu Hu <jiayu.hu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] vhost: fix TCP csum not set
Date: Sun, 2 Jul 2017 07:27:37 +0800 [thread overview]
Message-ID: <20170701232736.GE11626@yliu-home> (raw)
In-Reply-To: <b97ab9cb-4908-fb18-6b35-625fc61ecacd@redhat.com>
On Wed, Jun 07, 2017 at 09:25:38PM +0200, Maxime Coquelin wrote:
>
>
> On 06/07/2017 08:41 AM, Jianfeng Tan wrote:
> >As PKT_TX_TCP_SEG flag in mbuf->ol_flags implies PKT_TX_TCP_CKSUM,
> >applications, e.g., testpmd, don't set PKT_TX_TCP_CKSUM when TSO
> >is set.
> >
> >This leads to that packets get dropped in VM tcp stack layer because
> >of bad TCP csum.
> >
> >To fix this, we make sure TCP NEEDS_CSUM info is set into virtio net
> >header when PKT_TX_TCP_SEG is set, so that VM tcp stack will not
> >check the TCP csum.
> >
> >Fixes: 859b480d5afd ("vhost: add guest offload setting")
> >Cc: stable@dpdk.org
> >
> >Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> >Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> >Cc: Jiayu Hu <jiayu.hu@intel.com>
> >Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Series applied to dpdk-next-virtio.
Thanks!
--yliu
next prev parent reply other threads:[~2017-07-01 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 6:41 [dpdk-dev] [PATCH 0/2] fix vhost enqueue offload Jianfeng Tan
2017-06-07 6:41 ` [dpdk-dev] [PATCH 1/2] vhost: fix TCP csum not set Jianfeng Tan
2017-06-07 19:25 ` Maxime Coquelin
2017-07-01 23:27 ` Yuanhan Liu [this message]
2017-06-07 6:41 ` [dpdk-dev] [PATCH 2/2] vhost: fix IP csum not calculated Jianfeng Tan
2017-06-07 19:28 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170701232736.GE11626@yliu-home \
--to=yliu@fridaylinux.org \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).