From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 3EB0537AF for ; Sun, 2 Jul 2017 01:27:44 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id e199so21366393pfh.0 for ; Sat, 01 Jul 2017 16:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=nqRp9tirYhYJfYtzlNQMGYz/Wwte+gmQ7h6D0n52SRM=; b=q2rzwJVUMcukl8XQDQ1YdSOk0n9ZL7K4K92Ba2GUk1/TnoIn+9ZkZ6pxgG2Mcj2XlV Q/M3orvAzz5DLEzBqJNIF7bANYW+VtfuESZuBmwftwDAp+kUtEkIdejgKavu1Q+T/47Y m2ULBAuRHe2jFTSQjs84zsA5j5fZCcCnHwgvipqQCinkZ52gQuf/zt1rzQDzK9rwrRCS BNwyT8tCkz23tn+mosOXBfWeq0eDLpvR/etfUFSpQtULxih2+t0rNTPb0uizxj0h1++Z kVh1nPrjjCPafOaiKT+BrrH/NVxumNGs2//XagtiU9ucU6UAXBPE64cOiX5HI9GlVcbq 0jRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=nqRp9tirYhYJfYtzlNQMGYz/Wwte+gmQ7h6D0n52SRM=; b=DBTKlYWvuX8PBlp3onvqJ3WurSvnZOCxqq/D4AW36yXRUFjWk+C+jXAEuPucNH1QFF AW7rlv48haYOe2fA+AuDMZLzv5F4sLWAq2JTzvL918BcXrSDZmjFzi4a8GV9RoKZv04R CEv6Adzi31b2Q/pVtoR5x2A6F7W6nz5GIyfnRQhbVTvr1UUTXE/Rmh/jCXBstZb2vUof C4+Nf5OZegOBh5Lp87x53jPXM1HskShQeQxC9XE/IkgU9+h3tWCVXy4N+vSk5KYDu1dv ZnuG4h030rdTLPkSay+sgj4AmC2repI0irSZlS5FqMAja048IUtYM4JKbhizTQM57Je/ KDrw== X-Gm-Message-State: AIVw110Xg5luFoCbDJ27txeb8ypm55RcujJvIG4jy/LxTOXq6Y4OhM+d o4yBa/8NuxtJqctT X-Received: by 10.99.125.86 with SMTP id m22mr2705865pgn.96.1498951663449; Sat, 01 Jul 2017 16:27:43 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id m125sm25639761pfc.47.2017.07.01.16.27.40 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 01 Jul 2017 16:27:42 -0700 (PDT) Date: Sun, 2 Jul 2017 07:27:37 +0800 From: Yuanhan Liu To: Maxime Coquelin Cc: Jianfeng Tan , dev@dpdk.org, stable@dpdk.org, Jiayu Hu Message-ID: <20170701232736.GE11626@yliu-home> References: <1496817697-49130-1-git-send-email-jianfeng.tan@intel.com> <1496817697-49130-2-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH 1/2] vhost: fix TCP csum not set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Jul 2017 23:27:44 -0000 On Wed, Jun 07, 2017 at 09:25:38PM +0200, Maxime Coquelin wrote: > > > On 06/07/2017 08:41 AM, Jianfeng Tan wrote: > >As PKT_TX_TCP_SEG flag in mbuf->ol_flags implies PKT_TX_TCP_CKSUM, > >applications, e.g., testpmd, don't set PKT_TX_TCP_CKSUM when TSO > >is set. > > > >This leads to that packets get dropped in VM tcp stack layer because > >of bad TCP csum. > > > >To fix this, we make sure TCP NEEDS_CSUM info is set into virtio net > >header when PKT_TX_TCP_SEG is set, so that VM tcp stack will not > >check the TCP csum. > > > >Fixes: 859b480d5afd ("vhost: add guest offload setting") > >Cc: stable@dpdk.org > > > >Cc: Yuanhan Liu > >Cc: Maxime Coquelin > >Cc: Jiayu Hu > >Signed-off-by: Jianfeng Tan > > Reviewed-by: Maxime Coquelin Series applied to dpdk-next-virtio. Thanks! --yliu