From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id C2E062A58 for ; Mon, 3 Jul 2017 09:42:45 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id w126so159474183wme.0 for ; Mon, 03 Jul 2017 00:42:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0UEiaRhsiB4cOOJpq5FUwKS4jZMqwMw8PlhjsYUhW1Q=; b=Slwmjy+HsPhNNOxAZVrGlba8LYX/cpSCvnPVtDGWHT0CSWippUemJg6ElM94EpNg01 lj8ZZBkLcAjMiTDteaD7Gv4SErApmKmTZBzmy3Ltil7cV+48cJpLmCrY0TDWDKtLFCS7 sR9efFaD+bfthxGfA8eoM36HwIrnmGqFgV2PXuyFISuLRHuothq/HgkSMJcEVaNKd5T/ 0D/+idVwEGwKTXvazIUdbFdjdDQeADiXOvkrBldox88j4JajSVytbl7WbWN2DHyOIuvg F7xhG8uWv3wnnBaKzwECejZEUhdvxzhjFPi8bn1q0ZjIAnk8uLZCD38IRn7haVlO5Enk Bdbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0UEiaRhsiB4cOOJpq5FUwKS4jZMqwMw8PlhjsYUhW1Q=; b=iiKuuxEh8/NNnm8yT5i3sQuyn9TVjYxmItajYtE0rwkjWaElwkJymS3fvBkYsPaswb euaPHeMNy03dfehA0B8E0/4jD2i9vd5H12+lwQ22+zwdHNvrQ17CtOeodUBHrzkxGDL5 fF4suzsIx6buZp3iMzQL4/qBN8Dp/Ry0RrERoBZdMXxpTwiMddBS1XVTObJg3N9J6oHm PzMf3D/7RKscTcX8vYzC1FqC8OYsfYN4gNH2PGFxyrQKFBosESq6oODiPbaTth2yuoTG nSjwA0IeR98uZd12Eo5Y+sw9hcz2+kwjktknV8ZTaI1N408pmkT1iV87LnAd4a9VPRBE s5JQ== X-Gm-Message-State: AKS2vOxpo3BrDbQ1Hg3UlQ5EtTk/Z4luhXUIQVqZ6VnFhFD/BJnjyusJ YxmrtAyYZ3tEx8KkZxY= X-Received: by 10.28.11.84 with SMTP id 81mr23981846wml.82.1499067765401; Mon, 03 Jul 2017 00:42:45 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id c55sm15698282wrc.7.2017.07.03.00.42.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jul 2017 00:42:45 -0700 (PDT) Date: Mon, 3 Jul 2017 09:42:42 +0200 From: Olivier Matz To: Kevin Wilson Cc: "dev@dpdk.org" Message-ID: <20170703094242.08afee17@platinum> In-Reply-To: References: X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] rte_ctrlmbuf_init() and CTRL_MBUF_FLAG are not used - shouldn't they be removed and deprecated ? X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 07:42:46 -0000 Hi, On Mon, 3 Jul 2017 06:51:51 +0300, Kevin Wilson wrote: > Hello, > With the most recent master tree we have: > > git grep rte_ctrlmbuf_init > doc/guides/prog_guide/mbuf_lib.rst:The rte_pktmbuf_init() and > rte_ctrlmbuf_init() functions initialize some fields in the mbuf > structure that > lib/librte_mbuf/rte_mbuf.c:rte_ctrlmbuf_init(struct rte_mempool *mp, > lib/librte_mbuf/rte_mbuf.h:void rte_ctrlmbuf_init(struct rte_mempool > *mp, void *opaque_arg, > lib/librte_mbuf/rte_mbuf_version.map: rte_ctrlmbuf_init; > > git grep rte_is_ctrlmbuf > lib/librte_mbuf/rte_mbuf.h:rte_is_ctrlmbuf(struct rte_mbuf *m) > > git grep CTRL_MBUF_FLAG > doc/guides/prog_guide/mbuf_lib.rst:or generic control buffers > (indicated by the CTRL_MBUF_FLAG). > lib/librte_mbuf/rte_mbuf.c: m->ol_flags |= CTRL_MBUF_FLAG; > lib/librte_mbuf/rte_mbuf.h:#define CTRL_MBUF_FLAG (1ULL << 63) > /**< Mbuf contains control data */ > lib/librte_mbuf/rte_mbuf.h: return !!(m->ol_flags & CTRL_MBUF_FLAG); > > rte_ctrlmbuf_init() and CTRL_MBUF_FLAG and rte_is_ctrlmbuf() are not > used - shouldn't they be removed and deprecated ? Yes, I'm in favor of removing it since a long time. This was discussed and partially removed in 2014, because there was still a user of it in examples/. But it looks that it's now unused since 2015. Let's see if someone complains, and if no, we can plan to remove it for 17.11. Olivier