From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <yliu@fridaylinux.org>
Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67])
 by dpdk.org (Postfix) with ESMTP id E8F842C8
 for <dev@dpdk.org>; Tue,  4 Jul 2017 11:17:35 +0200 (CEST)
Received: by mail-pg0-f67.google.com with SMTP id d193so7652063pgc.2
 for <dev@dpdk.org>; Tue, 04 Jul 2017 02:17:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=fridaylinux-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-disposition:in-reply-to:user-agent;
 bh=Ql/jZDrHVmK3ys8OIgAoRcWGDseLOLSSMVDMwAxLlOU=;
 b=RORXqFp1//294Jy3lvJ9I3AYv45j6GDMOUfvHKjnlxlL68HZKePyVZtJiD3DJ/DoLs
 16HRmUu7yLfMgF9ft5AEJksM+D3rTwdRPydQQi5jr7/gjzugUTdVroy1aXHA83jO0lYx
 6Hd3LxQ3BEaMCVRhhmC2TAm3VO/8GWKaUPZHqc70iMhkooNnNrXyY4KTG8Jup9AJ3R3p
 tlqJ4XXOp8lSFnKOZ9sBsifvT6cZ8QOHZ9xBLQI4rwSxRMChWSbGk6mW6JDi21XcA2ai
 kiY9EXuCz56wGXgt3a299HvZmz5H4Btvq00xHn1m1+QedbZrdYDVtAJfTGDB2V9YKfxl
 n3iQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:references
 :mime-version:content-disposition:in-reply-to:user-agent;
 bh=Ql/jZDrHVmK3ys8OIgAoRcWGDseLOLSSMVDMwAxLlOU=;
 b=rzAl/BOuGeIAJvwN21Lbm1gI3ES4pMdbHwSryBgfmSH/Ja+xr582QDWCgnzogBgRTN
 lYKAd03vGd+u3ELRNLBIaO4giTpV3qjMFTgGaE78cQaRoWS9i1T2xKXuM3je+CN1eq5d
 BhkBqTcv9x0hx++z/nqJFyhmbhJpuy85cf9oGarmS8/vhhf3ZXCKelOzd9WEs4oH1pxW
 IhzZ+7uVtTLAo1pJF8/Km33kyhLTvYj0Uf/CDOXzaEZ2vxTwEjxuEtijPXeOKx2zS3yj
 Wq0MNkuB7dp8i9VgMSdUMP7NTKf5hRgL6ZY/mR3NY5NJAJ6vMOYOxvkYp50whz9dMM0O
 nFdA==
X-Gm-Message-State: AIVw112KZJNQPGUZ1H79jQamiYAq9OLpNxDlxoDwaXuazDEMdaEJ1SpO
 PYxzFDbWqjhyhGdw
X-Received: by 10.84.135.129 with SMTP id 1mr15083951plj.12.1499159855246;
 Tue, 04 Jul 2017 02:17:35 -0700 (PDT)
Received: from yliu-home ([45.63.61.64])
 by smtp.gmail.com with ESMTPSA id g79sm39112300pfg.121.2017.07.04.02.17.32
 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
 Tue, 04 Jul 2017 02:17:34 -0700 (PDT)
Date: Tue, 4 Jul 2017 17:17:28 +0800
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Jens Freimann <jfreimann@redhat.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com
Message-ID: <20170704091728.GN11626@yliu-home>
References: <20170704085043.3662-1-jfreimann@redhat.com>
 <20170704085043.3662-3-jfreimann@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170704085043.3662-3-jfreimann@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Subject: Re: [dpdk-dev] [PATCH 2/3] vhost: check return values of pthread_*
 calls
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jul 2017 09:17:36 -0000

On Tue, Jul 04, 2017 at 10:50:42AM +0200, Jens Freimann wrote:
> +out_mutex:
> +	if (pthread_mutex_destroy(&vsocket->conn_mutex))
> +		RTE_LOG(ERR, VHOST_CONFIG,
> +			"error: failed to destroy connection mutex\n");

One minor comment though: {} should be used for one signle statement
spawning more than one lines. See section "1.6.2. Control Statements
and Loops":

    http://dpdk.org/doc/guides/contributing/coding_style.html

Anyway, I fixed while apply.

	--yliu