From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0083.outbound.protection.outlook.com [104.47.38.83]) by dpdk.org (Postfix) with ESMTP id B36D7374F for ; Tue, 4 Jul 2017 13:14:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=VIzxjqsDr0L3rS68S68wtdCneDtlNK7q/SeEHb0bF3I=; b=lBNXyz+CALiAXl7MVx4aXsWyBl2EC9yAR7nULcChpGVQI027lbxd6C0g9DrQO5k62ROoeBASqqdmVjkW//iKaML94GnHblQUmUEQhUlBSYBjZSeVGC4nsPsVBhSphHIRhrOp4WCESfC+FPLRDlBAMp8DQP1S9qy0jmBX/tU+zmo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.200.206.49) by BY1PR0701MB1723.namprd07.prod.outlook.com (10.162.111.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Tue, 4 Jul 2017 11:14:26 +0000 Date: Tue, 4 Jul 2017 16:44:11 +0530 From: Jerin Jacob To: Harry van Haaren Cc: dev@dpdk.org, thomas@monjalon.net, keith.wiles@intel.com, bruce.richardson@intel.com Message-ID: <20170704111410.GA13340@jerin> References: <1498735421-100164-1-git-send-email-harry.van.haaren@intel.com> <1499031314-7172-1-git-send-email-harry.van.haaren@intel.com> <1499031314-7172-5-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499031314-7172-5-git-send-email-harry.van.haaren@intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [106.200.206.49] X-ClientProxiedBy: BMXPR01CA0011.INDPRD01.PROD.OUTLOOK.COM (10.174.214.149) To BY1PR0701MB1723.namprd07.prod.outlook.com (10.162.111.142) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c19caa3-07bf-4743-476e-08d4c2cdd625 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY1PR0701MB1723; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 3:91QXN6I/A/963qBB5N72tEoRTYZAtv3IH8dYxU/kiPlNFLpqyeR3HzM3UJq7hkjs9iBepVH3dvQwh6xvq53vqMrLSn3NKZFfidH+PdsGddCrQldk1LNcgThi9kV82omr2/wMGXCdBBV3Ds+08EqZPxD5aKAPq/uwNzgA+RuyW83rOxVUHqxC0WVA/yLbqdjVaJW1lpWddZUCf9Um3H/24T21NEAhJwwq4BA5Kf4AHTcRea2UWaMta/xy4/1uHeh/NM5E4KJ7Wfj6f5xdnjxaNdx81ISniPhr7FR6KG1Cjsef+4XWdAsgeZRv1EjAkf2imB8rshDdJ3hQsakyvmhjRhIhuB4b2SmFnFDk6nZ4POVkjH9QV75WebBX/QVcizxegfiYiky4jMHxuI9NlCqcbpntzm7ac9iiYjB3+ZBSGe46BrzpaNsKQOdCWvubNw+3DAjujRrztD0a+00kDYpTwXQzlPLULZBmTbEP2Mm9rNkDHW89/qFr8GORgb6cfsoXG3IuR4kVatH8ascyuTAOge+zJ/094nG3V0AXE5rtny9MJs0uRDNURQZ5ZXraRan+Iahv66aNmCZrexC3YNH0A9Mp/wPgQbNwXVQaWePcnsxJ6YZsaNbSmWKRdpKxVkRT8cgP4EXe9GtI2bMv7/tyGMoAoCvSNbrnoGdsk/lgN1CGNsBA9RO36/lGVwDvZT4VmqbVtApy5/2VwMuofRrzXje9SeLND1a9DDFBNtqkYQkg1Nu3vAmi78K7MYlCMPny X-MS-TrafficTypeDiagnostic: BY1PR0701MB1723: X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 25:5UMVxbQUFs/OP5OLwToF6NymAdtgmlTdh4A2jzZHaUD8MHD03Kg08Z1TXZOD+WZPEjNhCZH3sY75Ff1JmWrbzU7ASK8ZoGy+oTR8BMkFu+U4ulc1st9w6MH3mpdWjqas6dgFgRmcns+a131lh1op7YB55cx2VLSq9Eo9alGzsnofKb1AutS9raGDDwVaLrgcd7PT6cpA2czvVoNbYFlb+Xw36/G67ejOoM79d8gLto26c8zzU+NiBB+HtOTyEUxn04N460zP3ZxXuB51oolOiTOy4/jNdxbvUADuQWwEPxY54sk8PPrP3zkA9aNbmtL9ZCax3GHwgimrsplQPagXYnhHWudycBXsFsA1d/Erej6IaclxZstlDKK/tnCvzZ1AyZjeMKaF7g205AoaH97YflhnkARxuBn5U69fvTxsvr3ZYNpM7Z5Rqhewp75ofH1BkwRZe154CfsHa1KrgZxvwAJICob3vsrO1H1OmNhEMyKH42tTX+CbP1HjiZ0UkLKOagnCEL1l/RzHyxQjqiKvpIYNt2t2jeHFfdKo8AjT1ZZKRYCl9cWBbjQaZCd6qYPN0n6LNzrBS7R9+Zzxrvr35XKZb1KrteUmSE3Xe1a3hbnMO8ojWUPG07A9NuDMvM9QMWPuj1Tks8hLodsPho1HpJfV1RS48kUcYVWhcJCHcU2RKLYmDCbhAWLW2zYJXYlYgY2inNlbrCydIWgVW/f00b/jnM3ssOruRIYGC19KDTMrlDVyMGTb/jEMC1blc78yibfRb0ID9A1PNgEnaTCt6FnC+0r/lkZoQNNWbVpf4mjXH812M4Z3/hxyHf/uJ+XnxPgE39ZIjw9HMHPXg0FVAORPp2SzAFSbVTnmwtjd6v+FWpnwdJbwU1FqK9dUtABKzBGBpZIL+xDzE2hvxNp1A+/xEX6LlsYJJUhqnmJJVD8= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 31:oVyK+aJPvbl75ZkfAyP65blXrIUkTswjqJVohgvOQudDGhqxy7dPfSmKZOh5ykIGQNEHoNl2H1urdlcckpCXBb81rsrMSlBjNAXTEED8FTHBzqeQDo11JlYGMa46J4v0FTQXauuylqvxiqj2p+vYtUpRmh33EAa/03BkH92CVoukBZCQjwoPHrK/mOUpSOQgqHfagDeV8cwP/kPR+1OWZmr7ce2q+aUjiYOckUJ0U8xS92EU2XzMizt2pCxWy3nFHCqJ+IZQ/quUmVzMbXE9RGSEnlAlXZMg6Dp5zF2t0sE9gswytickNR10kmpdAUosPZLtojv8q8cPpfOc8YW7cJXz+E50hZ25OZyhN+W+4ieMOYxnY066+fBJ3xTqRMCIMcAZ3a9+dxAgRxemBCa6soGFZsk6XeZC1xl7s2QpruQiki2yRE2JvD01zkhr0+Ww06bysYJ7RykyGbQV89Ky7tqzThKgPMZ7DZ0IGLAei89LX+yDAUTGoNBvOBP3PtRRKTdZCXczcUGXSRhiB+OeMzNb9mYVc1Qui1nfVE9KSgr13rBrqz694P08qG2WGU0AwxEP7/pjXaY0wx3MvJ5cfT30WTxJDMG09LdDrJxR9lHSRzIaa+IQ35zI9ZFhwAIz/GnFt2VaTyqnrs4WKRDLNHE37yOYR9dVIXyJXl1zIApk4RtRZsdykypbbB1NDwO8nUBjG/NG8BruXImaiY/DrQ== X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 20:mrZy3mtrESmNM0vKDUkmMEukJfVQ9YvNX8enECmbAkvHoLnYHBETdgL3W38W6p7CPHRJ5cmGRKx0CFvog45Ki9KZ7MTIr6V2Dp29VDwpUnySWv6e25HrJQoCJm7LW8nJPCRq7NqHi1P7yPNV9jD+YCGlfhaC/NocMyA4U0Lsh6qRpryp0Cbqbwm1PtKGqbQ8nfC50MhRU1jR8xpHSic+4AKo72mFbHLjnRMuAOZcL/5X1HrHqrM++vvlIJXR1gnTtJuY1G8KHjpuTvaa5ExTGOIhznKArbRbSGBr/NIPf0xbvc04+DMROlc1nLym/wRcIQmWYYM9o5DnEBwRPr2BrUVIvwBtI51HxfAVPqPr1TEthZygIERPXWzLKznL7abzfTDYfD688zyI2MivrpEHgk3qDNjfAKHsiSYzk0d0f61r0g1qeHCLQuTJ1oMJZ9gi3OnHV0beUzeYn3r16NeDaFGkqQjFeByWPoMND7+2e/B+/+9NP+9BTM8ZZbS7YubMIUZShIN0XhWxhJvUHolntDw3cAtwukfI/Wq/ZWKQCkK+wRMY7A/K1AGuEwQcJJUmDyOmHhoDuvGau3zdLUYCp0knp9wYPJTVoUR6Bshh/3I= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(236129657087228)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(20161123555025)(20161123558100)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY1PR0701MB1723; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY1PR0701MB1723; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1723; 4:D6nFCTB9Ly6wuPQpm4gc4Dav0z3AbkCR4eLx+SXL?= =?us-ascii?Q?2iKFIU4JP2hEwgKN1WwdDwtZrj+MsR5NxUrPCvM2eZ5I/PtcOFeX+N04xv3M?= =?us-ascii?Q?aSTZe/L5GZHeMjitBROMZBMAPjy0ZUqoGRpfENSR2T15/Vj1oQO4AjXozTyt?= =?us-ascii?Q?oQ6bAvrCl9+brRHoIysl4F0LKQccdyQ1UMwmSpE3uVg3gI79uHzYV0x/1d/h?= =?us-ascii?Q?e0/UIMaYFciljyCY7jf9xi6Mo4h80XiDto8lCEtc8+TPrap1BkYoYSf/8fpi?= =?us-ascii?Q?95qkBx6Qe4RMy6ari1zGlowOURS2J/sPTOXKXI+RCnfDx5TeyQtavP5PBu9I?= =?us-ascii?Q?egwz62V7JdaH+OYSQwvEKORj8ntmkEp1bePdFnUjFRKH+zTqUmHoE1KP8w5g?= =?us-ascii?Q?pl1DUtFK1Un5RyqXGyDcAvxdaazPBQRW1Vw6cWV/Tm5Bezea4xy0SAG6Jjiu?= =?us-ascii?Q?tsATLnL8yt/dw0DnpAwAXm8/dY/3BPaOFQdGqUUVvGeVz/VimZekYw1MHQ0P?= =?us-ascii?Q?tnQ2E18RIP+70ih/TMviNQnH3P4u+3C75BMFtSxy7o9OW+hgOPQo05EfeNnZ?= =?us-ascii?Q?Orvf08tYSbms2GzJ9j2umcPqQUzChUiTjBgNI2xMssDZE7899+W5ALIJQMk3?= =?us-ascii?Q?SEqLhLHgI4c5O3vRs01NgBoKKfPCNnH7HSdRQ0FB42Rt+9Eu6bF2k7LnvCdP?= =?us-ascii?Q?NQkeINptl/iQ6dFswwf6F0XgxtPYuDbK7RZcYZUwaAkbpcBKERxkHEqP2dxz?= =?us-ascii?Q?k8jNWzgsnQl+RuZfF2MQ3ZD8y2e9DUw2Jr9NeRPjhi9lPNfi3arGIBfww5n4?= =?us-ascii?Q?MkvKMTIXA2usN5NcMis5/mNPoEBIdgsuKKYRPK3GtqRhNkWNtk3nGVd7xsqy?= =?us-ascii?Q?8l3AdRirZNZCN+VGSh+CY9FACiz7alablyd529CfU61LtgTCcXKh64ZbDz8E?= =?us-ascii?Q?0KTqV7/baBHqWgKx17xgvUmC6mOqk3vwKbFdVZd6mnWgKNRNWuIPm3vSJGNM?= =?us-ascii?Q?pGO93SFzjAiJKaW8MgLWgkr8oZ6wmfYT9qmMJMmoioUexwljCKoxDRI/RvxW?= =?us-ascii?Q?y4xUG05iuPRBZam9JQ9Sx1fVC7+IysykpJzqKrDPtqU0FqPYMxbll+00+NUt?= =?us-ascii?Q?wwX0rtMPceTXR6dUbeSAaVIep9LDxFowaOFhIglm8UwoyhwpObgD07eDOpw2?= =?us-ascii?Q?GQxrH1jYhzHYH3C/QbHdmSPQAX+lzaZwPZAl?= X-Forefront-PRVS: 0358535363 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39400400002)(39450400003)(39850400002)(39840400002)(39410400002)(13464003)(8676002)(81156014)(81166006)(47776003)(50986999)(5009440100003)(305945005)(42186005)(2906002)(33656002)(53936002)(9686003)(55016002)(7736002)(6246003)(23726003)(6116002)(6496005)(38730400002)(1076002)(53376002)(66066001)(6306002)(110136004)(189998001)(3846002)(33716001)(97736004)(72206003)(4326008)(966005)(478600001)(54356999)(83506001)(76176999)(5660300001)(229853002)(50466002)(4001350100001)(2950100002)(42882006)(6666003)(6916009)(25786009)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1723; H:jerin; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1723; 23:7vmmP2UKbdrbh6zCe7JtA/wUn/BQsUVt8zCsTCK?= =?us-ascii?Q?J6Vy/n6jYasLpCEo+Cvb9dn0CN/SJFI5KGijuoOZn73qzGNOx/Z7q96ffxUt?= =?us-ascii?Q?UVgam91HLvgiVDi6REkgtFOqF1XAcYDyZORjQtbZ/oqJojzRHlDy4v/+xdVE?= =?us-ascii?Q?nFIouMNmy7KFUs3dEm3+mh/YuJKzm4GkWcE7Xjd1KG9m8uWo5VrgLl42DqVr?= =?us-ascii?Q?IGqQvkNvgwomAVhT4ZcEQdFnMC56wiCzMUhhq1scs3KIy/ih9Fgl4U7bnULD?= =?us-ascii?Q?cVDtxMthfn8UqckMkIGt6D6TIeQnRtwQrOn5mSkWopvQ1d3NbMe4kfh3QdrM?= =?us-ascii?Q?svbqI2OaKFgdwB9ixAYggG9luI4Z17/s0KPkAZvXAPtyHxOkrz/7ABQfz1ds?= =?us-ascii?Q?xHsO5YmEG9b3L0vo0reRDMYUUMYznA9RXtZSvEyCXvmGDFTBBGHFmqzK8pnw?= =?us-ascii?Q?+N1mMTCU0gYvkybfG0Pnl5UFJx3/ZqkjdQp1YpE3emEgoZrYp/eGGLWu63vF?= =?us-ascii?Q?oC/8HYVdongL2VxFi2KpLrYhofB41ixKl06R2knHJhQmo0ySjrG5/hZ5TL38?= =?us-ascii?Q?d7DKl+Vvpqjzuc3llA8kkkAqAAZk7LmpP+v4tmagNfZY/LCUYsS0wviuPBNU?= =?us-ascii?Q?tD+WKguHdZV/lBqkJ9/Hg4sh7+PklgMc3bZhVQfGhYWcX/DDxonEJ0XKdoLr?= =?us-ascii?Q?McWAxH6CfpJqVzHxNe3Ldu/R7dq9iFeMA7/X2XxhPNnj63Znb3n3f//9Em69?= =?us-ascii?Q?PG8YjoL+R+rTjWSpqT76tjBRCdkND8qp7s7mT2dXVQ39rpUC2U4LuunZ1Mc2?= =?us-ascii?Q?tCjJ11rkLfOcrD4WT7vqm+kJcq81OxrtykGmTTEQWYrsB/J4AbuxeuvLoz7+?= =?us-ascii?Q?Zr6dm3UB9x6QtNU09tWVqa4s8t6YliY9DcQuAuc8NlINZkBsxIx0V8XYH3fX?= =?us-ascii?Q?hRO0vhjBCB4fBiGghD66Q6RckEgQe5sjWUhwHiyv37hnkSCBYHSbXNe19ifG?= =?us-ascii?Q?OgBH/Vspj26BAuB/slw7ETdgKjfdFIVmJpJsOIj7IuiO7teji2C70J47Aj43?= =?us-ascii?Q?bQNpvLt4a+PzoGLVbq5/QZ2dcyCBv4KrS5In8fJCqdg7lC3H0AJNgdVrg5r5?= =?us-ascii?Q?V0Amh9z8mxdWbhC8pISR5cGSx/1wChLnVlwMY7C4izDYxgz2YuXL9Ko6mEqT?= =?us-ascii?Q?QnDwnXpmfKsv5Gs3sPbhgf0WTojCSt9a4DNlyt9RKzJ2NJ5HQ6lSjwAK2DAn?= =?us-ascii?Q?yWfbwwc1sMh45dyB5Cd5I0xPoS2DWBHP0pV4cVQIEdXajtqvYIttKTySNm3h?= =?us-ascii?Q?qphv+VV4WXoBoq8NO07iaQ7U=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1723; 6:kxXQTsW7TqL5ww2LXqZ1+Bqx/8z86ob4rknTFXfW?= =?us-ascii?Q?2bfTs3W/Mx+GLZvU5lg9zbfnHW7JohinjrCyZoiuyIDq4duR3n8w72Y7t6F+?= =?us-ascii?Q?RdtC5db7ShfNdt5Bk7cWK7iKMZFk5GdfgZlgl/HY1fUhZ8DJM/BSIgayPRW4?= =?us-ascii?Q?7+0iX8YD7OL0yYjSOXVln4Kg4CvVs0mra07d77tEFF9odqVhVJoqEFk3RCCX?= =?us-ascii?Q?C6bwsYonNoHjHY2e9J+isssTbhYU3TAZNjmBGrXo5TnjQQg/g8nqDmQlrc5k?= =?us-ascii?Q?FY6extR5l5IFhw1bI+XOuP5HewfVtdpiGaZ3UdS+VRTHkhcde7kVvPt5t8pB?= =?us-ascii?Q?+Zy8MgzJ62VbR6Jow2/SEp8JeSgFxbFqCwHvV0osnSBfHYwJeRTxc+5UyiVi?= =?us-ascii?Q?wxd/iGrVm7MG7MnZ+MSY3gic9bQYp8gmzkZI7eo6dZ/WCQy3CKSRLR0L6ziy?= =?us-ascii?Q?bnUEqzUFGRru+RvVQHMcnjdKCJd6/Q6bfk49Heryke04fccjTa7cogLY6LW8?= =?us-ascii?Q?J4YCKmHCgzeGY553ihwkz6GYg+KZlDO+HUslxg8uRv2q38ax9wgu8FmE6vGW?= =?us-ascii?Q?QvvOXTjPdNigmTgyEJwdZ7Pbk+ICxhu58db0HWSwX+iHaoCoqgfBKWAWqGYe?= =?us-ascii?Q?Z1vU9pcaNqFxuriR++gzBzRoCWYPYqkhkxsacUx2ikmQDVT9jhcttxmlhsO0?= =?us-ascii?Q?z8V1Z25LF1LQKOLF21WAULKopEY1CkbsqPMgcGHNghvumFPiThp//WkG8gQB?= =?us-ascii?Q?wS+SF95bsdIlbtrlnqKUh+MznL9k8ijIfnoXCAREx72GBidn/2TCrHdF3hJM?= =?us-ascii?Q?Ci0z5b0TWk4NZjxlrog6O2ceeVuexNRkBSo/FvLrzu3Q6tS8/SYMGzuIfYRo?= =?us-ascii?Q?r6//nILtAhP4j6ctG6Jjn8a1c/dlMCu5X4bEUPD7Y+xs1t0tThKvu2Nkd/pq?= =?us-ascii?Q?zpgtjojzi6ejJqC6p/fov61977JTVh9yTP59N4IWkNlEzNfSka2SiPBtocTM?= =?us-ascii?Q?GHQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 5:7CIPA1+wMJJCZG75VudHtI9GcAqn616L55qO8HZf8MjUnTIf/R8ju96zQH0KV+6WgcJQgMsKwKCAtwTU9PLoG5B+JmhgYtt5yuu8ihzy9zdelGOVseY9X1zGdvTvbPhmdIOxA3Az3L0QwDPlLgUeqoADTAGCc29nG0tBhccFMtuRwmy49oloBGDP42fT0EFYAPDbLmO2TYr4AASr0YTAUUzDASSd+iE4fbcsFFWiZKyIzeeIIN9HSBRu6MMDhfPQtH3dRBUk4lJcG8ibNb8hapiQoxsJCuXAGOMAG6Nl1/lTrRUKrSXPmipFTptuswoiXTIBvIrnvr75L0kSl/SebfzLXBqDsmqBTiDCkr9d66ObMMu2M2ToJqX+DLmdZsmA2lQNAeSFrgdpxb2tWJJZMuQTflGWMTcY2MM2MaEiaeGDWYLTQQQmUW5tdvbQsco1XSxny1dz84oJ7U3ioeh29tAm4J8O7bkuqxKMneTEMTur+7faH2U0I83zDdm76603; 24:VIomcaJoxco8087xPW41zdyANJLbYd6OPT+ZNZCy0p/LqO0QG04Ge28LRP7fVrHGj1jlM759OgzIVUPmyzZrsYrRu3ToIiN0M7/E5DBcol0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1723; 7:ltApYFjaZYS2bJ0uKk+bRWSr2rY9t0lSInYEaa+iMDl5Hx4bqa+DFgXb4gQuiz0dkYEPvKDEbdtHxLRwLV+wU8rz3yqITMOFhvDsGJgZutRVte0wDrS9D1s2qVDHparBvXVZHInN0FJsZeylHW/NP/bukkoa+5NXmKnTQVTGRcvJ0ynHIhD7w/TjKWYe7icAkgl8LGbgAhqSyc5UycBscWSNLCCcdCsiaaey/9j0aLaxRDXjdpxRYR7e9lU7te8kXEcf4oEYj/iGrc7Pgd5tVZUn8SAWyp3ZKtaRxcFOHnHE+X5i29R407SJjZu+olQx/wiUM3jWrI+0gjMgHjp7ZzM7xtYqPyuRaWZ83Nwo+FYW9vpVrVr05uCqzc2uO6wSNlZVoR1eNU7qczkFGI6WB/617FhrC/WZfNMEOQqOlg9hKNF+3DJVXkpc9P0iE7y+Y01dEh+U6eTxGRRMBhrBHZrT1YUTHbbvqcODYp4TcAZ0y/BZP4veKQjM394p1hn5IWE1yhnoLH203Z3MTQxoMCymSZoNEbWsQSz03vQYAICoGg/HRMkwlg1IntOtFIR4HnWS/08Si3vaVr+VQzUu/h0i9Yn/e8KGQy8oy1lOf5Us9XnD9a3w8h5xwHTMvvYB5LOHP3AakcvgvQ3zHy+C04iuMNF4bsec2dWnf3CDF+lyvWWZUvf616YrwCXrZhp8NlJacvB6UbIhqB39j8wab34FnNtjzrOmxNxUev30+ms6Gafa34ZDTNFf2BQtA9ZTgKHDGANsm7oibdbcOM37WLChMe7XEcqltVeFxklJLwE= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2017 11:14:26.1054 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1723 Subject: Re: [dpdk-dev] [PATCH v3 4/7] service cores: add unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 11:14:32 -0000 -----Original Message----- > Date: Sun, 2 Jul 2017 22:35:11 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, thomas@monjalon.net, > keith.wiles@intel.com, bruce.richardson@intel.com, Harry van Haaren > > Subject: [PATCH v3 4/7] service cores: add unit tests > X-Mailer: git-send-email 2.7.4 > > Add a bunch of unit tests, to ensure that the service > core functions are operating as expected. > > As part of these tests a dummy service is registered which > allows identifying if a service callback has been invoked > by using the CPU tick counter. This allows identifying if > functions to start and stop service lcores are actually having > effect. > > Signed-off-by: Harry van Haaren > > --- > > v2 changes; > - Rename variable to slcore_id (Jerin) > - Rename function to unregister_all() (Jerin) > - Fix typos (Jerin) > - Add unit test for get_by_name() > - Add unit tests (all suggestions by Jerin) > -- get_name() > -- Verify probe_capability API > -- Verify MT_SAFE capability (see code for details) > -- Verify rte_service_dump() API I think now UT is addressing all the APIS. A few comments below. > --- > +testsuite_setup(void) > +{ > + /* assuming lcore 1 is available for service-core testing */ > + slcore_id = 1; Rather than assuming, How about taking enabled lcore for testing using rte_get_next_lcore()? dummy_mt_safe_cb() tests using the second lcore now. So I think, you can the get the enabled lcore for MT_SAFE using rte_get_next_lcore() and exit if two lcores not available. > + return TEST_SUCCESS; > +} > + > + > +static struct unit_test_suite service_tests = { > + .suite_name = "service core test suite", > + .setup = testsuite_setup, > + .teardown = testsuite_teardown, > + .unit_test_cases = { > + TEST_CASE_ST(dummy_register, NULL, unregister_all), > + TEST_CASE_ST(dummy_register, NULL, service_name), > + TEST_CASE_ST(dummy_register, NULL, service_get_by_name), > + TEST_CASE_ST(dummy_register, NULL, service_dump), > + TEST_CASE_ST(dummy_register, NULL, service_probe_capability), > + TEST_CASE_ST(dummy_register, NULL, service_start_stop), > + TEST_CASE_ST(dummy_register, NULL, service_lcore_add_del), > + TEST_CASE_ST(dummy_register, NULL, service_lcore_start_stop), > + TEST_CASE_ST(dummy_register, NULL, service_lcore_en_dis_able), > + TEST_CASE_ST(dummy_register, NULL, service_mt_safe_poll), > + TEST_CASES_END() /**< NULL terminate unit test array */ Regarding "Moving service lcore to/from rte lcore back and forth" test reply in http://dpdk.org/dev/patchwork/patch/25655/ I was thinking to enable the test by, calling service_lcore_del() and then call remote launch on that lcore to check it is properly in ROLE_RTE state. How about adding a test for the same to make sure the "Moving service lcore to/from rte lcore back and forth" is OK. With above comments: Acked-by: Jerin Jacob > + } > +}; > + > +static int > +test_service_common(void) > +{ > + return unit_test_suite_runner(&service_tests); > +} > + > +REGISTER_TEST_COMMAND(service_autotest, test_service_common); > -- > 2.7.4 >