From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com [209.85.128.177]) by dpdk.org (Postfix) with ESMTP id A6A7A7CD2 for ; Tue, 4 Jul 2017 17:21:04 +0200 (CEST) Received: by mail-wr0-f177.google.com with SMTP id r103so250855013wrb.0 for ; Tue, 04 Jul 2017 08:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0SsWnQHYd6Ct/KktSUs5ehGaxwVbfxj2s5msaRWbS9k=; b=XJ1prV1xaJnXea2SC+pJCgw+y8z4c2x6XQymmxrLQsbmJlNKdwrmmvZFxQ/9IeeZI1 9c4BX0mHHUG8qIDyllKU/K0QrFFp21eF27ohtvCkyMduLwSk0om3lReG84kobZLTb/Y7 a6vTCC9OaXZVru9evle3bS8S7zdUK3J4zfq9rLDX0lL5xGOpWn3XRyCEUUyygFfzX6to XPWotljtoUPoJntzwfxTT7qS9LIvU5Oksa7iYIEJSrv0SMD2Yh2n3ib5wb3ixB1Cd5Hm aC68T+qxfJEjqrlKhgRWKR9rZ5lmw74+QsG2/fkm/6+7NbkuzN7kT4CNk+Jf0AORvAej 3r9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0SsWnQHYd6Ct/KktSUs5ehGaxwVbfxj2s5msaRWbS9k=; b=sNJSth9q5ZBI25cm69Z9jH9WtFKdKDNejoT6GxJZ/gX9DhctpYjrPujIvyIwXfKwbk GpzbQY2n7Yex7oua7I12q9e0rgJdvrVyRR5cB7RAnVDesyxQzjyJEV3SrZ+u5HYoz90W TE7gxsZeK/qY7GpHsfvnZw8z3dj/QUnqvAVafgxJHlg0EpjpEhzfyPkanizI3pYNRHtc OqOo0DSbpCaQaJUONxX1NyzMUe+io3l8xN2u+i9ZqG/i7AhdtJOG+5ID4s3ca2a7RKQl RvPVNvdv46WeTpXSB0q9HRjdD8+SX+/bh2welwhJ0HWP/SqwQPQ+TAFw8ej/78VakkXJ shSg== X-Gm-Message-State: AKS2vOzbHsSCPG+Ibd1yOVh0o6D2GbtU2+i2YKndNTUQusHa3nnkGLlV 4I7OsO6dpGytC6dVFLg= X-Received: by 10.223.135.112 with SMTP id 45mr33673505wrz.133.1499181664295; Tue, 04 Jul 2017 08:21:04 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g5sm9017517wmf.5.2017.07.04.08.21.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 08:21:03 -0700 (PDT) Date: Tue, 4 Jul 2017 17:20:56 +0200 From: Adrien Mazarguil To: Vasily Philipov Cc: dev@dpdk.org, Nelio Laranjeiro Message-ID: <20170704152056.GV19852@6wind.com> References: <0dca86aa1372d6ff09d0aff01d522c580e0e24ab.1495717153.git.vasilyf@mellanox.com> <3d2050ddcd58151f23ee3a0813bb174131c3c63c.1499166724.git.vasilyf@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d2050ddcd58151f23ee3a0813bb174131c3c63c.1499166724.git.vasilyf@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v7 3/4] net/mlx4: refactor RSS parent queue allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Jul 2017 15:21:04 -0000 On Tue, Jul 04, 2017 at 11:22:50AM +0000, Vasily Philipov wrote: > A special "parent" queue must be allocated in addition to a group of > standard Rx queues for RSS to work. This is done automatically outside of > isolated mode by the PMD when applications request several Rx queues. > > Since each configured flow rule with the RSS action may target a different > set of queues, the PMD must have the ability to dynamically allocate > several parent queues, one per RSS group. > > If isolated mode was requested the default RSS parent queue isn't created > in this case. > > Refactor RSS parent queue allocations (currently limited to a single > parent) in preparation for flow API RSS action support. > > Signed-off-by: Vasily Philipov Thanks for making the requested changes. There is a remaining issue with this patch, creating a flow in isolated mode causes a crash due to RX QPs not being allocated. You should temporarily make priv_flow_create_action_queue() call rxq_create_qp() when the target QP does not exist. Patch looks otherwise fine. -- Adrien Mazarguil 6WIND