From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 398CB3772 for ; Wed, 5 Jul 2017 02:11:12 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id k67so254524788wrc.2 for ; Tue, 04 Jul 2017 17:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=resent-from:resent-date:resent-message-id:resent-to:date:from:to :subject:message-id:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=QuMYQszXPJF0gurupeQpPN0gNF9RjLuMeQd+ymIuhs4=; b=y3Jiumjv1fR0K1kTc/bv0OoCUmgQQsfJOsvSPNtl0BZxv5ZggDETXBUEFuYcOWaH1y 4p2qjPN1nZHZinZomZXpJJqASEVpZYB+49NkXPpIxVwbuDQtHmU+7C3Drsxn+YN1llLP Ahjhw/80W6ufvkU9ZCPnUmdI65NjICH8Y0qm6O8tepvoP2AfyLeTtOiuJsxiMhfAkMAr uSg+UUZr5qbP3ddWFHC694R9y1nsgmRcyxTIoatGBkvysdEh3V4qACDjAJi3FcBEY8TP Fk/Mv318NtQd7ZWZHGHlgk3YbGzfkhxzLNh7iN3r1YGENBtxzEEY8bhBVwT9Do+UIzdg 7Msg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:resent-from:resent-date:resent-message-id :resent-to:date:from:to:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=QuMYQszXPJF0gurupeQpPN0gNF9RjLuMeQd+ymIuhs4=; b=C3CNrOnHpWjhuQkIGbIPrmL7GhNVX+twb5GMHabszN3iVOk9Fra45H9cszrPcVoZBC 1kAaKeLoqRuk6IXB2R7aheEMLxX16wXf0iXZItKPPgvaTBR/tsiGMnHxnna9Q05DD7PM jJnvdAmygYmmHJfY1r2ed9lF+v924xRFMN4hQFUztIqSCstNW50s8CtFL5VXFc24k6bz CItFqDsC0fGb4DNYV9dxHvmJOlLyLV9vqA+FTYIfk78Kl0FyP3Bxfc/TZpwFhdwbxQlc x2f34ec1l00ZhUbc+oyi5NLH73HZ71gX5pRic0m8bgiZoBsEamazPluYTDftwQEZb0xy O+0w== X-Gm-Message-State: AKS2vOydMnFgEuZhRXaPTKV/TcPQ69Z8KgFZ0Y5CwXEUKLvhiaswi6gd Osv1ePGWrR+aWbEcpv8= X-Received: by 10.223.133.186 with SMTP id 55mr42295763wrt.102.1499213471585; Tue, 04 Jul 2017 17:11:11 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id v102sm8808260wrc.53.2017.07.04.17.11.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Jul 2017 17:11:10 -0700 (PDT) Resent-From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Resent-Date: Wed, 5 Jul 2017 02:11:03 +0200 Resent-Message-ID: <20170705001103.GF11154@bidouze.vm.6wind.com> Resent-To: dev@dpdk.org Date: Wed, 5 Jul 2017 02:09:02 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: dev@dpdk.orgR Message-ID: <20170705000902.GE11154@bidouze.vm.6wind.com> References: <06d9a7897cfa42f7993ad93644a70b1b86db639b.1499211959.git.gaetan.rivet@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <06d9a7897cfa42f7993ad93644a70b1b86db639b.1499211959.git.gaetan.rivet@6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v6 14/19] net/virtio: do not reference device type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 00:11:12 -0000 On Wed, Jul 05, 2017 at 01:56:44AM +0200, Gaetan Rivet wrote: > Signed-off-by: Gaetan Rivet > --- > drivers/net/virtio/virtio_pci.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c > index b7b3d61..6275359 100644 > --- a/drivers/net/virtio/virtio_pci.c > +++ b/drivers/net/virtio/virtio_pci.c > @@ -38,6 +38,7 @@ > #endif > > #include > +#include > > #include "virtio_pci.h" > #include "virtio_logs.h" > @@ -684,8 +685,8 @@ vtpci_init(struct rte_pci_device *dev, struct virtio_hw *hw) > if (rte_pci_ioport_map(dev, 0, VTPCI_IO(hw)) < 0) { > if (dev->kdrv == RTE_KDRV_UNKNOWN && > (!dev->device.devargs || > - dev->device.devargs->type != > - RTE_DEVTYPE_WHITELISTED_PCI)) { > + dev->device.devargs->bus != > + rte_bus_find_by_name("PCI"))) { Ah, this is the first, won't be last error of this type. It should be "pci" instead. Incidentally, it could be preferable to use rte_bus_find_by_device(&dev->device) instead. > PMD_INIT_LOG(INFO, > "skip kernel managed virtio device."); > return 1; > -- > 2.1.4 > -- Gaëtan Rivet 6WIND