From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com
 [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id 0CCB61C0B
 for <dev@dpdk.org>; Wed,  5 Jul 2017 20:03:55 +0200 (CEST)
Received: by mail-pf0-f181.google.com with SMTP id c73so133338540pfk.2
 for <dev@dpdk.org>; Wed, 05 Jul 2017 11:03:55 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=pBEVdW1RlQau4JoNlJ0OJu/+IW/Oz7voNomgBuQlJOk=;
 b=kj/bCIfgejXGoARYbR/PYe1T8T22iw0RyACSl4YVQsgXRqC5JXqDwG8KdK4GyMZkoo
 5lKAEF5L/DzwryNk9LqKsj3ewy8mITjaeP3H+WE8PjvOexmcwFBlt1g3KQlPY5ltnaOa
 VeKkE33/YqrropdmTQhZwSg0LKpotdmWFwziSKxA9N5UKRjXhdm+3RQFlTeNLon+1Ncz
 QgsKvk/EaPxjgX5RKnK3ltNIUugPpiA7PDaSGCf4s/jAYXXeA4FkIOTTdVLkEyHLnU5D
 p0yQ9GzoQkk4VM9wewZlnpPy0AP5yhw25K7lq5PPOyY9hNqfD3iCFie6Nek6jC74oodN
 1aUw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=pBEVdW1RlQau4JoNlJ0OJu/+IW/Oz7voNomgBuQlJOk=;
 b=UFHvE96l9YOBKkjcCl1qEH3BfZiFrfTD/VsFtHp7Cz8fpFlJ6SBr8KQloZjLwd+Ca+
 3FOwvBzfLBJjVUBRgiojx6cz1qJ9tk4t3wqnAXnCcHnuMWKgQpJ4GxK+nzyQ7/CBQi1F
 B4KBMfxePrlOCIz+rgfA47YETWWb6wBWC9TRnYTJrnuNYlT42ygcaxT2yJHQqhkL2Uac
 ILORpbhl4ZRR3USqMNcPx29YWMN1JKZo3tg1LxT+fMvDf7+foKu4Qv2DbdgXdVcLuSYe
 El1fYxHCdGR0ZX327FI4K/L23fb3CfVhvOwnQTSnHBeccoOSpu1Pb2iDYOU5JfIiqo4w
 rPlQ==
X-Gm-Message-State: AIVw110cB6YSKUeUUsfbhTjwCi5LaxMgL/eD4lxmtnsQ3jg7FsGfdX3s
 SSmjL1uPfKssezG9Z1f4rw==
X-Received: by 10.84.229.76 with SMTP id d12mr23259732pln.222.1499277835270;
 Wed, 05 Jul 2017 11:03:55 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id u2sm56432742pgn.28.2017.07.05.11.03.55
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Wed, 05 Jul 2017 11:03:55 -0700 (PDT)
Date: Wed, 5 Jul 2017 11:03:48 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org
Message-ID: <20170705110348.08a9ce7a@xeon-e3>
In-Reply-To: <cd5734d73c2a4908523b88ae5e04b7eec4aa9928.1499211317.git.gaetan.rivet@6wind.com>
References: <cover.1499127915.git.gaetan.rivet@6wind.com>
 <cover.1499211317.git.gaetan.rivet@6wind.com>
 <cd5734d73c2a4908523b88ae5e04b7eec4aa9928.1499211317.git.gaetan.rivet@6wind.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v7 6/6] devargs: parse bus info
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Jul 2017 18:03:56 -0000

On Wed,  5 Jul 2017 01:55:23 +0200
Gaetan Rivet <gaetan.rivet@6wind.com> wrote:

>  	case RTE_DEVTYPE_WHITELISTED_PCI:
>  	case RTE_DEVTYPE_BLACKLISTED_PCI:
>  		/* try to parse pci identifier */
> -		if (eal_parse_pci_BDF(buf, &devargs->pci.addr) != 0 &&
> -		    eal_parse_pci_DomBDF(buf, &devargs->pci.addr) != 0)
> +		if (bus->parse(devname, &devargs->pci.addr) != 0)
>  			goto fail;

Shouldn't these go under bus args for PCI?
It would be good to get all the bus specific args out of generic code.