Re: [dpdk-dev] [PATCH v4] app/testpmd: print statistics periodically

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Thu, 6 Jul 2017 02:52:05 +0100
> From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> To: jingjing.wu@intel.com, thomas@monjalon.net
> CC: dev@dpdk.org, Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v4] app/testpmd: print statistics periodically
> X-Mailer: git-send-email 2.9.4
> 
> Add parameter to print port statistics periodically
> (disabled by default), if interactive mode is not enabled.
> 
> This is useful to allow the user to see port statistics
> without having to get into the internal command line.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> Acked-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> 
> Changes in v4:
> 
> - Removed CamelCase
> - Used generic rte_get_timer_cycles() function, instead 
>   of TSC API.
> 
> Changes in v3:
> 
> - Added missing "|" character in help
> 
> Changes in v2:
> 
> - Added extra argument in help 
> 
>  app/test-pmd/parameters.c             | 19 +++++++++++++++--
>  app/test-pmd/testpmd.c                | 40 ++++++++++++++++++++++++++++++++++-
>  app/test-pmd/testpmd.h                |  1 +
>  doc/guides/testpmd_app_ug/run_app.rst |  5 +++++
>  4 files changed, 62 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index fbe6284..41ed74c 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -88,7 +88,7 @@ usage(char* progname)
>  	       "[--interactive|-i] "
>  	       "[--cmdline-file=FILENAME] "
>  #endif
> -	       "[--help|-h] | [--auto-start|-a] | ["
> +	       "[--help|-h] | [--auto-start|-a] | [-T PERIOD] | ["
>  	       "--coremask=COREMASK --portmask=PORTMASK --numa "
>  	       "--mbuf-size= | --total-num-mbufs= | "
>  	       "--nb-cores= | --nb-ports= | "
> @@ -109,6 +109,8 @@ usage(char* progname)
>  	printf("  --auto-start: start forwarding on init "
>  	       "[always when non-interactive].\n");
>  	printf("  --help: display this message and quit.\n");
> +	printf("  -T PERIOD: statistics will be shown every PERIOD seconds "

Considering all the option are in small letter, Does it makes sense to
make it as small letter? (ie -t instead of -T).

Other than it looks good and useful feature.

Tested-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>