From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0089.outbound.protection.outlook.com [104.47.37.89]) by dpdk.org (Postfix) with ESMTP id AB723271 for ; Thu, 6 Jul 2017 13:12:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=R8/a9SgKIHMLqIkWhTsyPHcCxGWVw6OwNuVtExGmE7s=; b=BCZJWPAG2s0hJPXakZXAgEAa2CGB4pE0Guy6xRzKSJe13mr0QiUBw2usIQY65b54JvSiia3M0V7DB3aehSh7UZ92cXkk3v62Ys1O/HNccw4/8j81+9WX8EfxAY2HSHVx4U+eorjjnjT5QYBFnFskPYLXpXKUNNNYx8lx7FH7Vrk= Authentication-Results: redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (106.201.60.201) by CY1PR0701MB1727.namprd07.prod.outlook.com (10.163.21.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1220.11; Thu, 6 Jul 2017 11:12:52 +0000 Date: Thu, 6 Jul 2017 16:42:36 +0530 From: Jerin Jacob To: Maxime Coquelin Cc: Santosh Shukla , thomas@monjalon.net, bruce.richardson@intel.com, dev@dpdk.org, hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, gaetan.rivet@6wind.com Message-ID: <20170706111235.GA7446@jerin> References: <20170608110513.22548-1-santosh.shukla@caviumnetworks.com> <20170608110513.22548-8-santosh.shukla@caviumnetworks.com> <730e333b-a9ab-df8b-cf7a-1e0186c6152d@redhat.com> <20170705154314.GA4635@jerin> <2fe366fb-15fa-f754-458e-3f4e8be18699@redhat.com> <20170706094939.GA1709@jerin> <89425d75-3f79-d3e8-f0b1-330292866bbb@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <89425d75-3f79-d3e8-f0b1-330292866bbb@redhat.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [106.201.60.201] X-ClientProxiedBy: BMXPR01CA0012.INDPRD01.PROD.OUTLOOK.COM (10.174.214.150) To CY1PR0701MB1727.namprd07.prod.outlook.com (10.163.21.141) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8055b73-f6ea-4312-22ec-08d4c45ff384 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:CY1PR0701MB1727; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727; 3:T/SwjQUP6VhkQi+FPJutn5ygcd+zddFxZnNWdPlk/FDBU8onbV0g4+ZDLda7PeUCZkffAgN1ixc1MSiO30ws0AYY7PNkdaeLllY5dpGsbOXpIh2RKCJvjbhotgvbEHRoV2A7h/1Mb200x+X4sKCMQOG3pFY+tsNHxLiqpPu+MfZTgq2iau+LrhIo1ppYRKPVvW6iGU4fKi6pN04Arm8X7OAsm/K4mdtSo0Y9fg1Cb798ACeAOz6Cu2ovI9aDdSWcl9nQWRXwqPDpurq59j94GbeDtfAdE/eyzxe8LTu8iV5YYcas2Bap6gKrpbUd0votDPSRicHX82rzDziC6TD6YhjiSUwMHFQgb4Az98Wm7bVICfTxtTzNQjYGrVKPddAy0Eoawdui70JxxvsJZnbjTiqVY8GzAga3IXb5Mk+xtuO3oqmpgT6NyCcXa3NY5S07OSeVHsEpusl+NOOVgF4KIthbQ2h6aS7zP2H9louvVd2oTo8rECQP9frYyTVl2vHQofrkjkATwEEJ7/mIrJ/BnEqCqOfRU7UZIX15FQxciEO4MEvfRtyEovqzhHhjFq+6iHmkzNHsjvCfVeL9tbdvFp57tXCAz24y6krZP3bQRCAn3e49wFc6cJ2urJZDYmyA6Qs+m82q3PZThbCZsdFEjoOzF/AV+pRjckK6YjhifvimgDhoJTX8+mYZuyppnioVGrvtQDDpznX3Ivt+0hwDuwuJVh5vEhizaRKMvDD699H0hO0QOqRdmGWBnH7Z4Ase X-MS-TrafficTypeDiagnostic: CY1PR0701MB1727: X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727; 25:+1j0cvw4uFaM0nCpTf4BXqa/SArq1Xpb7XN0+c8qU4hCmfRABQLCk5t6IbkBxgqWO36EIbhwz4ZqdXgZaVtclNsEkWTrc871zvwvxBwpLnQ6k9CKljx5K+EWewotLqnDc1AaK6b1e08LQhVrqKg2kdo1oS5NjqwPwrx9Cl1ysE4FMU2tAvzbkbjvyibvGGgt2RZhkuV9d0ohXJstt4v7t0c56V7WK+Y53wdjYut+3MuVpCgZZEO6emV+aJ+vycnO1zbcsOs/ysC3P1gTiD+kkFLiUwwOkom3PAoR1ziEupSRmfZks8BCknsHml4e6cnNOz3jgmAZwmMCDs8cXd/vpVs3XIxDH3JUD/FsV581OvuZjNaE1/eqeDftzn9Bq5od+8WHxJbhCgE9+Qnzpdt8pYiC4x5/zfYHZNtdFoZ8GP52hww372TUszjjM3f/J4DSDyIPBGPn1WsBlRlg7afMoenr0oA7i/dM3QGO3ztDiVtl3dm/ceEPduo3WH2ce6yfXlMx5e2+jiisqFbMY8QBAS/YOmj3hDyNM0+tHf74jYionSQGQ4ovXYN/8A2PK0Ro6Z/SjLHlLJ7dxsZzZ1DCwe8Pi4Cgpjv6XD1X0rwUy7ytiwmYJQreE2YiqxVcSVBnzWSWXRdUYHEgycSx+wSUysNvP0tnR/xhJT0DE6Z+GUsk/iDtBv8KxXGMJVKGNn3Xu4WkYbfXoNso0MVjPnwhz2dP1zDzdWnZovF3LLoz7LP23ayTwQmCMAWeczqaGfvBgVXgqfNQ2FHXMdwidvi4vvbUWv3fGVFVUvBRvl7fJw8tJLDE877sqDL7oQ8L8XBjWlkpMax77CgB2+Mmom84wmJ0Dch5DzkPhhuD5q5R1Ef6nBHQjTfsUjTXEUpNu9bFK+qGB9/hzQQV1uOrYGvHCFcG230Zt11xKc0lzVG3CJI= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727; 31:PqZmlm7D4gVllrNOKqAIVJ4Ov5y3RimIon+wpWnu/qEtFIToIEPzDHuVSAbXlBuRdd4mmOYmMfpnDwNIBEYKls/lu9wlffLBylo19eITE9EOG7xVCAofaarylUa/mRB7LV41RNcuoDyCwZVE+RDnfZPLHBsfPotXuU+TxNl/t9vpmrspNzdPYhVmWK1l199Ec4tunxwDnR8iLhrpSHh5icxYGMYKFN6VdCjlnsgiY5ASzo+scWBt5afZawoAcdumUeHuC25ymyww21Eep62ZuSVUOcE9fLk/JhA7ByAH2I05jqPXuNq4fGQuG9LQbsDyaDtN/WrXzVdNwCFT8eGJrrojhtq5Wqipuz91JjOL1nYaNVmhwQcXVqS/SRb9ZcYg5e3Qophj4hxRDC4WYOyvf9jm+A7o11GTTsZJgmcMx2BTnOWVym51hdbY0EwdbU1vuTkwrKbPyz4ZMwDhiSrLT0EpwSeXiW5doLJfwkmheXXkWNlmsVdH+xzSL4loyvU45N0NEV4ZqnRlb5ryo69K6wsRASy/uUojv+2PZCnN72HsbqcTndU2YtfXrkPa7IYJn1yjCnC9vEIAB+ZNydDaa437FpSLqoZq9swKzU5mJh0Ky7MV34qY6mw1UbJha3sboPFmlEAAjW67gjxPLb7s2tFXkzvDV22HjlnbRJ0rP8Y= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727; 20:/SZkHp8CaWKY+TlO6L5HkD9TaMAZoytBEJmxYQ+2HD3ws8dlkJz53gEDtNpu+4TSlMU2Ot78vXX+GGo8nPLFvlcD+tiGREOf4NQxTYkypVhAInooCRcVd7PBn8Zf3d/hDQixE62EzqmIp9JBEJCKpaMnwN3zNLqiPg4TDqixMBqTqdTi3L0zhCU12VYZP7HNCZ3pcGgfGg6tnOkl/p7iwCwisXLmwT6hGzlYJh4OEp78bd3/mvSZdlnE1EbbDKtSKuOItoeqCKU1PCYEVAyPvUam4g7P5Wap0Wa6rgb3+xzVS4DnPRRT7syM4vO4XOPmQHpQlP7itvy95JynI/qxMrKAk5kJhRiRHLtN57iwYYanIe4uDv4THm86oFFBiRsm85pbzKw3AI7yGJpSMpMu6n/xb7Au8qzk5+/CEU32sDoc6drVI3eHhjHzChKyuWJXjYKFXLBEPll4xFLJjp0UDzk5yWZ+k9TQn3pL4qz5WKw1ChZxCY/CQQOJXf6QdSNy3aaMzCrtrQlYv2khzm6w9at1d3VB/6XkDhJEgxdCU8hyYo1rc5dFE9V2VcH7DgsedbvenqK63mqOaqeeM+Xp0iKeHsetJoIqO4UCtQ7RnXQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(125551606395959)(236129657087228)(192374486261705)(185117386973197)(48057245064654)(148574349560750)(167848164394848)(228905959029699)(50300203121483)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(2017060910046)(8121501046)(93006095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123558100)(20161123555025)(20161123564025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:CY1PR0701MB1727; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:CY1PR0701MB1727; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1727; 4:vZVzZEVSaJ7rkOdCUqMegShtOcU57QqYjFr/PnIN?= =?us-ascii?Q?r1RtIGXvuPix4wjm7tpJGW13nU+88/z+232Lav4FOHJa0M8Ui102mvavb2gj?= =?us-ascii?Q?lPNbbgrGvG9gN+TCqogRTe9gZVn3PHLHgUqwcJFP582QmVHNXgbga07EPtDY?= =?us-ascii?Q?2YROY++Rcf7YkGluuZ4tRUrrHFXxFLf8/+tvNPMk9mGKpZhG63mhPiYa8l11?= =?us-ascii?Q?WKYbg21uC3++kzzSj79k2Z+O+EmKpb5BrCulbv3u4Cpq/UUDsFwMBdpUANfI?= =?us-ascii?Q?eiXaiEXIVNc2U+6OHE9WWf0oNvzwfbYMGjiaawiaihK14gPjVRpiYJpAYlsL?= =?us-ascii?Q?goWURmQ5YgbXVVHUpyo/FjZZON31XRze33H+/Zv37MuONg9yPWx1oqgKJfXB?= =?us-ascii?Q?lydDrKVWE4PP/Qo6G1W5U8AJARjiUl5ZXd3ky1jHu7DZc44K4CrPI4cEGumE?= =?us-ascii?Q?yskuWpmA3/od7wbqgoF+YayXmzKBMlrWD6mTQ7jkHcOQgyBRDNqzE8vqOYvG?= =?us-ascii?Q?A0l+6nfasAokhim8pwfJPXFLwTKv1q56GUOsEg2sEvMvXRJXnoW0TmHlVZhk?= =?us-ascii?Q?r5p7I7/8kJXLAEfmYZj5RdzwhxBnQiPCCixKGI5O65FMU2RaiSlfBHmvhvmx?= =?us-ascii?Q?sKPAgIlrws+wg2IeT3OuBdWVbmgrUH/lsvNUvIKVy+q3hHBISnBF2Xdm97yz?= =?us-ascii?Q?tqLZUAsBPa+1rZNiEpMIo422ARlVnXE8KlQB6KS7CFKJQIzBo7HJsriMxNyk?= =?us-ascii?Q?6Usf9HUfvmJ1ab5SOyK+0CGKzFbFA30/fSAbt9ltLLWE3+sWK9Rw5IyWiMFK?= =?us-ascii?Q?msZxBbleXak7Y5aPnL/Xi8TQapaBV8A9sga8F41JzjCFJJEt8PrEKxb9AwqU?= =?us-ascii?Q?03VwrkxYMUg7dnTQDO57FD334hi6biQxazgk6L7Izdjd0FNfgE+RcBNzaWME?= =?us-ascii?Q?aKsvIC340aKV8HQkHsV9C2+Gv2h+F9pbEhp8Ab72uPShZSvR4TVNNDEEU4Rn?= =?us-ascii?Q?lnOUt3S4mLZ+B/xkYWYjcNJcBOJ6keIpCwu2rh3jIWq7bNkr1zlLDp8n9E04?= =?us-ascii?Q?xENjM1ly1ckg/WIfkyQn4BFBG/gzjolVQOh0MQlM0yU0hf80MgH4JFkkoI9S?= =?us-ascii?Q?NWIhRgKNy+h56cVE6pblOlAset7tPGh2ny1gje7yo9Z0WV+gqP2NMAzlWdVP?= =?us-ascii?Q?lYelM/QtKFBjsn0vxbtwbSY6BO3Tg1d6tEN64VJ2Gv930pj1QZDNam6enaCV?= =?us-ascii?Q?LS9pMN3rzMEeRIzvaH9X79HLD3WSL8HQh6EUnE8b89Ez2r/81aKNy/LVt83b?= =?us-ascii?Q?cXihcE+zyNdcJ54o7YemJCMpXxzYgZlLfWkD2ROXP52P397F3vmvWBj53VPi?= =?us-ascii?Q?rJACmANIvCY7al1kQU05KOpIJHQ/W8YelKvQqmbskAsNdFAV1IwU03Jz1GEn?= =?us-ascii?Q?VtRPDwPw5J14/qLGmvXyMMDZM7g8r2N8WcnE3e7+PWDR7w0MtzhgkXQIkS/e?= =?us-ascii?Q?fnJYTZI7ZAz+YHmy2m1yVuPkL6+FxlsUyXI=3D?= X-Forefront-PRVS: 03607C04F0 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(39840400002)(39850400002)(39400400002)(39450400003)(39410400002)(51914003)(24454002)(377454003)(47776003)(6116002)(23726003)(53546010)(3846002)(4326008)(33716001)(76176999)(42186005)(551934003)(50986999)(1076002)(478600001)(54356999)(66066001)(72206003)(93886004)(5660300001)(4001350100001)(5009440100003)(966005)(25786009)(53936002)(2906002)(305945005)(55016002)(33656002)(6496005)(110136004)(6246003)(189998001)(8676002)(81166006)(6916009)(8656002)(6306002)(5890100001)(9686003)(229853002)(7736002)(1720100001)(50466002)(38730400002)(42882006)(6666003)(83506001)(2950100002)(53376002)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1727; H:jerin; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1727; 23:PRAJGERGX2GO34lJLwmSTNUplURmOBp2Av7/pJF?= =?us-ascii?Q?bNt2DQjtWyGTUhMUksgevye1QqKjDC94T3dVx2U5HqBAZoXYTzGOFqMmqadB?= =?us-ascii?Q?hQJLVDPQETsNutJwLJgUflfYHmQel8FfxKslGioR+RZzJ3p6sLdl9m4bQlDQ?= =?us-ascii?Q?cuQEvO8ihFE8wHVyCWbILfNtJkIg73Fm2VLRNEWlOSBEFgl4yKlwaC432fc5?= =?us-ascii?Q?PIdla+p+ePaByuXHcVhvtlP10bzfihkcGhXstCHhCUt6CBWaEYEHB1e1Zc4h?= =?us-ascii?Q?zfNvfCLFqW6x90OoEiknPdzYvN8uGNERP/JZeWQdnhNnkw5hGVzmDlKxgqwN?= =?us-ascii?Q?2mGVgVgHa6rhiGitJrOkPFOwTHucvw8CigDFfzwh3KpaebQ6gb8kGq0Ht6zi?= =?us-ascii?Q?aykVpfkh+DPqL0q+jLdNL85hUqEGWSFcvpRa4S5sCjN2EU1Q8i0hMLgeMDKP?= =?us-ascii?Q?0xMbVXCpcdIVdIu0NddxbkAmLEz9jOxcEdEa38n+mNkSqcZKzQdaO22qN3De?= =?us-ascii?Q?HS3+DQCLg9J+7AbGq99S9E3nEFgt9iHxJyMrbwc9J0NEsQUP1q3RY4pUUCHz?= =?us-ascii?Q?HgrvvCcbPYKacGFKvvitZVR9bsq8uztvpvu4W2Q38V3T9OzpM70Pd26iibLp?= =?us-ascii?Q?O0UGxk7eOdLf2ev8bt71PtS1pR+3vM6jaZnrxuClHqA1ZQVO5TbV1qzNRwIC?= =?us-ascii?Q?RYkO7XrFTkfMicEO3L7OsHNbDrhb8Ac9Ra1xM/HCeUyB7sEjZYp3Sb6ZyjqD?= =?us-ascii?Q?E0cEdoFTXmnjHoeSnmjAaqe0U8Ryojja9LGzuqaYs8KkvwVYmJ4ndIebjlaY?= =?us-ascii?Q?BpbTsv2OAjDqRnfH8B+88ImmkoSKd3EncVkypysN30czsJ6xEWw4S85P/Q+P?= =?us-ascii?Q?vLYOKj86B/h7XZtyaxs/OThZ+WeZUBA+86M9HK8JSsa7NwMmQigff1X6fK1p?= =?us-ascii?Q?qk97rOfNEidyOFyKWqE1KzqYG4W8IQzfVfcYKs2gtyeQs6uFdzADRyhWUeyY?= =?us-ascii?Q?AV7hGAXfkVZPfFxJDos6h6IUZ60wtwrFedBl/LM34YzK2KwMlVIT0yh5UE3L?= =?us-ascii?Q?zKTMzX9TKqSFYbW7bGDAc8kFuKFsqsg3Fiql+ppzV9iGGNDjexgelvf1Ik/a?= =?us-ascii?Q?teYDArw5mSNuWXVT5MEWagrBbm2tVEzU2OvA89nligl123XYAk/QnE+N67oF?= =?us-ascii?Q?ttDrcdCwpqO/sWM9gtTzlXZNsWn8O9UC6joJxCgH+BOwfcDruDM/Z0hlLNAX?= =?us-ascii?Q?N2cUDGOgLYtLDczBTBvbOzdHLVL8IvxMqaA/fOcpKzMhuqefl7nSyRCASNby?= =?us-ascii?Q?nNMaMB9fVx6fM/s4BQe4/plDZqThPnKqedECHheJxSsLrOvLriaQ3wauz19v?= =?us-ascii?Q?t9Lvoe2Gp2w5Si3oXjRyw7XBhlX3zB2gCyqphBGuOQFL55BZO55DmQO2LwDV?= =?us-ascii?Q?X7Agp9x7EssO7fzNMmMfXLW405UUefa0=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1727; 6:TmYdI9rgZz8UfKFJJMBu9aBMVYPPrF/HHDli1zUN?= =?us-ascii?Q?UEEw+o2x3ilMkvssLcMJfc7ulAGkWtXaq/EACAGMdvCE6QTbZ6EPLnSluZBK?= =?us-ascii?Q?IPdHz0UsTpiv5wAMfblrK3TgLuULOJu6kj1DcXkXcGHJGe8oyWJsHWt5T1dC?= =?us-ascii?Q?dXdY5jRKnJTtTeITHcSsF9Lj8j7x031k+OkXl8RpaOj4j26nHWXQMA+4z0wP?= =?us-ascii?Q?9rEx+yWpO5aZ77oVc3xbnkLAXo7h81ted1Nlvu1HaOAtUiXzMGLspP+9yTIm?= =?us-ascii?Q?yCtMMtnz4NJbj8OKTI+sY8KEEWcjowuVQIHlMafU+hunJVLaAhj/lPsE/7sk?= =?us-ascii?Q?fWZ4L6z56hd1ocx6jaotMw9XLkL98TPeAk7beBhoqIS+2woixOf9AXSFVsXF?= =?us-ascii?Q?t2LtNPAF3GA927cOdoEpwaQL1O95kCW9HIOgA8oiYIFoRL0bUt+iNIpWKp0n?= =?us-ascii?Q?WjP/eXweWBn2l6p1Ji6gnJRTVuHo1w5XBkDrXR5+BrW7YZV/NdB8DfRoJ/Fp?= =?us-ascii?Q?e0f0pGGip/Ww94GEzGrj7OIKt87gQ2MbqysbVUAx7jxWYQBC6OYr/005we5F?= =?us-ascii?Q?yVpNgoi5alRabqnwg4QShGjyuZBir12L3vhzZEGBO58MLexbvo5Ja0b8hUmM?= =?us-ascii?Q?ZkxeJdhUKPr+NX4HYl45Z4KmEsQWeVBEiexTSHWEEL2iOqfCwRdCkcxUQCQd?= =?us-ascii?Q?+UI2fKm0EqPYPttDmDL6vnrBV1fymVWFojlVOS9P1Lr1rbG7hEcCO3fZCEBC?= =?us-ascii?Q?74FfYYJe3G8Ufw++1eJ0gSY1Qrc7ndx1HlAN8qmJqFJa1CJXAq+WNGZWs/wx?= =?us-ascii?Q?R3i5vUekZGCG8jAU7ikCTYa8U7ZkKW1rfAZdGFbGH5ipPYbvUGJyM0YeEKlH?= =?us-ascii?Q?H/Ylf3R3FD41bAjHnaIwF+N+xBLfLpNWlFRmViasQdu/cH7ad0fbTDQZ0jbc?= =?us-ascii?Q?Q7IUanB+SWQSnE9zsg1YK9ezNe0Ka2Rdq5nlDnWtD46wVMVSglK2NU6AKEg1?= =?us-ascii?Q?0fQ=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727; 5:3aLSmvn/WgbzwVnq4X+32eSbLaxJiViasoD3/qvT/YB2m1BmL1UrSTLqmdKyWBX06Mppphr1tG3z4Axo3TJwZO2TTdDYLECUTt87iSxGgqMkz9nzk5g51qa7zW4oWoK2nuIm9c6X2TQkbRG8QnFBQPzTL+2f/eSL/OUqCOd3jxcothLLOd+PgB/VPd6AYfb1MgpfLMA4oyAI3TdY6C+6mB5qBYZlqm00i6CBNBXcRKhGp7bIlmSk/ZYtHri9nBTeTcoV9eOur0FxXhFfFuTFrDdUuXqgogvrT3GLM9Ze63tb6Z8D34/6iM8us4BTpysPVuAzIUY4CyvXimHKJmZAUxcFVFJ8CysL2Rju/NTitp38esRln7vwV/Ep818YmCcbx8c6ezoHaY9RnWOf4eqxxNHrbnwiKMT1IBgnuWUos0Euy4nBLVXCuo0eVXakT79JRHy3nOOS3uAaTjEZYt3ILdJRIeWCDojN/2olAdNmtF5DDHojvnz8HBbY3TRJN/Am; 24:kSXIOVDzIkslGe+N23x67N7SiMNv2k42DJ3SWIig46uz/RrpwAPVH/LhCFk28xcD9eJahquoW0VOflKwjb0Qq518g4l1mYo+YwCWhhcOCwI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1727; 7:1+KUOsC0fNf+7JRtK9AmIhIYFoPT0sZv/eqYpCu16b6lqQauDfklcpr1ayF3QtSizzlKXnbblzgLo/SqPuCWR9ob5tVMSdH1BKbX/NimyTkCToD6OUewsG6zQhiKPEZfnIdJahyhsVmbOG6WY9UjSp8bRVpSEbwKxqE/qoKLGgZrETfVOSqRAL83D6ZAw33sZ/eougwC/bwq0tmkHOaEkI2JdyaU8/iNYjU7oHmJP+edFqcskjOEAaLC24lOIfsQUdFZAuKoJzH/fJxaG2a/u8Npz0bidciHxK5QG9zh3lL6WiYF6z3AHcwAc35n69rersY07LxXJsgAJeu9IPQaWcseTTLRRnhNx11X1zLM1QF1bh0C9qC0ajh2ohNDgp5AZc18yBAo2yqHdMWYdPbmqkeR71F5Di1WT1t9gLSJFyGME8x3u5FuHqNsA3PnCzbMuWJ5B09DOp9I+q/QSJ/7xfXJAaucK1lugYi+p9rzOY6Hquegc8e4z+IBTfP85lmKOgyJs6GYl0ODjy+beb5wYtk8qxJKxlizERYCL6CqE+it1/uAHnL+xc0taW/va7ND4MbUQHvxaJ0Em3aTxRwJC1weq9GobK6cbLH7FnKTKY0q1a75atAWyunqpIjyvR0yVEmLsJ2DBROGsJMleuUsJZIy96cyQyaun+PkHahiB+G7qpbSUfXBLuzYM8hkoiS6oWsSKueeNcMXtRQ+99lXt2iwBfHEW+wkbBDTlTniOgyt7FC9JmX6mQAIKIeZf1jiYaiTfYneRmplgO96xoPIfuXrtfxQqxY6c3PWvvXDs2w= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2017 11:12:52.0823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1727 Subject: Re: [dpdk-dev] [PATCH 07/10] linuxapp/eal_vfio: honor iova mode before mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2017 11:12:58 -0000 -----Original Message----- > Date: Thu, 6 Jul 2017 12:59:04 +0200 > From: Maxime Coquelin > To: Jerin Jacob > CC: Santosh Shukla , > thomas@monjalon.net, bruce.richardson@intel.com, dev@dpdk.org, > hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, gaetan.rivet@6wind.com > Subject: Re: [dpdk-dev] [PATCH 07/10] linuxapp/eal_vfio: honor iova mode > before mapping > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > Thunderbird/52.1.0 > > > > On 07/06/2017 11:49 AM, Jerin Jacob wrote: > > -----Original Message----- > > > Date: Thu, 6 Jul 2017 09:58:41 +0200 > > > From: Maxime Coquelin > > > To: Jerin Jacob > > > CC: Santosh Shukla , > > > thomas@monjalon.net, bruce.richardson@intel.com, dev@dpdk.org, > > > hemant.agrawal@nxp.com, shreyansh.jain@nxp.com, gaetan.rivet@6wind.com > > > Subject: Re: [dpdk-dev] [PATCH 07/10] linuxapp/eal_vfio: honor iova mode > > > before mapping > > > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > > > Thunderbird/52.1.0 > > > > > > > > > > > > > > > > > > > > > > > > On 06/08/2017 01:05 PM, Santosh Shukla wrote: > > > > > > Check iova mode and accordingly map iova to pa or va. > > > > > > > > > > > > Signed-off-by: Santosh Shukla > > > > > > Signed-off-by: Jerin Jacob > > > > > > --- > > > > > > lib/librte_eal/linuxapp/eal/eal_vfio.c | 10 ++++++++-- > > > > > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/lib/librte_eal/linuxapp/eal/eal_vfio.c b/lib/librte_eal/linuxapp/eal/eal_vfio.c > > > > > > index 04914406f..348b7a7f4 100644 > > > > > > --- a/lib/librte_eal/linuxapp/eal/eal_vfio.c > > > > > > +++ b/lib/librte_eal/linuxapp/eal/eal_vfio.c > > > > > > @@ -706,7 +706,10 @@ vfio_type1_dma_map(int vfio_container_fd) > > > > > > dma_map.argsz = sizeof(struct vfio_iommu_type1_dma_map); > > > > > > dma_map.vaddr = ms[i].addr_64; > > > > > > dma_map.size = ms[i].len; > > > > > > - dma_map.iova = ms[i].phys_addr; > > > > > > + if (rte_eal_iova_mode() == RTE_IOVA_VA) > > > > > > + dma_map.iova = dma_map.vaddr; > > > > > > + else > > > > > > + dma_map.iova = ms[i].phys_addr; > > > > > > dma_map.flags = VFIO_DMA_MAP_FLAG_READ | VFIO_DMA_MAP_FLAG_WRITE; > > > > > > > > > > IIUC, it is changing default behavior for VFIO devices. > > > > > > > > > > I see a possible problem, but I'm not sure the case is valid. > > > > > > > > > > Imagine you have two devices in the iommu group, and the two devices are > > > > > used in separate processes. Each process could try two different > > > > > physical addresses at the same virtual address, and so the second map > > > > > would fail. > > > > > > > > IMO, Doesn't look like a problem. Here is the data flow > > > > > > > > 1) The vfio DMA map function(vfio_type1_dma_map()) will be called only > > > > on primary process > > > > http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal_vfio.c#n359 > > > > > > > > 2) On secondary process, DPDK rte_eal_huge_page_attach() will make sure > > > > that, the Secondary process has the _same_ virtual address as primary or > > > > exit from on attach. > > > > http://dpdk.org/browse/dpdk/tree/lib/librte_eal/linuxapp/eal/eal_memory.c#n1452 > > > > > > > > 3) Since secondary process adds the mapped the virtual address in step (2). > > > > in the page table in OS. On SMMU entry miss(When device > > > > request from I/O transaction), OS will load the mapping and update the SMMU > > > > "context" with page tables from MMU. > > > > > > Ok thanks for the detailed info, but what about the case where the same > > > iommu group is used by two primary processes? > > > > Does that case exist with DPDK? We always need to blacklist same BDF in > > the secondary process to make things work with existing DPDK setup. Which > > make sense as well. Only primary process configures the HW blocks. > > I meant the case when two BDF are in the same IOMMU group (if ACS is not > supported at some point in the hierarchy). And I meant two primary > processes running, like for example two containers running each a DPDK > application. > > Maybe this is not a valid use-case (it is not secure, as it would break > isolation between the two containers), but it seems that it is something > DPDK allows today, if I'm not mistaken. Not sure. Doesn't seems to valid case with VFIO as without ACS anyway it will break security (the all point of IOMMU protection == VFIO) > > > > > > > I don't know how frequent it is, but if ACS is not supported by either the > > > endpoint or the the root port, then you would have to share the same IOMMU > > > group for all the ports of your card. Right? > > > > ACS is supported in our card(it not in bypass mode) and one mempool PCI BDF > > comes as a IOMMU group. > > > > If it in bypass mode anyway you use in vfio-noiommu mode as > > there is no protection anyway. > > > What concerns me is that we change the default behavior for all other > > > devices. Having an option to override is fine to me, but the default > > > mode should remain the same IMHO. > > > > Doesn't seems to be a technical point. But I agree with your concern. > > we will address it. > > I think, we have two ways to address it. > > > > option 1: > > - In existing patch, > > a) we are currently setting(internal_cfg->iova_mode = RTE_IOVA_PA) > > http://dpdk.org/dev/patchwork/patch/25192 > > b) only when with eal argument sets to RTE_IOVA_VA and then bus probed > > value == RTE_IOVA_VA the final mode will be RTE_IOVA_VA > > http://dpdk.org/dev/patchwork/patch/25193/ > > check the code after rte_bus_scan() > > > > option 2: > > On rte_pci_get_iommu_class() in http://dpdk.org/dev/patchwork/patch/25190/ > > we can check the rte_pci_device.id.vendor_id == CAVIUM to select the > > mode so other type of devices safe. > > > > I think, option 2 makes sense, as it gives foolproof auto detection scheme and > > without effecting any other devices that not interested in this scheme > > > > Does that address your concern about the patchset? > > Yes it does, or maybe create a new flag in struct rte_pci_driver's > drv_flags to provide a hint it prefers to use VA as IOVA? > > It, of course, would just be a hint, and should be set only when other > conditions are met. Yes. Makes sense. We will roll out v2 with option2 + your rte_pci_driver suggestion. Thanks a lot for the review. Appreciated.