From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f53.google.com (mail-pg0-f53.google.com [74.125.83.53]) by dpdk.org (Postfix) with ESMTP id 3966A235 for ; Fri, 7 Jul 2017 04:10:00 +0200 (CEST) Received: by mail-pg0-f53.google.com with SMTP id k14so9634612pgr.0 for ; Thu, 06 Jul 2017 19:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=X8vY3jE9lBj+OpP+UiDHa1wZ5wdcTdf34cH2mU5mBRI=; b=LSA6ybklpbWOutjJ84qGzhdQIfc5Swjr9TdPE8gojTO4lILsw1ukcIhFJoN7Pz259o 2l/2pHFe3jo5wNAbfLpQzSo+vpwCWzzZW8brHmCw8kS7g/AcipWFH1R/mEzzFl1v11OE 8jm6lvhnqxK1G+U+1cMMB6Xu2VA2oDyy+EiMZrEVhBnfs9DS9QdLt8eb/Z6FIis8BfdG 96h4K0hufJ3feyizfjLdVAKh9jLDVVophlHgnAv0hBsOXn3y0yTNzPbiXlKRr2ctSWo9 G2QzVwm9XhgaUgmzAOwe+zdSmIcM60qs610BF//rORL71pemj5p9exbz152ARuL/MOJZ zkXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=X8vY3jE9lBj+OpP+UiDHa1wZ5wdcTdf34cH2mU5mBRI=; b=HJpMZelU9VLQc8x1H01MZJcWQEmjbuHDbUH1K7/iWVa2jsrH2Aaos+psy1cd6s0gN9 D+N9l5ac/XVNGm8asePxQTKqdkDdrRS16D0nLknLFyxNTll7diZtK0UJa7I5/Jh2D9bE +2P/mgzl6S5W2zhZuX8jDuv/Sh1qxrMIN8OVp5VKOTwHG3BojW57N+qSQuiNztA582PJ RI2UqaEdIxEvWRV5/HfC5rJph4jCobnmulzY3NwNHwUNNFRYBMqMI9e2yNVF3EXSHAwV C30uZBtspEJmV0Ptx0RrKIbwWWBb02PRr2tbW7HxJ4v7z1tDxGmTyUXLZH6Kw/CX0fQ/ 497A== X-Gm-Message-State: AIVw112ZJsD21xMPZGYm1jQ8NuhINMqHuAdoUaMNJNp+jkqNx2JzYkm5 bPgv7E9n2Bnp5Dg0 X-Received: by 10.101.75.197 with SMTP id p5mr25580207pgr.164.1499393399388; Thu, 06 Jul 2017 19:09:59 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id s66sm3461824pfg.21.2017.07.06.19.09.56 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Jul 2017 19:09:58 -0700 (PDT) Date: Fri, 7 Jul 2017 10:09:51 +0800 From: Yuanhan Liu To: "Liu, Changpeng" Cc: "dev@dpdk.org" Message-ID: <20170707020951.GU11626@yliu-home> References: <1498728512-12728-1-git-send-email-changpeng.liu@intel.com> <20170707005035.GT11626@yliu-home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] examples/vhost: introduce a new vhost-user-scsi sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 02:10:00 -0000 On Fri, Jul 07, 2017 at 02:00:38AM +0000, Liu, Changpeng wrote: > > > > -----Original Message----- > > From: Yuanhan Liu [mailto:yliu@fridaylinux.org] > > Sent: Friday, July 7, 2017 8:51 AM > > To: Liu, Changpeng > > Cc: dev@dpdk.org > > Subject: Re: [PATCH] examples/vhost: introduce a new vhost-user-scsi sample > > application > > > > On Thu, Jun 29, 2017 at 05:28:32PM +0800, Changpeng Liu wrote: > > > +.. note:: > > > + You must check whether you Qemu can support "vhost-user-scsi" or not, > > > + the latest Qemu code is recommended. > > > > You should specify the least QEMU version that supports vhost-user scsi here. > > Okay, will add Qemu version and commit ID. Just the QEMU version has is enough. > > They are common pitfalls of vhost-user examples. You don't have to repeat > > it again here. Instead, you could add a link to the vhost-example doc and > > let this section only cover issues belong to vhost-user scsi. Make sure you will handle this comment in the next version. > > > + resp_code = 0x70; /* Current + Fixed format */ > > > > Could you add macros for those magic numbers? I saw quite a lot of them. > All the numbers are defined by SCSI specifications, I think this is okay, if you looked into kernel scsi module or > kernel LIO scsi target, they also used the specification numbers directly. Okay. > > > > BTW, you might want to build it on a 32bit system. I think this patch > > won't build successfully on it. > I didn't build it with 32bit system before, I don't know the result. Nah, the build should be fine. I found it passes the build test: http://dpdk.org/ml/archives/test-report/2017-June/023091.html --yliu