From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f193.google.com (mail-pf0-f193.google.com [209.85.192.193]) by dpdk.org (Postfix) with ESMTP id 221D72BFF for ; Fri, 7 Jul 2017 06:49:03 +0200 (CEST) Received: by mail-pf0-f193.google.com with SMTP id z6so2978846pfk.3 for ; Thu, 06 Jul 2017 21:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ppcTt2Nd2uOERQnPcfxU52uMfqVfo4exP9UgL80tedM=; b=DCNlvY8dss/9k7W5WIZ/s+/L1iiOtpx3/ZuJvQcFUwPLbf3f29HMG/PTq3KLYh5fNx kK/71J+uvIv85t091JIQaqXIvkGzXSEMSYijgevbp7272qktrzj/1r8zJrZgYLW0kLfo swiSZK3oGAB9DvlA6FiAv+Q8fJqk8d2IInl8VTPJGmyYVcuzfPaz1/snyi4tQ+otb4Hu E25gIS+21Lu30bYYt6dTlJ/KnOEFzmJOrTXRnpb2E/tDLgXC5DbAeKbbmGlcY1JdNO2o i6LQoIKp1TGPH62/+R+KlRzWsGvltXOBfwz8Z9TvDlRU8treytiGDiJ5kGC4/J35rjzr ch7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ppcTt2Nd2uOERQnPcfxU52uMfqVfo4exP9UgL80tedM=; b=Ikqorsr9dkW0/MNXm4agQDtTxBMZuCqSeNzUnCTlHKuRvNHSJOb0mggKCGAno9Ggbi SfFUrkT0Lmgr7ItXM+tNzlO/N6ytXkEMKoVk1uy+hT6NJWm83/mqggjwfhpULsHt7E0h kz+3yCNb19T/VJiT7cbLW1PjJUGcjsoyUFBGQa5SvEJxC8fSftmFEL5tCIvUpoIqEL6C MGkZdCCuoxOqHH5MnsBhMlDI4+fioAOXNw9Px0q0B9TPEZh4F4RmGBcVtL9stDsLC29+ h56E0/kt5S5S4GBBUFXTq7D1DTUJN7jCNhLuUkYzEvW9LguwYTY0HIAM7bXkf6nP0eGZ flsA== X-Gm-Message-State: AIVw110rXCgw6+27VdQjwXVStY0Kv6Fc8CAmKURh50TeH3BN75WTrVEl mXtklasytdOIWmBw/fUQpA== X-Received: by 10.84.143.195 with SMTP id 61mr829310plz.47.1499402942375; Thu, 06 Jul 2017 21:49:02 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id q29sm4449642pfg.11.2017.07.06.21.48.59 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Jul 2017 21:49:01 -0700 (PDT) Date: Fri, 7 Jul 2017 12:48:54 +0800 From: Yuanhan Liu To: Changpeng Liu Cc: dev@dpdk.org Message-ID: <20170707044854.GV11626@yliu-home> References: <1498728512-12728-1-git-send-email-changpeng.liu@intel.com> <1499487291-17053-1-git-send-email-changpeng.liu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499487291-17053-1-git-send-email-changpeng.liu@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: introduce a new vhost-user-scsi sample application X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2017 04:49:03 -0000 On Sat, Jul 08, 2017 at 12:14:51PM +0800, Changpeng Liu wrote: > +.. note:: > + You must check whether your Qemu can support "vhost-user-scsi" or not, > + Qemu v2.9.50 or newer version is required. QEMU v2.9.50 looks like a stable version, and I don't think they will backport new features on it (or, do they?). So, it should be "v2.10" here? > + switch (pc) { > + case SPC_VPD_SUPPORTED_VPD_PAGES: > + hlen = 4; > + vpage->params[0] = SPC_VPD_SUPPORTED_VPD_PAGES; > + vpage->params[1] = SPC_VPD_UNIT_SERIAL_NUMBER; > + vpage->params[2] = SPC_VPD_DEVICE_IDENTIFICATION; > + len = 3; > + /* PAGE LENGTH */ > + to_be16(vpage->alloc_len, len); > + break; You didn't resolve my previous comment regarding the "break" indentation issue. Otherwise, this patch looks good to me. --yliu