From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stephen@networkplumber.org>
Received: from mail-pg0-f46.google.com (mail-pg0-f46.google.com [74.125.83.46])
 by dpdk.org (Postfix) with ESMTP id 48EE116E
 for <dev@dpdk.org>; Sat,  8 Jul 2017 19:05:45 +0200 (CEST)
Received: by mail-pg0-f46.google.com with SMTP id k14so30824623pgr.0
 for <dev@dpdk.org>; Sat, 08 Jul 2017 10:05:45 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=g+GvDu+rkSUh5V4erC4RSFlkqnf+6hi7tH8n1sWVZXw=;
 b=tWzc3n5o3oeqOy25h6CNFzLspGW3Oem0UqELrhmehvuIONzrPYUXGPLTdP9hgK/hXv
 uKRPahQMlxav+493IVKjGHB0lU6A+8ARoJMR3nz6Mu4CmjVvmijPA+XC7j6uLJl6PbUU
 Hvh2HCNWWwRTniKatZ5lBqOVatDWeJyxJ5xD+wA5HFY8R0ESVuN31D/of7ArIgOHFbp8
 OTREKIpnvMY1XoGy+9QwgbZU14evgx4u86XItozkK4AHO2eKX4cvhkOGzB8kBLFMh5kU
 zYC0+Vqc8ZXiQ0dRQZwcvatq8XJ2d8g8c36ltjt+N41tDuZ4AhYJsJRZYGT8QTTvlP5L
 GK2w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=g+GvDu+rkSUh5V4erC4RSFlkqnf+6hi7tH8n1sWVZXw=;
 b=Mao8XjP6WYXDeOW4Gcy6Km1Ttw9e0vSR8g/hyPjq2OOiOltBB6dXJvuhmgdhjWVKQY
 lSM28tSHCv2RgdVpbx2sGLx0rSSnkTuhQepzUXnj1ij3ifEIg/WR9iAtDbKRNn7uwpP/
 9p/wa+K16qOz/2Rgh06+FdkJg1/fAp0suR+3Ir6R9r0ORPDVqZbOydoAIyDEu8UWfMNL
 myYNqYWkaMmQtoc5TEXHuMNlVBlB+Rj6A19yCK/ImfiC1QlvBFkYGBnFn9pYP5XOS94Q
 9anb6FiPe7i/4S6bW8JpVJUIsrSj/nKqodB/zCf1Ug3QzkFE6PIs4MJgfxzZvV5uaot5
 yCSw==
X-Gm-Message-State: AIVw112iGRIFtPf9M4aZjWqsKGq/DFgGFV+f71h6WcF2BbUi5qSP6te+
 52Wnc+vg3Ffi+fjt
X-Received: by 10.98.36.19 with SMTP id r19mr36191192pfj.95.1499533544504;
 Sat, 08 Jul 2017 10:05:44 -0700 (PDT)
Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240])
 by smtp.gmail.com with ESMTPSA id o84sm17009453pfj.109.2017.07.08.10.05.43
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Sat, 08 Jul 2017 10:05:44 -0700 (PDT)
Date: Sat, 8 Jul 2017 10:05:37 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: <dev@dpdk.org>, Sergio Gonzalez Monroy
 <sergio.gonzalez.monroy@intel.com>, Remy Horton <remy.horton@intel.com>,
 Jianfeng Tan <jianfeng.tan@intel.com>, Declan Doherty
 <declan.doherty@intel.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Yuanhan
 Liu <yuanhan.liu@linux.intel.com>, Maxime Coquelin
 <maxime.coquelin@redhat.com>, Konstantin Ananyev
 <konstantin.ananyev@intel.com>, Bruce Richardson
 <bruce.richardson@intel.com>, Reshma Pattan <reshma.pattan@intel.com>,
 Cristian Dumitrescu <cristian.dumitrescu@intel.com>, Byron Marohn
 <byron.marohn@intel.com>, Pablo de Lara Guarch
 <pablo.de.lara.guarch@intel.com>, Pawel Wodkowski
 <pawelx.wodkowski@intel.com>, Tomasz Kantecki <tomasz.kantecki@intel.com>,
 John McNamara <john.mcnamara@intel.com>, Daniel Mrzyglod
 <danielx.t.mrzyglod@intel.com>, Roman Zhukov <Roman.Zhukov@oktetlabs.ru>
Message-ID: <20170708100537.7a52d067@xeon-e3>
In-Reply-To: <1495727874-10892-2-git-send-email-arybchenko@solarflare.com>
References: <1488459935-13273-2-git-send-email-arybchenko@solarflare.com>
 <1495727874-10892-1-git-send-email-arybchenko@solarflare.com>
 <1495727874-10892-2-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] examples: adjust Rx and Tx descriptors
 to device limits
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Jul 2017 17:05:45 -0000

On Thu, 25 May 2017 16:57:54 +0100
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> +	retval = rte_eth_dev_adjust_nb_rx_tx_desc(portid, &nb_rxd, &nb_txd);
> +	if (retval != 0)
> +		rte_exit(EXIT_FAILURE, "port %u: rte_eth_dev_adjust_nb_rx_tx_desc "
> +				"failed (res=%d)\n", portid, retval);
> +

rte_exit is equivalent to panic in kernel.
No API call should call rte_exit. Instead the error must be propogated
back to caller and/or leave the slave in a dead state.