From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id 1BFB058CE for ; Sun, 9 Jul 2017 13:23:21 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id r103so102559158wrb.0 for ; Sun, 09 Jul 2017 04:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=p7eC0TDMH26vc37yLgS31jTNIaNdGuhwHwRFXFcbpgQ=; b=pY2fnszEZoWWb+dGSMCblsxOhti6B6IIUNn1HRBkwizRaVvb/zgF8yeTJG1COr4otC ZSj1wbJFOM+z4oqRzYrbEmLhOyUkVP7EbDvCk+HgKhaA9SuHImLHj1VBdDM4u0ENKFUQ Yrk6y6/dAdHmb4AnwSB1fedF91nzR7WdtztVXaFfgctlCgtmZbEXKBsd6/JtRmw9E6e6 ZfGhCI/gpdtBeHLS0lQVdvPOBpN3BWDa2Q4lvXH3SecnD/GB10Qg7kWBSH4JeG0BJrLF ky04AaISwbVoKA1jZ9Nm4nML1FXhB828zphBsAKwi6jOPAmLfEqwVX8ewTHJdDp2ip7P r+gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=p7eC0TDMH26vc37yLgS31jTNIaNdGuhwHwRFXFcbpgQ=; b=F3K8Gn4CXrw9JathgfIWl0wL7+BkLQ/o9rmAx8ils+T6QbMEUKsH/1JAMZ4niuGybv fv3oNp6jSvNSGwU//loLLyNLc1RJZOuqe+pBLkXe8Gv2Ukyl4YPozJMTMmQrATHhjwHv s+R8vPT9P5bJSCWN3Un7pZE6zr7hJWbd6dqJdywIVv6b3bXwDqTDnuTun0kClndNSes4 zJh0rggFDmzuRzzBHa0DupEGBYaMm4X2aCQECIJtWkEVEVibGCmK1TkXj0fbk6CUr3a7 gqnb5e92IkCFmsr+mNHcDIVZUmZxklX/I+KbcRCRn1uub1JlqJj7yIjYDaQkInXvHoDR N6Qw== X-Gm-Message-State: AIVw112r6aZd5TeJtNcmHTZ27MTPB6Hpz7pEyBrAT56tlySD9RO5/5/a IkMTx5r7e2jYp0ll X-Received: by 10.28.29.9 with SMTP id d9mr4592864wmd.39.1499599401552; Sun, 09 Jul 2017 04:23:21 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id j190sm6494543wmd.22.2017.07.09.04.23.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Jul 2017 04:23:20 -0700 (PDT) Date: Sun, 9 Jul 2017 13:23:12 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jan Blunck Cc: Thomas Monjalon , dev Message-ID: <20170709112312.GS11154@bidouze.vm.6wind.com> References: <20170709092847.13339-1-jblunck@infradead.org> <20170709092847.13339-2-jblunck@infradead.org> <12210751.V8za9RMinW@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 1/2] eal: internalize devargs parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Jul 2017 11:23:22 -0000 On Sun, Jul 09, 2017 at 06:56:25AM -0400, Jan Blunck wrote: > On Sun, Jul 9, 2017 at 6:46 AM, Jan Blunck wrote: > > On Sun, Jul 9, 2017 at 6:28 AM, Thomas Monjalon wrote: > >> 09/07/2017 11:28, Jan Blunck: > >>> This is going to get cleaned up in future releases so lets not expose > >>> this API unnecessarily. > >>> > >>> Signed-off-by: Jan Blunck > >>> --- > >>> --- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map > >>> +++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map > >>> @@ -211,7 +211,6 @@ DPDK_17.08 { > >>> EXPERIMENTAL { > >>> global: > >>> > >>> - rte_eal_devargs_parse; > >>> rte_eal_hotplug_add; > >>> rte_eal_hotplug_remove; > >> > >> We need to expose it temporarily as experimental in order to let > >> the failsafe driver calling it. > >> When reworked in 17.11, this function or an equivalent should allow > >> failsafe (and maybe bonding) to parse slave declaration. > > > > There is no need for the failsafe PMD to parse it to a rte_devargs > > because it can just pass the string to the hotplug API. > > Just in case it isn't clear enough: the failsafe PMD is using the > rte_devargs structure to get the bus name. The bus name is explicitly > given in the hotplug API. There is really no need to deal with > rte_devargs here. The fail-safe PMD uses the rte_devargs parsing helper to find the bus name from a device argument handled to it. As you point out, the bus name is explicitly given in the hotplug API. In order to be able to explicitly give the bus name, the caller has to know it. This is done by parsing devargs and using the result. -- Gaëtan Rivet 6WIND