From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com
 [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id B7EF27CBE
 for <dev@dpdk.org>; Mon, 10 Jul 2017 10:00:21 +0200 (CEST)
Received: by mail-wr0-f178.google.com with SMTP id k67so126863373wrc.2
 for <dev@dpdk.org>; Mon, 10 Jul 2017 01:00:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=jfnjd6YPfVTfqopYhYv5dnIr0a9x+GH8BeZ0Y5pfjbY=;
 b=b0UFKeP7cYt1CSPk9MQIkCK2Bo7O5DOSKg6Gx8XMiQckvdAEGaeGOdCUcyd+fUat3j
 +9qlXXSBmSd2KG3V91LMICrd6dKsuH21qapCdqalECQPSysWEdwM4b06h69grWvB6+tc
 JcUPxSa4xtoz+ku3QUX7ftrHJelw48FXgwLFTQVI3MKHMWlXNSppDdHuaC2mchmt8R15
 YJ1/Bw4VrLMsd93SWjfwiCvgA+U7dOvKciC/2GZc6k1Q9NGrJ3wHd75RjsmzsEgVxK8v
 pkOzR8DgaL8nU/DurGU5w3AVRxCZrnAH1reOXp5ec0VzvodrOoHo4lQbgRij8qIhXJHp
 RmFw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=jfnjd6YPfVTfqopYhYv5dnIr0a9x+GH8BeZ0Y5pfjbY=;
 b=o4Sg7dnMSjDCxLNYhJ41gb9FeFrIK0c/XZhBOKgRO1qO146R6QaxwHTFZPhQ7Pvctj
 JkwCR09AbvmmkH8NBPcSyXzYFqQdGt7gIWSgwn88ni33iVgTIIUT7Wg9E/hXwAvuStFg
 rij5whV38Uhk65q++egdgXpR7BNY4pbsBaIe8Bjard10/EREju7auijBFEhlXqMnNEYx
 5x5Bc/E4CS0BVLmRj4NqxWhWYmHBroQ9iR+xQzseOkADpTgGmD5Vi4qBRHFaG/FI1Vok
 HKY84Vr3/3LhcOq8T5kosQX6eFiwaUoAMYCcwrjEogJLhzqqpozx1vEcKMKEQDc0gH3U
 qa3w==
X-Gm-Message-State: AIVw112ll3Co4iJYcA8XZ2BzQwe9Fe1PyVyWfU4Tk69eimwYhr5Rnbzl
 7tZMxAInzEourbDr
X-Received: by 10.223.138.252 with SMTP id z57mr6139902wrz.66.1499673621376;
 Mon, 10 Jul 2017 01:00:21 -0700 (PDT)
Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr.
 [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc])
 by smtp.gmail.com with ESMTPSA id b205sm5028682wmb.14.2017.07.10.01.00.21
 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
 Mon, 10 Jul 2017 01:00:21 -0700 (PDT)
Date: Mon, 10 Jul 2017 10:00:18 +0200
From: Olivier Matz <olivier.matz@6wind.com>
To: "Wang, Zhihong" <zhihong.wang@intel.com>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "Chilikin, Andrey"
 <andrey.chilikin@intel.com>, "jblunck@infradead.org"
 <jblunck@infradead.org>, "nelio.laranjeiro@6wind.com"
 <nelio.laranjeiro@6wind.com>, "arybchenko@solarflare.com"
 <arybchenko@solarflare.com>, "thomas.monjalon@6wind.com"
 <thomas.monjalon@6wind.com>, "jerin.jacob@caviumnetworks.com"
 <jerin.jacob@caviumnetworks.com>
Message-ID: <20170710100018.403b82ec@platinum>
In-Reply-To: <8F6C2BD409508844A0EFC19955BE0941512B02B2@SHSMSX103.ccr.corp.intel.com>
References: <1488966121-22853-1-git-send-email-olivier.matz@6wind.com>
 <20170404162807.20157-1-olivier.matz@6wind.com>
 <20170404162807.20157-7-olivier.matz@6wind.com>
 <20170406054523.GP18844@yliu-dev.sh.intel.com>
 <20170418150304.58d2c4a1@glumotte.dev.6wind.com>
 <8F6C2BD409508844A0EFC19955BE0941512B02B2@SHSMSX103.ccr.corp.intel.com>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb
 segments
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Jul 2017 08:00:22 -0000

Hi,

On Tue, 4 Jul 2017 07:54:23 +0000, "Wang, Zhihong" <zhihong.wang@intel.com> wrote:
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Olivier MATZ
> > Sent: Tuesday, April 18, 2017 9:03 PM
> > To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> > Cc: dev@dpdk.org; Ananyev, Konstantin <konstantin.ananyev@intel.com>;
> > Richardson, Bruce <bruce.richardson@intel.com>;
> > mb@smartsharesystems.com; Chilikin, Andrey <andrey.chilikin@intel.com>;
> > jblunck@infradead.org; nelio.laranjeiro@6wind.com;
> > arybchenko@solarflare.com; thomas.monjalon@6wind.com;
> > jerin.jacob@caviumnetworks.com
> > Subject: Re: [dpdk-dev] [PATCH v2 6/8] mbuf: use 2 bytes for port and nb
> > segments
> > 
> > Hi Yuanhan,
> > 
> > On Thu, 6 Apr 2017 13:45:23 +0800, Yuanhan Liu
> > <yuanhan.liu@linux.intel.com> wrote:  
> > > Hi Olivier,
> > >
> > > On Tue, Apr 04, 2017 at 06:28:05PM +0200, Olivier Matz wrote:  
> > > > Change the size of m->port and m->nb_segs to 16 bits.  
> > >
> > > But all the ethdev APIs are still using 8 bits. 16 bits won't really
> > > take effect without updating those APIs. Any plans?
> > >
> > > 	--yliu  
> > 
> > Yes, there is some work in ethdev, drivers and in example apps to
> > make the change effective. I think we could define a specific type for
> > a port number, maybe rte_eth_port_num_t. Using this type could be a
> > first step (for 17.08) before switching to 16 bits (17.11?).
> > 
> > I'll do the change and send a rfc.  
> 
> Ping ;) Is this still in your plan?
> 

Sorry, I don't think I will have time to work on this issue in the
coming weeks. If you plan to do it, I will be happy to help with reviews
and comments.

As I said in a previous message, I think a good first step would be
to introduce a typedef for the port number: rte_eth_port_num_t.
It can still be uint8_t for now, and can be switched to 16 bits in
one step when everyone uses this new type.

Olivier