From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0071.outbound.protection.outlook.com [104.47.32.71]) by dpdk.org (Postfix) with ESMTP id 36E5A5699 for ; Mon, 10 Jul 2017 14:31:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=lcIEomXL35Tpnv5Xjdb60DauC8dsWpyGA4tOZZFA5qE=; b=N0L1KntZOSTY4oEK4oDJ+Jo/q4jx6eXzQ+Ref3VQXXe+VQgMp3NomrVJfutgwlFmvoFDZ+GDTJlIoi2uifx/74gM0238PHr4fhDrtduZddfXzNYlBLKDGfL90DCJU1NXUFXsJMbbRbi2xbG81fLcFie55BzFRSA6U4GnHC6qkKw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from jerin (106.201.60.201) by BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1240.13; Mon, 10 Jul 2017 12:31:01 +0000 Date: Mon, 10 Jul 2017 18:00:49 +0530 From: Jerin Jacob To: ilia.kurakin@intel.com Cc: dev@dpdk.org, konstantin.ananyev@intel.com, keith.wiles@intel.com, dmitry.galanov@intel.com Message-ID: <20170710123048.GA20179@jerin> References: <1498569361-5011-1-git-send-email-ilia.kurakin@intel.com> <1499359372-6658-1-git-send-email-ilia.kurakin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499359372-6658-1-git-send-email-ilia.kurakin@intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [106.201.60.201] X-ClientProxiedBy: PN1PR01CA0089.INDPRD01.PROD.OUTLOOK.COM (10.174.144.157) To BY1PR0701MB1724.namprd07.prod.outlook.com (10.162.111.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf4366de-e4a9-4f15-13f4-08d4c78f87c3 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(300000503095)(300135400095)(201703131423075)(201703031133081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 3:3+cRaqxqxSIu3AJQ93TgRTgFUkmdpsDvuKW4fuWQphB8GNnO3GqMnb8Vt24X+DbqVjSN7QxxYcU5c7Jb9x582hsez4HHK+bGizo3CEjnYzDvSdNMeASw5pajhLohvbKYb7YD8XUCbC09OzMm+XGp44pzJTmekzrb4JiLjAno1nzQmBhVL7K7aD4sbn5lrmXy02QsBF0SCkxeZsssuWYlVMr5kjD/dMxqKOIv059OIVmUsDi6tbv27EpIhFEkIXVHhGprjJSR0vQmUOLacZ3uOmZHwEYhfatb/7jFsb3u2sP32S/x+fOcJAIrcNBjTNTxqWFzpZaRWJpi9+PdfTQVNGKpdUSJ6tIz/MLRevKVi5XU38TMwc2FW9M9XYS+vEVo7KOQhjhfGK0XCUnd22Tm1CGBRLazM1eeSuiXnfF8MfEHdCZueearhMmPpxIQzyo0qPn7tuHvDBQa8AX7of0W/7GxaBzxcgodzam189BPzSvUtn/jnpohsUnYJDh/EAu9Ug3gHFqO+EhLXO8NxVFFJwaZlvoo54X3LZe5Pr/yxsQ4G8L48YHKKzPyh/7Q4eccGOxqfZyS0gnavM9YRxI6+7R7cD3nITvN+RGKnQ68zVVYHmFDW4OsNUr+YQTTx7TDw6I6azlQnrmi8+cyaUw4AD5y9aMaz4oLl2LluOehnO5e9DwFHFCw2SADzGa63+HDyE/u24oRnGtXGgm8ek9kIZdZCevOanP8iPBfTjuTDAs= X-MS-TrafficTypeDiagnostic: BY1PR0701MB1724: X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 25:Up997Q6wqiMUBfcgF3mhIxoTs0rVKDz3rpJmqr4uafwgSihitY9j7U1DroYY9MmkoNBLWqPvmgj95CVW3WCB8ukRhMUz9Kz1EizARupeMnO8UPwy+qFk1RGD5RMBjbCBbMEfOIfcDfcLWlJQTlB0OTUarZ/pT2SyH179olV4FmclLzR/+JNxQjIVFAYoqheW/DfWSs5m6xKnxJkM1OI+L4hQh2kANBupjamNHx+ldbv4iklSi9c8DhZJDcIw6L06q6Ii5P55aUjJPAfuwQUfJHQKtdfsqBWRwIK64HjWrLN8sqLQuzxCcF3c6iy3xYNDIk55F/+ksP5FcRlQs2U1o+0S8/pPkawFNvYh0/81duKABULsTtIFGE9UoIfrXYV0Y0MO1tUF96R5rap3SAKtgf7IHzS8NknOT+8JZTnuxVa/p3zn+8ZaVshDNBkpHkPVwwdNCQqo+gI9tqQIy4ugk7y6arxnAH44nLiGcDte3VUzQkVKq++Gm8Wory3O/fW2gqcUjlmwukcPeVEpgeNi03d++hinVR8zniH3c+wThvQWJ+YEqgxd2yN4pZ/fsPz1usdjEFdQHyhYETyhzFzU8bLUy4BZsHFjoxda8Mtp6GAjvzWupiBaudrLTCbP5xodrhOQfztHbHbzgBR+iVMGjHYgSR37Dfsd/6Xl8yccj5jTyMvbQ3rzymPMJf/kw/DLRZ34KwFg7A9lOMCN8350y78P4T+7snwlPqB/+DPosweiBj0MCEFx+XNosEj5HVNmHwJqC8zIJFKbidFsh87pcixHnMC+oOokT+Ia94qmf5A2ZyBrlPCwSGhQofqifNAry+KB7IZ1BYwDBWw6in6M8ufcQEjmyc4BN/pXQ0z1hIekyoKbQBGeavAk0NwMfqWX+oS0Y+D9yziwlm4+HJdL/A8h8+ZoCLv1rd4Hsdi65xA= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 31:nFzJjG4vxDhX3AXvwC9ZvMDlXtCmFqm/oTPAp2QADfzh9TlMez4Pmbg6cUj7KjoTHPQ6msRYLMUBwv9+VkVls9ly0G+W8EqRE4Jy1Blu0mlN9vQj1FLfiNDCuXGuymlj3NmGMFsnzhtyfY76EnVOcM0D8p4WHwOWt91XO4yCnuUU6wH1lgIwBIMcTMkpi+qO8+8ImG0FU16yxXistz7y5KthdMdIY+J8mC8WPwkkiEYkdURIQUoGQmPankpYBIZHb4GoQowREOMDJ7mcWwG3/VqTiFBVWZ1tZ5DiMgwRfBm2PoZgDlMeQD9ClrEwAvPc4Bp+03xNCPgXw7jzhYTyMuFdgNtJY5uAlJT/cH+lbSNkSAm1puJ7fMitT47p0N1K2wLwiQKJqI4uNJv2vB17tHfr927dYakA3eFDPmWL2RQ0DkG56rfCGCnxbAOpQXHdBAZcndNxSSoNo6mv8QXVX0IHoC5dYx2L4GKAXtCLWnlBqYjJ3ONmcWxuDx4UsRVmgt2iylzlVtgNvBtpTzAZGVXM6HrNCaz1RwH/K5WHN56UKPMlxOobgtO827Svr+k5qp/MKycqMVOh67DC5mx54tJLyB8vE0UlbGwKarTJpOROhskax5JfQ4yTk9sKFuZLTPjq5iTyjYz1PUcFLxE2U0g1hEEHog/DEZlVbC2osuibIqpbjZeTa/cjKrIlWvvZK/ByKHWATY0XWtv1iQTFhaqBOboZLSqzUZX8QiiWN1M= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 20:BE4+NoaQJrGisKISFd8hEY5zdMbwb+ct4N5p06VSfq3S7HNWfPFUT/D09k4rXD3Xm3n1CYHhVzL+K6pB8W3NHSk6PjNDDVCvKLF2aCpeD22yJYfrgTrrerirgTdGoG1fWWF2eTzaM6rH2HOYb8d+ceVFVCfdGXOnqtiwr+exrSFZIGNINsC3uL2MMUleEZfs8WUVSRbxqlin+iQdcYBtOR6GxHVGFaH0PGKt3/1GZsQjvSght+hHiAI3SAwj3DKMgHnKU/vaPyzW1qV4e7khXaPBaoBIOeNP92QzkEvGtBc0ICiz8Cd80MhBVM9bBSjSKcaXt7M3zuddBarA+UEBd0AYrVsQllm1sNANw8075Ebr+aooE3O2Hv1yMK635JWl13DAKhbOO27b8ERxT+eLIl28fKI028z4pC5TYCpHSZcJ/NpjfncENSdbPaPVy4ma8f02oLt44MaA7bYCEg0eafnTkFtZgI+fbQ40ruF3aY4rctqyx1aopkeMU6zEGDDxgvhQoAuQLyIPjZ+yJKg9OughVg+tRjNEMPQrLR+appt6OP5k+hTjccPZimm3o6VazAREFWBvDRiz5JCibkde8MLqkZmDnAhc1k3va84xQqQ= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(133145235818549)(108984395545644)(236129657087228)(48057245064654)(167848164394848)(228905959029699)(247924648384137); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(2017060910075)(10201501046)(93006095)(3002001)(100000703101)(100105400095)(6041248)(20161123560025)(20161123558100)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY1PR0701MB1724; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY1PR0701MB1724; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1724; 4:ziqiXH7/aYRqdbGVGYsIG+2vPL3pl4pV/0fa5/mX?= =?us-ascii?Q?cdPjajvUwYzIrp988cszX8OI0ja5NKX+FMzScamWT0l9DVdObd2ZeDeDpwvn?= =?us-ascii?Q?VdBjpkudd83wkhxwLbOHm8THV/gj47wOmba6w1fzFZDcsbRvly1AJSWmgbz3?= =?us-ascii?Q?I1ysy4Vdh63g18hMIGjdys6AcyCKBEIF/dBrkh2OqaweP8t410iKx+Umu+z/?= =?us-ascii?Q?BCnvlYcsrfXNy0cv+qUJ2rT30Zs1QyCOyvFk8FaLOODO7omJzMS5mIwdfHMW?= =?us-ascii?Q?Q+6snf1s8YDd+absQLP3WE8LF3VNmLGDQtypHf9R7x6EovBLtGzw9VGHXK+z?= =?us-ascii?Q?sm5Uz+0z0O/SLsmIUrPfUNFcPSJfcinP+9eQlHFsYo3DgRdNxKcLwAeg9ecW?= =?us-ascii?Q?CTw9pMMfbCioDvjkKry0ZsgUO51LMqFM0fvKM2IV1ql7LFKmFtPIzUWuJaJV?= =?us-ascii?Q?xh/uj0o2+agOkLsTZ4zCQtThTEdXKWItXnqQCNr1UBhis62/9Em1iwEpPSJT?= =?us-ascii?Q?o9yYJ6U1wrZ27QznLwKOysSCaei71NxAzXUitkZA8t3x+FGxhH8cV45kUypc?= =?us-ascii?Q?h8k7r7N6m0PlupW3s12hz4n1uY0r8vIEvgPZyzpwThmMZhYcRmXuXlxr6sHN?= =?us-ascii?Q?IySaOLk5dCyUaWEPZG8SkrfVEeCLnKaVRunpkAofIqgEzlB2dx+SbFCcD/pf?= =?us-ascii?Q?wjxbVh3qJ6FFY8HS7u5Sn5/CQE9YBsetSoZsV/FAfb1YRGzLAEw+uoOF1XpX?= =?us-ascii?Q?1ilzOSRSnTAknKmHjXVyPV9ML+YzDiGto9pSJwhNyPBuOUrPfJGS2NemiPpd?= =?us-ascii?Q?l68VKF8sSzCWPWZoUOuZaY+PwTb2lXjdaFPYmltx2/L1Ptsl4vSM+MmUizV9?= =?us-ascii?Q?kt3JK6U/qInkmd+M1ZheTyyjOlNhXaoJGpMCl/A4Ds4S88rMjmK5+ATJ6S0R?= =?us-ascii?Q?qncRp8asJsAmeJzVGNrrVI72Y2kaY9k5KYJg4Z0FUJeR4vUiteL1dAsa45Ui?= =?us-ascii?Q?zN8BCFICHzLZqU+wvbAhZHDwXlgWcxH7A0wrI3hzFnBVBtoEljuBllbLbjnr?= =?us-ascii?Q?vYWh3CrSWaVjZltenjQQBGIC3zsllcwwM7g/on7Z0Yu4CsG5RE/cx+XXLK7q?= =?us-ascii?Q?6w34lApoWpuVAmZT403/eLbpm+ddjyB7vuRWzRZUoV794cR7lmx5UbXUa9wY?= =?us-ascii?Q?6lgF9ihx2AK8stoKq/wiCoTbtXfY+YeatO4QuCiNvhtumSeL8ak/Jmx0GQwF?= =?us-ascii?Q?Z4GKg+xBF2LNTiHlxe8SaDIPWVZP+JOr2bH7U04RlE9P+zofygac5hVtgXjh?= =?us-ascii?Q?5H4jXPzmoHpi2ZVJFGG6m0fJ9+3TM6IHJec7pAlrZPtIC7VL01hQgtpvX4/z?= =?us-ascii?Q?J7pCWjLytENU2AhlsTfwDkPiOEPZq40YazgdgOON0/FvYkDCZlUS8ULZADxE?= =?us-ascii?Q?NWJwCxSJ/w=3D=3D?= X-Forefront-PRVS: 03648EFF89 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(7370300001)(4630300001)(6009001)(39410400002)(39850400002)(39400400002)(39450400003)(39840400002)(13464003)(5660300001)(50466002)(76176999)(50986999)(3846002)(6116002)(1076002)(25786009)(305945005)(54356999)(229853002)(8676002)(83506001)(7736002)(81166006)(4326008)(189998001)(9686003)(2906002)(6496005)(55016002)(6666003)(2950100002)(42882006)(6916009)(53936002)(38730400002)(6246003)(110136004)(42186005)(66066001)(4001350100001)(7350300001)(478600001)(47776003)(33656002)(6306002)(72206003)(2361001)(2351001)(966005)(33716001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY1PR0701MB1724; H:jerin; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1724; 23:RVTlndhTHLohmCbnz5N74FHWxWaWjeoLuenrIcx?= =?us-ascii?Q?LhsZlvWfDeD9skEpyC3ZnHcpny7nB+Lqp6xAEPUTZhukg/uYZJyy0vPATFdM?= =?us-ascii?Q?qRjFWhCs/Ah5K6jfAe7hUnKLW7VG9WeK8pySgFN6RJxMydrqMKUYnO7pc6Gr?= =?us-ascii?Q?YgK3CM7DOK6NM07fjflHDnQrqhwYOgPo+YCzSf+W8Aej11WU5uJ4aNhfH60I?= =?us-ascii?Q?MQrdpTzLh+jJdAsFuigIO+kzSMzcORSniVn+qWb9MJh4MuP1f5FTyUXip+AW?= =?us-ascii?Q?0pgoOArCm8EyjA4MN+UPIAsWkqLewrGuUIcDSG717NUnNOYjQNi147HFuSW/?= =?us-ascii?Q?v4s3CiiMlFwLry+xoJtQScr0I0O6+XE00QN7Z7szmttwjXg0oFyJpoiVMXu4?= =?us-ascii?Q?WNN0EhzJEAcsgxRwnYrzSkcm6CsDA2Sr0reG2586XJOYxcPujKmcrius5xjq?= =?us-ascii?Q?RoXF7nr8kvzRJHLZ7Ss0KH+pwyr56BqR4rGRud3Iq7NSrN75rhTsjgWs42AQ?= =?us-ascii?Q?6Y3BlOpmwIDdqOVSZNqI9nNAn9qdonoedYjT+WAY4lxxk8BYwzuZPSa+xjNZ?= =?us-ascii?Q?pptdi/8z39LvGL+yjWhtV+h0HO7ZoGqzvmxiioppBuV4YsER3kSxljQRnzSJ?= =?us-ascii?Q?1QVW9m0WH6/fyPP7zWK3I3GrSvbOuUx2tQVrUEJf8aMp8/8QtqpjCh0GsmmU?= =?us-ascii?Q?JYwwR12JsTbBkv2rUeQ7ukUrI79fw03yHBp8YVpA/o5gjMipO/zt+juKTjVZ?= =?us-ascii?Q?UA3Gkx3bOVv6BZLcoR7wLicdXJD/MjALvLXUXNLceL4drQqYM/IVGIoeiMSr?= =?us-ascii?Q?9FWMXF78RQQ8EANGz6yx+bFwupO+NKqjz3BrXG/DO4arFhTajV93oV6s/7Lh?= =?us-ascii?Q?+2D9opiBJnBAR5EunHzi38oUU0Z7utgKteWb888A8Ob0V8QU3Hm/2FohT1r0?= =?us-ascii?Q?eeWXOivGJfQ4Pj0kY0kOyILUR+WUzwszCn9ShQ4pX4dpFIwp6XwmG020Gx+L?= =?us-ascii?Q?vZEuDp9ylKjTmBhSWqTMFAG03rIwNEGD5B585TtL+xX+lIpa6NG1yZuMbuPz?= =?us-ascii?Q?2ycQTgZiuTRGgX6a4mNQquqv4FwMfN/NWzLEWrZW370yRGDsGFdIh5ohgkF8?= =?us-ascii?Q?oeBqswa9+bg2JGoPx0GFVWqix329B1etVDmIEp8gI8Xl4H0rrhZOvQNcKS68?= =?us-ascii?Q?UEItLRvOwAv/px2dAYcYGD822JFmYiX9NUfy2IuTuxiHrbyyMhHSjhLTLyyE?= =?us-ascii?Q?HEx0SD7CBpOq+hAT8tzf44zoztsITGiJc/SIPPWCz2VCivUbKEf40vZtaFMw?= =?us-ascii?Q?uUA=3D=3D?= X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY1PR0701MB1724; 6:m+NDBtWY0estUmuS1h1NqV/mAhf6G8PfHocaMAgW?= =?us-ascii?Q?IxQWJRvxgJ/BUg4z1/vZ7Lc9jXFuFbdOV5cyyhHegERPSXl3u6dJiYfUMj9M?= =?us-ascii?Q?qwhfaDs8YJZxiQQjWjsB+0xVpxRW6wAWjDaD/9CI327HmDAUd8O/oDA0OFxu?= =?us-ascii?Q?6mxl1o0q4y6qJmTlqzmA+szIj4ljduJOdvNFk3/t7In395EalwGEtlwuEZ65?= =?us-ascii?Q?VkAMou+eSi2HX1GnL8PivlY/Hg9ugVO9UBfucUz0uIkcshWicCqOLd4/oRhB?= =?us-ascii?Q?atUfdHj7gqISbiOua8lArMa/WGIrW+PgYhA6hTXu2oSoyllN6CDbTtzgD1C1?= =?us-ascii?Q?9/CM5uRuGmN/+8Z9bFEMzI74Y5sJtduCcK/EYJhkIIcjwtLuWxaIBXPRdUmJ?= =?us-ascii?Q?2F1UdmwZVzZtp9AdLEvzHIkerkbfpFIzfsA7XobGRPd+c+Nt4BK30DW17ej0?= =?us-ascii?Q?ruTtZCzzI2lzOGrW45CAcApoZNzbH/1MDwKj7KlMBHrhPgsWneaDuZvbKM49?= =?us-ascii?Q?sYwEm++ukwN2/yBleBp1XPMK4rKQgtGkEY1SRRm4RZku/ysHZ/Zi87dEyPIe?= =?us-ascii?Q?Bu6pHUskj/0+hnRPxSfiioejzDryavdlbgKp1cPBDQ2/ExqhQ8j4RT2BZc/D?= =?us-ascii?Q?1KFfpGuB/fc0YKlEfc47R71aQXY5uIuq6xNwHj7S+84WdLbAU9dsko14F8WT?= =?us-ascii?Q?vLyWi9F5wikAs8nxze7hz0Rxz50YE+HHuJguQPgUPskrFvzctqe6DN/e4yT4?= =?us-ascii?Q?Mnw2XnfAIXHGACGgM6m6Zk5RoDt/ZUhi+FMMPrOx1/dckAwvAPLOb+A99HT/?= =?us-ascii?Q?I5fyB1safle1g88Br4pmtmmA6MuPs4e6XRlufgBDi/26mINixKZYUl91Clcp?= =?us-ascii?Q?6CJu5JVIeBBVeup6qApS2L9ExPmKqDvFksQBZfGR5pPjwRq/24ub8KV3WKNZ?= =?us-ascii?Q?3RGfhwpPvm7JNuwTHMphzAa24oL2DyKCY+UcIpYzElwbrsc/Q5eTnr30xbSH?= =?us-ascii?Q?ooo=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 5:WTXFQD22pp7Bs0v8x87ckHzG9VtFrXFq3yvZBDIBdzVgEH8BGNLz3O4h+N1fXJ83f0fzCW3X7p4H7mqGCh6k01Rb1LNmzTLmRNm3WEHi3fTbFDbITwTckWenBRkfBm7i/M+AaLx3m2ZOQGsdIIG+LEiaGkTLNkUg6qmdxmPVt5oq8ItqxH/NOROferkMy9IthMr3vYwo64DlrOgy1icJmhoTBTIvqysm3OkNC2Tfrwv/6APFoKt3DRgvhSA8xBsVtibgxkJhElRnmjJt0AlI2WiQU9ydcOpNBYPI9Jf8ZYwYVcxOfKwNKxSq2doLrqYAe9KBxXvM06kOtgOBXjwRmz/oaaQzE/OunfaXt+q8iIdPiU0oooq5rBtwNVF2M3ZpGTrW89CUduKuTbugPUXzt57QG1DUpJWZ8MZc3lSKx4+ahtRtD5DKH/1y/Ixd4V6wLa+6BC+MBecXpygC858JPXdHGP6kw+cZLKfDWmpBeRpoKbKY+2Rm3Be9dtvHonpD; 24:gd/V+UOn6EEOKtCghNueHfne3RdTkIn3CrGYKYkdyVO2lSHKW8l9Jd6vEB0J5fJt1CaGidPIewAP8tVETedziFWhCu2pOWgDynlmHte5rjg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BY1PR0701MB1724; 7:9sqvS9NdeTLUnsBjeHXTV55d8n9P5AVEN2IP26ApPZkqK2x0Jw06SsN3cRnwBLCDTGQPwIE7QLRNBLGfslcqzDVqWsTv8rwC+0JXhzPKeyr3OnyxX02Hxdx65tr0naSeUOC0AaOVyLrD8H+jVIxj4LcfjJaDwq0DxkECymZlW43aUPmex4O2bTYPVwsp4+h16b4/y3bMTSSr6rlSGthFCMUUphoxZklJYkFRX3NC7PXwdnmzm6JkjtpSZfuGhU+tTH/8WH6lAOCeQl60tZUeMIDTgX6beNZ58iaxQQrhQXo1atklRq3C6IY1HDKOEWekOdhg0tO9hWjQYzlWUagbkW84ia7byY247JrPNLRgdPuzJL/GA85yFoBgKdgJs/NYZ14fy/9lUbp8+3BOeUb+xLYnNK5M7HVcmzc5xHRsMm5d1LOr9z9v97a/yjivyFbO83BE96DqHjcZqj0DWe2NI16hr+tPQGe/0D3pLV86uryPrKS4CsKl8DAvkfwX976IutdXtxkGHHR2BmO2gMmXEjJaiG2GuDkTDHXPagsA5u0ExxDGPVNADLAOmFUzW+fZFN9hp4CS/EYTB51EaJOYWgKo4dFEo1qknaaCXZxdzMw53DV7o1abxA1NUaUO8lFl9HFeUtxboic7OuwHaQtNSAaVZWMsqcSiZDnvSRxzBe6lFnhoJ+ZCuATJ975GmcQS3aVWiHJRSvdiJZ1x2DJQIMNI/lwm0TKOmfimP/TaUrod0rYJlhH0ZOEbqvcr7aJIIT1mc9fqUUipECLs2NkVrKiC5RmA/D6W5hsgwqmzbHQ= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2017 12:31:01.5385 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1724 Subject: Re: [dpdk-dev] [PATCH v2] ether: add support for vtune task tracing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 12:31:06 -0000 -----Original Message----- > Date: Thu, 6 Jul 2017 19:42:52 +0300 > From: ilia.kurakin@intel.com > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, konstantin.ananyev@intel.com, > keith.wiles@intel.com, dmitry.galanov@intel.com, Ilia Kurakin > > Subject: [PATCH v2] ether: add support for vtune task tracing > X-Mailer: git-send-email 2.7.4 > > From: Ilia Kurakin > > The patch adds tracing of loop iterations that yielded no packets in a DPDK > application. It is using ITT task API: > https://software.intel.com/en-us/node/544206 > > We suppose the flow of using this tracing would assume the user has ITT lib > and header on machine and re-build DPDK with additional make parameters: > > make EXTRA_CFLAGS=-I > EXTRA_LDLIBS="-L -littnotify" > > Signed-off-by: Ilia Kurakin > > --- > > -V2 change: > ITT tasks collection is moved to rx callback > > > config/common_base | 1 + > lib/librte_ether/Makefile | 2 + > lib/librte_ether/rte_ethdev.c | 9 +++ > lib/librte_ether/rte_ethdev_profile.h | 137 ++++++++++++++++++++++++++++++++++ Please create rte_ethdev_profile.c for the actual source code. > 4 files changed, 149 insertions(+) > create mode 100644 lib/librte_ether/rte_ethdev_profile.h > > diff --git a/config/common_base b/config/common_base > index 660588a..8795a95 100644 > --- a/config/common_base > +++ b/config/common_base > @@ -136,6 +136,7 @@ CONFIG_RTE_MAX_QUEUES_PER_PORT=1024 > CONFIG_RTE_LIBRTE_IEEE1588=n > CONFIG_RTE_ETHDEV_QUEUE_STAT_CNTRS=16 > CONFIG_RTE_ETHDEV_RXTX_CALLBACKS=y > +CONFIG_RTE_ETHDEV_TRACE_ITT_WASTED_RX_ITERATIONS=n Should we change to CONFIG_RTE_ETHDEV_PROFILE_ITT_WASTED_RX_ITERATIONS as its going to under rte_ethdev_profile.c > > # > # Turn off Tx preparation stage > diff --git a/lib/librte_ether/Makefile b/lib/librte_ether/Makefile > index 93fdde1..4d4017f 100644 > --- a/lib/librte_ether/Makefile > +++ b/lib/librte_ether/Makefile > @@ -56,5 +56,7 @@ SYMLINK-y-include += rte_eth_ctrl.h > SYMLINK-y-include += rte_dev_info.h > SYMLINK-y-include += rte_flow.h > SYMLINK-y-include += rte_flow_driver.h > +SYMLINK-${CONFIG_RTE_ETHDEV_TRACE_ITT_WASTED_RX_ITERATIONS}-include \ > + += rte_ethdev_profile.h With your current scheme, you don't need to expose this header to application as application is not directly including it. One option is, Wherever there is reference to this header file in ethdev library, you can update the CFLAGS in lib/librte_ether/Makefile > > include $(RTE_SDK)/mk/rte.lib.mk > diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c > index 957ae2a..a99eeea 100644 > --- a/lib/librte_ether/rte_ethdev.c > +++ b/lib/librte_ether/rte_ethdev.c > @@ -68,6 +68,10 @@ > #include "rte_ether.h" > #include "rte_ethdev.h" > > +#ifdef RTE_ETHDEV_TRACE_ITT_WASTED_RX_ITERATIONS You can avoid conditional compilation here by including rte_ethdev_profile.h always and ifdef in the rte_ethdev_profile.c source code. With that scheme, rte_ethdev.c will be clean. > +#include "rte_ethdev_profile.h" > +#endif > + > static const char *MZ_RTE_ETH_DEV_DATA = "rte_eth_dev_data"; > struct rte_eth_dev rte_eth_devices[RTE_MAX_ETHPORTS]; > static struct rte_eth_dev_data *rte_eth_dev_data; > @@ -825,6 +829,11 @@ rte_eth_dev_configure(uint8_t port_id, uint16_t nb_rx_q, uint16_t nb_tx_q, > return diag; > } > > +#ifdef RTE_ETHDEV_TRACE_ITT_WASTED_RX_ITERATIONS Same as above. Call a generic function from here say(rte_eth_rx_profile_init()) and add ifdef in rte_ethdev_profile.c > + /* See rte_ethdev_profile.h to find comments on code below. */ > + rte_eth_init_itt(port_id, dev->data->name, nb_rx_q); > +#endif > + > return 0; > } > Other than the above comments, it looks good to me.