DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 00/19] cleanup duplicate includes
Date: Tue, 11 Jul 2017 11:55:27 -0700	[thread overview]
Message-ID: <20170711185546.26138-1-stephen@networkplumber.org> (raw)

Using a simple script (in first patch), discovered that there was
lots of #include file sloppiness in DPDK.  This patch series
fixes everything but base drivers and examples.

Stephen Hemminger (19):
  devtools: add simple script to find duplicate includes
  eal: remove duplicate includes
  cmdline: remove duplicate include of errno.h
  distributor: remove duplicate include of rte_compat.h
  lpm: remove duplicate include of errno.h
  cuckoo_hash: remove duplicate include of rte_log.h
  timer: remove duplicate include of rte_per_lcore.h
  bnxt: remove duplicate include of unistd.h
  ixgbe: remove duplicate include of rte_atomic.h
  i40e: remove duplicate include of rte_atomic.h
  virtio: remove duplicated includes
  cxgbe: remove duplicated includes
  vmxnet3: remove duplicated include of rte_atomic.h
  dpaa2: remove duplicated includes
  fsmlc: remove duplicated includes
  app/proc-info: remove duplicate include
  app/test-pmd: remove duplicate includes
  test/test-pipeline: remove duplicate include of rte_per_lcore.h
  test/test: remove duplicate includes

 app/proc_info/main.c                             |  1 -
 app/test-pmd/cmdline.c                           |  1 -
 app/test-pmd/config.c                            |  1 -
 app/test-pmd/csumonly.c                          |  2 -
 app/test-pmd/flowgen.c                           |  1 -
 app/test-pmd/iofwd.c                             |  1 -
 app/test-pmd/macfwd.c                            |  1 -
 app/test-pmd/macswap.c                           |  1 -
 app/test-pmd/parameters.c                        |  1 -
 app/test-pmd/rxonly.c                            |  1 -
 app/test-pmd/txonly.c                            |  2 -
 devtools/dup_include.pl                          | 64 ++++++++++++++++++++++++
 drivers/bus/fslmc/fslmc_vfio.c                   |  2 -
 drivers/bus/fslmc/portal/dpaa2_hw_dpio.c         |  1 -
 drivers/event/dpaa2/dpaa2_eventdev.c             |  1 -
 drivers/mempool/dpaa2/dpaa2_hw_mempool.c         |  1 -
 drivers/net/bnxt/bnxt_hwrm.c                     |  2 -
 drivers/net/cxgbe/cxgbe_ethdev.c                 |  1 -
 drivers/net/cxgbe/cxgbe_main.c                   |  1 -
 drivers/net/cxgbe/sge.c                          |  1 -
 drivers/net/dpaa2/dpaa2_ethdev.c                 |  1 -
 drivers/net/dpaa2/dpaa2_rxtx.c                   |  1 -
 drivers/net/i40e/i40e_ethdev_vf.c                |  1 -
 drivers/net/ixgbe/ixgbe_ethdev.c                 |  1 -
 drivers/net/ixgbe/ixgbe_flow.c                   |  1 -
 drivers/net/virtio/virtio_user/virtio_user_dev.c |  1 -
 drivers/net/virtio/virtio_user_ethdev.c          |  1 -
 drivers/net/vmxnet3/vmxnet3_ethdev.c             |  1 -
 lib/librte_cmdline/cmdline_parse_etheraddr.c     |  1 -
 lib/librte_distributor/rte_distributor.c         |  1 -
 lib/librte_eal/bsdapp/eal/eal.c                  |  2 -
 lib/librte_eal/bsdapp/eal/eal_pci.c              |  2 -
 lib/librte_eal/bsdapp/eal/eal_thread.c           |  1 -
 lib/librte_eal/common/eal_common_dev.c           |  1 -
 lib/librte_eal/common/eal_common_tailqs.c        |  1 -
 lib/librte_eal/common/rte_keepalive.c            |  1 -
 lib/librte_eal/linuxapp/eal/eal.c                |  2 -
 lib/librte_eal/linuxapp/eal/eal_memory.c         |  2 -
 lib/librte_eal/linuxapp/eal/eal_thread.c         |  1 -
 lib/librte_eal/linuxapp/eal/eal_xen_memory.c     |  2 -
 lib/librte_hash/rte_cuckoo_hash.c                |  1 -
 lib/librte_lpm/rte_lpm.c                         |  1 -
 lib/librte_lpm/rte_lpm6.c                        |  1 -
 lib/librte_timer/rte_timer.c                     |  1 -
 test/test-pipeline/config.c                      |  1 -
 test/test-pipeline/init.c                        |  1 -
 test/test-pipeline/main.c                        |  1 -
 test/test-pipeline/runtime.c                     |  2 -
 test/test/test_alarm.c                           |  1 -
 test/test/test_atomic.c                          |  1 -
 test/test/test_eal_flags.c                       |  1 -
 test/test/test_malloc.c                          |  1 -
 test/test/test_mbuf.c                            |  1 -
 test/test/test_mp_secondary.c                    |  4 --
 test/test/test_per_lcore.c                       |  1 -
 test/test/test_ring.c                            |  1 -
 test/test/test_rwlock.c                          |  1 -
 test/test/test_spinlock.c                        |  1 -
 58 files changed, 64 insertions(+), 70 deletions(-)
 create mode 100755 devtools/dup_include.pl

-- 
2.11.0

             reply	other threads:[~2017-07-11 18:55 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11 18:55 Stephen Hemminger [this message]
2017-07-11 18:55 ` [dpdk-dev] [PATCH 01/19] devtools: add simple script to find " Stephen Hemminger
2017-07-11 20:33   ` Thomas Monjalon
2017-07-11 23:05     ` Stephen Hemminger
2017-07-12  6:41       ` Thomas Monjalon
2017-07-12 21:59     ` Stephen Hemminger
2017-07-13  6:56       ` Thomas Monjalon
2017-07-13 12:19         ` Wiles, Keith
2017-07-13 12:36           ` Thomas Monjalon
2017-07-14 15:39         ` Thomas Monjalon
2017-07-14 15:54           ` Thomas Monjalon
2017-07-14 16:17             ` Wiles, Keith
2017-07-14 17:07   ` [dpdk-dev] [PATCH] devtools: add script to find duplicated includes Thomas Monjalon
2017-07-14 18:39     ` Wiles, Keith
2017-07-14 18:43       ` Wiles, Keith
2017-07-15  9:44         ` Thomas Monjalon
2017-07-15 10:00     ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2017-08-03 10:06       ` Thomas Monjalon
2017-07-17 11:50     ` [dpdk-dev] [PATCH] " Neil Horman
2017-07-17 13:01       ` Thomas Monjalon
2017-07-11 18:55 ` [dpdk-dev] [PATCH 02/19] eal: remove duplicate includes Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 03/19] cmdline: remove duplicate include of errno.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 04/19] distributor: remove duplicate include of rte_compat.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 05/19] lpm: remove duplicate include of errno.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 06/19] cuckoo_hash: remove duplicate include of rte_log.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 07/19] timer: remove duplicate include of rte_per_lcore.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 08/19] bnxt: remove duplicate include of unistd.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 09/19] ixgbe: remove duplicate include of rte_atomic.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 10/19] i40e: " Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 11/19] virtio: remove duplicated includes Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 12/19] cxgbe: " Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 13/19] vmxnet3: remove duplicated include of rte_atomic.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 14/19] dpaa2: remove duplicated includes Stephen Hemminger
2017-07-13  9:38   ` Hemant Agrawal
2017-07-11 18:55 ` [dpdk-dev] [PATCH 15/19] fsmlc: " Stephen Hemminger
2017-07-13  9:39   ` Hemant Agrawal
2017-07-11 18:55 ` [dpdk-dev] [PATCH 16/19] app/proc-info: remove duplicate include Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 17/19] app/test-pmd: remove duplicate includes Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 18/19] test/test-pipeline: remove duplicate include of rte_per_lcore.h Stephen Hemminger
2017-07-11 18:55 ` [dpdk-dev] [PATCH 19/19] test/test: remove duplicate includes Stephen Hemminger
2017-07-16 15:34 ` [dpdk-dev] [PATCH 00/19] cleanup " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170711185546.26138-1-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).