From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 3D9B1568A for ; Tue, 11 Jul 2017 21:09:17 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id 77so2008549wrb.1 for ; Tue, 11 Jul 2017 12:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=QXJm1szC47O2MwpKFKy5SnHGSJpbp2M4/cQtfdN9cl8=; b=QNWovOWPPdxn9+kMR13n5RgHLq2h/WoHQBfBhUOtstvADqvvnSJvlbsYpeDVN9uLAZ MxjUb+8qvv3QEoCUHdaX/dh3jfXzZe2pwBXsIFx6VP0sw0kbve/TPcO8CUr8wFl7lPlT mm9FgNvYdReTuHWvqj8MEe4mn58C5XyUgjR5ap1mX8JfChMmSHsxjwosa2gLqfZ8dTrF 6t6ew8d4EB06WBW3P6D+PDuD51MDfF4d4NVMp21D2oISTln2ZewR4x9Qu9H/6lJ8VOw3 4/+KvsyhoXw5p6AflqbfmkpQkb0ii7XcPjmxGXrFUlJrk4fpNyWaD/dRF3VoBc7pI+bH ZUSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=QXJm1szC47O2MwpKFKy5SnHGSJpbp2M4/cQtfdN9cl8=; b=Mr+GSqK/zQbuM9zn5H/Oa0BdAnRihqJDyaNUZLYZxAexUH3yFU1zYwqjUmQRFeHCKU bNty0LdcY1mu/cYlJoD74B7vpXu3mJGCJMi3wz9K7oLtQwnbhwENtKX173mGhzh4ujkG vf/TbXqFFrLpMQq6doM6Tsl725xjdwRcyQf2VagE/wQYKFxBal+HVeiPNKVt+gREjBVT PPtC1g8OPBAi4c+FwXvWNYH0gBWTdcYOFVovctux277o1UAjChTqJUJeMiJdJpMFuXi2 iHsYiAZE0XUF6mHTu3DYTO3FMfnGei9xsX/7e49jYgWwYlGZJtl1lE0vTuzjp1sAMSr3 Jpyw== X-Gm-Message-State: AIVw113hCguu12xpcbaP84su1foTr5izzFd52LA/PgagWdfozJbTrsCc 55R4vg5A0BeT8SK4 X-Received: by 10.28.92.80 with SMTP id q77mr3776447wmb.4.1499800156637; Tue, 11 Jul 2017 12:09:16 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m123sm116191wmb.3.2017.07.11.12.09.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 12:09:15 -0700 (PDT) Date: Tue, 11 Jul 2017 21:09:07 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jan Blunck Cc: dev@dpdk.org Message-ID: <20170711190907.GX11154@bidouze.vm.6wind.com> References: <20170711185649.43620-1-jblunck@infradead.org> <20170711185649.43620-3-jblunck@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170711185649.43620-3-jblunck@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/2] vdev: directly use rte_bus reference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 19:09:17 -0000 Hi Jan, On Tue, Jul 11, 2017 at 02:56:49PM -0400, Jan Blunck wrote: > It isn't necessary to use rte_bus_find_by_name() to find a reference to > our own bus. > > Signed-off-by: Jan Blunck > --- > lib/librte_eal/common/eal_common_vdev.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/lib/librte_eal/common/eal_common_vdev.c b/lib/librte_eal/common/eal_common_vdev.c > index 2ca0cdb0f..db69d18c6 100644 > --- a/lib/librte_eal/common/eal_common_vdev.c > +++ b/lib/librte_eal/common/eal_common_vdev.c > @@ -47,6 +47,9 @@ > #include > #include > > +/* Forward declare to access virtual bus name */ > +static struct rte_bus rte_vdev_bus; > + > /** Double linked list of virtual device drivers. */ > TAILQ_HEAD(vdev_device_list, rte_vdev_device); > > @@ -138,7 +141,7 @@ alloc_devargs(const char *name, const char *args) > if (!devargs) > return NULL; > > - devargs->bus = rte_bus_find_by_name("vdev"); > + devargs->bus = rte_bus_find_by_name(rte_vdev_bus.name); Why not directly &rte_vdev_bus here? > if (args) > devargs->args = strdup(args); > > @@ -250,13 +253,11 @@ vdev_scan(void) > { > struct rte_vdev_device *dev; > struct rte_devargs *devargs; > - struct rte_bus *vbus; > > /* for virtual devices we scan the devargs_list populated via cmdline */ > - vbus = rte_bus_find_by_name("vdev"); > TAILQ_FOREACH(devargs, &devargs_list, next) { > > - if (devargs->bus != vbus) > + if (devargs->bus != &rte_vdev_bus) > continue; > > dev = find_vdev(devargs->name); > -- > 2.13.2 > -- Gaëtan Rivet 6WIND