From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 9EA985598 for ; Tue, 11 Jul 2017 21:21:12 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id r103so2460509wrb.0 for ; Tue, 11 Jul 2017 12:21:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GJ+kfpFjXmx/XSkdJ2n+pCYkdr7iRtL7Sq1kdnb55RQ=; b=JiPH9lY/Lf/Wi/E3V86ahNcLIWOmzn+CuZNBT/AMo/wWO7ZqPoV/tUXC4bzifm4BJ9 w6U5DN5ouedlb0OrM7rNi6Mvb2kAxNaZJxZuuG4wMnAZjatZcOkgb9iwhphecYlK97ba igJzzL+a9GILhlHRH9p992I3E9gM/27qcDnEN1zeFGar4kJwK45JF6SRm/SxIvV1VFPB iCFLIOAn5Lyrw2xhH7/2uTBX/Abw02whZ8IVAUqJReZ/jN+7Uo2Aang4LLSL+xQ86ndW WPuNS6zLeGj56i4/Ih0QYGLXHIOeaPH8K6IGDLHAvExUq2UmEl9A0Qe4YoY8SPE8UoDJ zJrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GJ+kfpFjXmx/XSkdJ2n+pCYkdr7iRtL7Sq1kdnb55RQ=; b=fhC/xkSKbKp1UDHI41ruvV1thq8nQVm1DBaLGTfHPsc9GVfZrSNwZCIpTMB/Sufiu9 9x1N9egmzwlk4Gpfa3GGQWVMLrkPZCaRd7lg37L2ti+z7PzYl8AKCUqJPcdIidMy/lz1 qw9rBKA+Vi+MPrSz+++RDw0Pf0z0Lg8ICqkIm+NSU4ZHFS0yfU86/diR8CArjGTdXM/7 GRAlg82RlA9Wgc2mdLieBmy9MtKom16R0GLp7k93RNWTy92Ml8s9qWG1nilTLoEmPuiU dNLo8VWobkX+SBgzEaa3flsKyFZw/bMaRmB9N4sCjnTD6yFObq39qlyXEzV3xGX77k3L 9WQw== X-Gm-Message-State: AIVw113N3dm8l6d88Mc9kf1Ouep1ZKTsvIyDcbIWuSdtQHYxx+NEASFG X7ayboE/5uzm6Ifm X-Received: by 10.223.155.150 with SMTP id d22mr790464wrc.193.1499800872128; Tue, 11 Jul 2017 12:21:12 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h10sm67481wme.30.2017.07.11.12.21.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 12:21:11 -0700 (PDT) Date: Tue, 11 Jul 2017 21:21:02 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jan Blunck Cc: Thomas Monjalon , Shreyansh Jain , Stephen Hemminger , Bruce Richardson , dev@dpdk.org Message-ID: <20170711192102.GY11154@bidouze.vm.6wind.com> References: <1881782.F5Es4knhFG@xps> <20170711160211.GW11154@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 0/9] fix hotplug API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 19:21:13 -0000 On Tue, Jul 11, 2017 at 03:07:02PM -0400, Jan Blunck wrote: > On Tue, Jul 11, 2017 at 12:02 PM, Gaëtan Rivet wrote: > > On Sun, Jul 09, 2017 at 04:19:05PM +0200, Thomas Monjalon wrote: > >> 09/07/2017 12:38, Jan Blunck: > >> > On Sat, Jul 8, 2017 at 9:45 PM, Gaetan Rivet wrote: > >> > > Sending those fixes as separate patches as they stand on their own. > >> > > This series improves usability of the hotplug API and fixes a few issues > >> > > with existing implementations. > >> > > > >> > > >> > Interesting that you send this series as fixes. From what I can tell > >> > this is a collection of changes that you have proposed before and I > >> > have commented on and requested changes for. But I don't see that they > >> > have been addressed at all: > >> > > >> > - you still concatenate the bus and device name just to pass it down > >> > to the buses and parse it into its components again > >> > - you still delegate the devargs parsing to the buses > >> > > >> > Please fix this issues. If you really want to return a device handle > >> > from the hotplug API please present the use-case and in which cases > >> > this solves a real-world problem. > >> > >> Please Jan, could you check in the 9 patches of this series > >> which ones are OK for you? > >> Thank you > >> > > > > Hi Jan, > > > > I sent a new version, consisting mostly in fixes, apart from removing > > the devarg argument from plug / unplug (which is closely tied to the > > fixes I proposed). I removed the changes to rte_eal_hotplug_add return > > value. > > > > Thanks for the notice. I'll have a look. > > > What do you think of this version? The hotplug must be fixed before > > the release, this way or another. > > > > Do you mean the hotplug of real devices or of virtual devices? Well, both ideally. Virtual devices are not so different from real devices in the end. The vdev scan allocates rte_vdev_devices, which are linked to their rte_devargs. after this scan, it is possible to use vdev->find_device() to get back the handle to use during the (hypothetical) vdev->plug(). So it is not far from a regular bus. This proximity is a good thing IMO, as it allows genericity in its use. No need to define an exception for the vdev bus, it can be used with the others. Which is useful, if we consider decoupling the EAL from the vdev bus. Given that this change will not happen during this release it is not strictly necessary, but it seems clean enough and should simplify future work anyway. -- Gaëtan Rivet 6WIND