From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 2DFB62E8B for ; Tue, 11 Jul 2017 23:48:29 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id c11so7317212wrc.3 for ; Tue, 11 Jul 2017 14:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=UNtffyk2yfaHETNAblT+06BFM8JO8r6X/ihFy+T3IPw=; b=aYYLiBAoJcMUFPrFdOEquA6Cx94RvOuECfF1gHtKyICNLsXgkimjkJyg5C+xmmh2F6 1n30frpQSVGY0LYN1fgVdBlx1OhTRhIU8z4QHSzKc69ap0NXCAeukSEfe3QFtw2xsQlK 6B7SEkqrLqQSzA2q+Je5m2b4kPiFsfiH+TxfKkGmEqkKdXkTm1U+oSxi1+xrh/XAaaji EahGrGP7roq105AVDP+qdc3Lv524C1+NclNGvJnjG2c60FH2T3eNKUGiEueneZycSXoe uPXUvZ0Bv7XYSdoY46C6ApDvnYNKed7Q4QmCzNTJW13sbH1IgQD8otDhvNcYi/49kC9U H6oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=UNtffyk2yfaHETNAblT+06BFM8JO8r6X/ihFy+T3IPw=; b=VhqE3WnoqNQNiBBcqxRF6JRmglrhriF69POQ8qhIGsZ1fxJ9frFujwz5Jtn3pKNShQ zxcHmx28VvRDZGe0vTudDwCpxMdEZy5ET0MJ20ov8EVXBj3MO3M6z+F9tYsQGDYk32np ns+U9vKGUXmf5SEG1UnOrwJb7HWpzQqbktfTGpjlflrAx9k1MWqGIrdBmtfDJEbX9Qv6 1s9sxZxDIxJd0NVLkiD6ke9Ryju+csM6UhWZx4B8o4FJpH3q9N5H/96vM5t5wJHwPs+b UcjOdcNdLQvmBhPFdSHo3xSoVifWyUkxH4zzjWUqbWCy7L8MGQLWNPMApdqwLoN6N8rY 71vA== X-Gm-Message-State: AIVw111RWSogWjMfCeokUJl5qFQ8armm0ZS01YPlgqZNbKTHY6CU0PO2 OisiJ6n3F213s306PTU= X-Received: by 10.28.184.83 with SMTP id i80mr228580wmf.98.1499809708817; Tue, 11 Jul 2017 14:48:28 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z190sm525334wmz.31.2017.07.11.14.48.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 14:48:27 -0700 (PDT) Date: Tue, 11 Jul 2017 23:48:19 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20170711214819.GZ11154@bidouze.vm.6wind.com> References: <6696281.voRgjYsRM1@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6696281.voRgjYsRM1@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 21:48:29 -0000 On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > 11/07/2017 01:19, Gaetan Rivet: > > --- /dev/null > > +++ b/drivers/net/failsafe/failsafe_args.c > [...] > > +#include > > Do you really need errno in this file? It's used for error handling on strtoull and popen. Why, is it a problem to include errno.h? -- Gaëtan Rivet 6WIND