From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id E3DA9376C for ; Wed, 12 Jul 2017 00:25:59 +0200 (CEST) Received: by mail-wr0-f174.google.com with SMTP id r103so8500728wrb.0 for ; Tue, 11 Jul 2017 15:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qwjTwiigcum9L2dJpdyHqS0pAujWuMUMftS6WrNLlYo=; b=lpKOdXWfKG2cCTAgfkj0poHG8jVsnGm+9cAP32o9CWL2vBR+egFMHg3q6spaw6+hUj JTyn9G7S3VIVyMm/d5kCewW5jjAuhWlVwdof13BAFc4Ytd7LaABDqbcj+K71C8Cgo/Tj qWSc7ioRlEuTDkWsRBC+2jnwwye593/VfYFAZweaHV5CzTwDSFQEd0xTf8WwxcvygCYh deRFTi+NtVnvdCSb39RHn1zZDqPPDagI1gZ3KmYhSHclt1Vg9V/htkOV90Dk3se/ccRU x2pOPVn1KIK7jUEC6uhRMqofsB+N7hiwjFYdGdA6vQIW+WvYdx5AFAMeYlH2tbR2zSjU 2QfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qwjTwiigcum9L2dJpdyHqS0pAujWuMUMftS6WrNLlYo=; b=pjvaEelQG3igJiUefiPxI/FrQIpytdZk58+X79ZDE6wyD0yoKON6NIPyfvKbfTORfm q4PEoCCw+SzrVrTlspmBljs4LZB5p6TbO1SXVir+8snzORAfVlZ/C34Ry6mKmsUXXfPE zsffwQoJnZ7SlIUuYb76sVNzhf6TB/Pj1uq/g76zVphCCbJSASKJKERldZrujjz+aiwK Lj0O+0RRp3pHcLKNnIYGzi3vr6ZZxHpdiGZNpQcUksGusa5UBVXylRgijLqSWs1rTNPU sBnNGm7x5QUcwxRYEd16UMW7SK8iyu1zrSX7GNTyo/3IPnSCtCoLs0Vdxp9nXpu62Ndf sIDQ== X-Gm-Message-State: AIVw112TrcnlQpKfzPwTw1QOOi1AE+yiM3GT/vcpdnXAw4mGofTjH5a3 /cZL4fh6YLHFQYzyM/0= X-Received: by 10.28.191.134 with SMTP id o6mr295060wmi.11.1499811959367; Tue, 11 Jul 2017 15:25:59 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e31sm535070wre.54.2017.07.11.15.25.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 11 Jul 2017 15:25:58 -0700 (PDT) Date: Wed, 12 Jul 2017 00:25:49 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20170711222549.GA11154@bidouze.vm.6wind.com> References: <6696281.voRgjYsRM1@xps> <20170711214819.GZ11154@bidouze.vm.6wind.com> <83323603.jg1xmzcquq@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83323603.jg1xmzcquq@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v8 03/11] net/failsafe: add fail-safe PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2017 22:26:00 -0000 On Wed, Jul 12, 2017 at 12:21:24AM +0200, Thomas Monjalon wrote: > 11/07/2017 23:48, Gaëtan Rivet: > > On Tue, Jul 11, 2017 at 09:57:51PM +0200, Thomas Monjalon wrote: > > > 11/07/2017 01:19, Gaetan Rivet: > > > > --- /dev/null > > > > +++ b/drivers/net/failsafe/failsafe_args.c > > > [...] > > > > +#include > > > > > > Do you really need errno in this file? > > > > It's used for error handling on strtoull and popen. > > Why, is it a problem to include errno.h? > > I don't see errno used in this patch. > I think it is used in next patches. Ah, yes, you're right, sorry. Will fix, thanks. -- Gaëtan Rivet 6WIND