* [dpdk-dev] [PATCH 1/5] doc: fix supported algorithm table for AESNI GCM PMD
2017-07-13 5:36 [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Pablo de Lara
@ 2017-07-13 5:36 ` Pablo de Lara
2017-07-13 5:36 ` [dpdk-dev] [PATCH 2/5] doc: remove incorrect limitation on QAT PMD Pablo de Lara
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Pablo de Lara @ 2017-07-13 5:36 UTC (permalink / raw)
To: declan.doherty, fiona.trahe, john.griffin, deepak.k.jain
Cc: dev, Pablo de Lara
AESNI GCM PMD now supports 192-bit keys for AES-GCM,
so the supported algorithm table should be updated.
Fixes: 6f16aab09a91 ("crypto/aesni_gcm: migrate to Multi-buffer library")
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
doc/guides/cryptodevs/features/aesni_gcm.ini | 1 +
1 file changed, 1 insertion(+)
diff --git a/doc/guides/cryptodevs/features/aesni_gcm.ini b/doc/guides/cryptodevs/features/aesni_gcm.ini
index 0f11fef..bacd94e 100644
--- a/doc/guides/cryptodevs/features/aesni_gcm.ini
+++ b/doc/guides/cryptodevs/features/aesni_gcm.ini
@@ -26,4 +26,5 @@ AES GMAC = Y
;
[AEAD]
AES GCM (128) = Y
+AES GCM (192) = Y
AES GCM (256) = Y
--
2.9.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH 2/5] doc: remove incorrect limitation on QAT PMD
2017-07-13 5:36 [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Pablo de Lara
2017-07-13 5:36 ` [dpdk-dev] [PATCH 1/5] doc: fix supported algorithm table for AESNI GCM PMD Pablo de Lara
@ 2017-07-13 5:36 ` Pablo de Lara
2017-07-14 15:58 ` Trahe, Fiona
2017-07-13 5:36 ` [dpdk-dev] [PATCH 3/5] doc: remove incorrect limitation on AESNI MB PMD Pablo de Lara
` (4 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Pablo de Lara @ 2017-07-13 5:36 UTC (permalink / raw)
To: declan.doherty, fiona.trahe, john.griffin, deepak.k.jain
Cc: dev, Pablo de Lara, stable
QAT supports authentication only operations,
for any authentication algorithm (such as SHA1-HMAC),
as long as it is supported by QAT, so it means
that it is not necessary to create a chained operation
in order to use these algorithms.
Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
CC: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
doc/guides/cryptodevs/qat.rst | 1 -
test/test/test_cryptodev.c | 19 +++++++++++++++
test/test/test_cryptodev_hash_test_vectors.h | 36 ++++++++++++++++++----------
3 files changed, 43 insertions(+), 13 deletions(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index b2d05e5..7a510c9 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -84,7 +84,6 @@ Supported AEAD algorithms:
Limitations
-----------
-* Hash only is not supported except SNOW 3G UIA2 and KASUMI F9.
* Only supports the session-oriented API implementation (session-less APIs are not supported).
* SNOW 3G (UEA2) and KASUMI (F8) supported only if cipher length, cipher offset fields are byte-aligned.
* SNOW 3G (UIA2) and KASUMI (F9) supported only if hash length, hash offset fields are byte-aligned.
diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
index b068609..4836645 100644
--- a/test/test/test_cryptodev.c
+++ b/test/test/test_cryptodev.c
@@ -1594,6 +1594,24 @@ test_authonly_mb_all(void)
}
static int
+test_authonly_qat_all(void)
+{
+ struct crypto_testsuite_params *ts_params = &testsuite_params;
+ int status;
+
+ status = test_blockcipher_all_tests(ts_params->mbuf_pool,
+ ts_params->op_mpool,
+ ts_params->session_mpool,
+ ts_params->valid_devs[0],
+ rte_cryptodev_driver_id_get(
+ RTE_STR(CRYPTODEV_NAME_QAT_SYM_PMD)),
+ BLKCIPHER_AUTHONLY_TYPE);
+
+ TEST_ASSERT_EQUAL(status, 0, "Test failed");
+
+ return TEST_SUCCESS;
+}
+static int
test_AES_chain_mb_all(void)
{
struct crypto_testsuite_params *ts_params = &testsuite_params;
@@ -7994,6 +8012,7 @@ static struct unit_test_suite cryptodev_qat_testsuite = {
test_AES_docsis_qat_all),
TEST_CASE_ST(ut_setup, ut_teardown,
test_DES_docsis_qat_all),
+ TEST_CASE_ST(ut_setup, ut_teardown, test_authonly_qat_all),
TEST_CASE_ST(ut_setup, ut_teardown, test_stats),
/** AES GCM Authenticated Encryption */
diff --git a/test/test/test_cryptodev_hash_test_vectors.h b/test/test/test_cryptodev_hash_test_vectors.h
index 24353fc..b7fe9d9 100644
--- a/test/test/test_cryptodev_hash_test_vectors.h
+++ b/test/test/test_cryptodev_hash_test_vectors.h
@@ -367,7 +367,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "HMAC-MD5 Digest Verify",
@@ -376,7 +377,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "SHA1 Digest",
@@ -397,7 +399,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "HMAC-SHA1 Digest Verify",
@@ -406,7 +409,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "SHA224 Digest",
@@ -427,7 +431,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "HMAC-SHA224 Digest Verify",
@@ -436,7 +441,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "SHA256 Digest",
@@ -457,7 +463,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "HMAC-SHA256 Digest Verify",
@@ -466,7 +473,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "SHA384 Digest",
@@ -487,7 +495,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "HMAC-SHA384 Digest Verify",
@@ -496,7 +505,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "SHA512 Digest",
@@ -517,7 +527,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
{
.test_descr = "HMAC-SHA512 Digest Verify",
@@ -526,7 +537,8 @@ static const struct blockcipher_test_case hash_test_cases[] = {
.pmd_mask = BLOCKCIPHER_TEST_TARGET_PMD_OPENSSL |
BLOCKCIPHER_TEST_TARGET_PMD_MB |
BLOCKCIPHER_TEST_TARGET_PMD_SCHEDULER |
- BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC
+ BLOCKCIPHER_TEST_TARGET_PMD_DPAA2_SEC |
+ BLOCKCIPHER_TEST_TARGET_PMD_QAT
},
};
--
2.9.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 2/5] doc: remove incorrect limitation on QAT PMD
2017-07-13 5:36 ` [dpdk-dev] [PATCH 2/5] doc: remove incorrect limitation on QAT PMD Pablo de Lara
@ 2017-07-14 15:58 ` Trahe, Fiona
0 siblings, 0 replies; 10+ messages in thread
From: Trahe, Fiona @ 2017-07-14 15:58 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Doherty, Declan, Griffin, John, Jain, Deepak K
Cc: dev, stable
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, July 13, 2017 6:37 AM
> To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: [PATCH 2/5] doc: remove incorrect limitation on QAT PMD
>
> QAT supports authentication only operations,
> for any authentication algorithm (such as SHA1-HMAC),
> as long as it is supported by QAT, so it means
> that it is not necessary to create a chained operation
> in order to use these algorithms.
>
> Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices")
> CC: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 3/5] doc: remove incorrect limitation on AESNI MB PMD
2017-07-13 5:36 [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Pablo de Lara
2017-07-13 5:36 ` [dpdk-dev] [PATCH 1/5] doc: fix supported algorithm table for AESNI GCM PMD Pablo de Lara
2017-07-13 5:36 ` [dpdk-dev] [PATCH 2/5] doc: remove incorrect limitation on QAT PMD Pablo de Lara
@ 2017-07-13 5:36 ` Pablo de Lara
2017-07-13 5:36 ` [dpdk-dev] [PATCH 4/5] doc: add missing algorithm in limitations for QAT Pablo de Lara
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: Pablo de Lara @ 2017-07-13 5:36 UTC (permalink / raw)
To: declan.doherty, fiona.trahe, john.griffin, deepak.k.jain
Cc: dev, Pablo de Lara, stable
AESNI MB PMD supports sessionless operations,
but the documentation was stating that only
operations with session were supported.
Fixes: 924e84f87306 ("aesni_mb: add driver for multi buffer based crypto")
CC: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
doc/guides/cryptodevs/aesni_mb.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/cryptodevs/aesni_mb.rst b/doc/guides/cryptodevs/aesni_mb.rst
index 79fb37f..3f49246 100644
--- a/doc/guides/cryptodevs/aesni_mb.rst
+++ b/doc/guides/cryptodevs/aesni_mb.rst
@@ -68,7 +68,7 @@ Limitations
* Chained mbufs are not supported.
* Only in-place is currently supported (destination address is the same as source address).
-* Only supports session-oriented API implementation (session-less APIs are not supported).
+
Installation
------------
--
2.9.4
^ permalink raw reply [flat|nested] 10+ messages in thread* [dpdk-dev] [PATCH 4/5] doc: add missing algorithm in limitations for QAT
2017-07-13 5:36 [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Pablo de Lara
` (2 preceding siblings ...)
2017-07-13 5:36 ` [dpdk-dev] [PATCH 3/5] doc: remove incorrect limitation on AESNI MB PMD Pablo de Lara
@ 2017-07-13 5:36 ` Pablo de Lara
2017-07-14 16:13 ` Trahe, Fiona
2017-07-13 5:36 ` [dpdk-dev] [PATCH 5/5] doc: extend installation section on SNOW3G/KASUMI PMDs Pablo de Lara
` (2 subsequent siblings)
6 siblings, 1 reply; 10+ messages in thread
From: Pablo de Lara @ 2017-07-13 5:36 UTC (permalink / raw)
To: declan.doherty, fiona.trahe, john.griffin, deepak.k.jain
Cc: dev, Pablo de Lara, stable
For KASUMI, SNOW3G and ZUC algorithms, offsets and lengths
of the data to cipher or authenticate is provided in bits,
but QAT does not support non-byte aligned values,
although only KASUMI and SNOW3G were mentioned.
Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
doc/guides/cryptodevs/qat.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
index 7a510c9..8e390ee 100644
--- a/doc/guides/cryptodevs/qat.rst
+++ b/doc/guides/cryptodevs/qat.rst
@@ -85,8 +85,8 @@ Limitations
-----------
* Only supports the session-oriented API implementation (session-less APIs are not supported).
-* SNOW 3G (UEA2) and KASUMI (F8) supported only if cipher length, cipher offset fields are byte-aligned.
-* SNOW 3G (UIA2) and KASUMI (F9) supported only if hash length, hash offset fields are byte-aligned.
+* SNOW 3G (UEA2), KASUMI (F8) and ZUC (EEA3) supported only if cipher length, cipher offset fields are byte-aligned.
+* SNOW 3G (UIA2), KASUMI (F9) and ZUC (EIA3) supported only if hash length, hash offset fields are byte-aligned.
* No BSD support as BSD QAT kernel driver not available.
* ZUC EEA3/EIA3 is not supported by dh895xcc devices
* Maximum additional authenticated data (AAD) for GCM is 240 bytes long.
--
2.9.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 4/5] doc: add missing algorithm in limitations for QAT
2017-07-13 5:36 ` [dpdk-dev] [PATCH 4/5] doc: add missing algorithm in limitations for QAT Pablo de Lara
@ 2017-07-14 16:13 ` Trahe, Fiona
0 siblings, 0 replies; 10+ messages in thread
From: Trahe, Fiona @ 2017-07-14 16:13 UTC (permalink / raw)
To: De Lara Guarch, Pablo, Doherty, Declan, Griffin, John, Jain, Deepak K
Cc: dev, stable
Hi Pablo,
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, July 13, 2017 6:37 AM
> To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona <fiona.trahe@intel.com>; Griffin, John
> <john.griffin@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: [PATCH 4/5] doc: add missing algorithm in limitations for QAT
>
> For KASUMI, SNOW3G and ZUC algorithms, offsets and lengths
> of the data to cipher or authenticate is provided in bits,
> but QAT does not support non-byte aligned values,
> although only KASUMI and SNOW3G were mentioned.
>
> Fixes: d9b7d5bbc845 ("crypto/qat: add ZUC EEA3/EIA3 capability")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> doc/guides/cryptodevs/qat.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst
> index 7a510c9..8e390ee 100644
> --- a/doc/guides/cryptodevs/qat.rst
> +++ b/doc/guides/cryptodevs/qat.rst
> @@ -85,8 +85,8 @@ Limitations
> -----------
>
> * Only supports the session-oriented API implementation (session-less APIs are not supported).
> -* SNOW 3G (UEA2) and KASUMI (F8) supported only if cipher length, cipher offset fields are byte-
> aligned.
> -* SNOW 3G (UIA2) and KASUMI (F9) supported only if hash length, hash offset fields are byte-aligned.
> +* SNOW 3G (UEA2), KASUMI (F8) and ZUC (EEA3) supported only if cipher length, cipher offset fields
> are byte-aligned.
> +* SNOW 3G (UIA2), KASUMI (F9) and ZUC (EIA3) supported only if hash length, hash offset fields are
> byte-aligned.
Just being pedantic, but now would be a good time to change these to "byte-multiple"
^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH 5/5] doc: extend installation section on SNOW3G/KASUMI PMDs
2017-07-13 5:36 [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Pablo de Lara
` (3 preceding siblings ...)
2017-07-13 5:36 ` [dpdk-dev] [PATCH 4/5] doc: add missing algorithm in limitations for QAT Pablo de Lara
@ 2017-07-13 5:36 ` Pablo de Lara
2017-07-13 17:00 ` [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Declan Doherty
2017-07-16 10:52 ` De Lara Guarch, Pablo
6 siblings, 0 replies; 10+ messages in thread
From: Pablo de Lara @ 2017-07-13 5:36 UTC (permalink / raw)
To: declan.doherty, fiona.trahe, john.griffin, deepak.k.jain
Cc: dev, Pablo de Lara
SNOW3G and KASUMI SW libraries encrypt buffers
assuming that they are padded to a specific block size.
This behaviour can be changed to avoid buffer overflow,
by modifying the Makefile of these libraries.
Therefore, the Installation section in the SNOW3G and
KASUMI documentation has been extended, to document
this case.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
doc/guides/cryptodevs/kasumi.rst | 12 ++++++++++++
doc/guides/cryptodevs/snow3g.rst | 11 +++++++++++
2 files changed, 23 insertions(+)
diff --git a/doc/guides/cryptodevs/kasumi.rst b/doc/guides/cryptodevs/kasumi.rst
index bff9321..738ecee 100644
--- a/doc/guides/cryptodevs/kasumi.rst
+++ b/doc/guides/cryptodevs/kasumi.rst
@@ -70,6 +70,18 @@ on their system before building DPDK::
make
+**Note**: When encrypting with KASUMI F8, by default the library
+encrypts full blocks of 8 bytes, regardless the number of bytes to
+be encrypted provided (which leads to a possible buffer overflow).
+To avoid this situation, it is necessary not to pass
+3GPP_SAFE_BUFFERS as a compilation flag.
+Also, this is required when using chained operations
+(cipher-then-auth/auth-then-cipher).
+For this, in the Makefile of the library, make sure that this flag
+is commented out::
+
+ #EXTRA_CFLAGS += -D_3GPP_SAFE_BUFFERS
+
**Note**: To build the PMD as a shared library, the libsso_kasumi
library must be built as follows::
diff --git a/doc/guides/cryptodevs/snow3g.rst b/doc/guides/cryptodevs/snow3g.rst
index 12b6c4a..41c48d6 100644
--- a/doc/guides/cryptodevs/snow3g.rst
+++ b/doc/guides/cryptodevs/snow3g.rst
@@ -69,6 +69,17 @@ on their system before building DPDK::
make snow3G
+**Note**: When encrypting with SNOW3G UEA2, by default the library
+encrypts blocks of 4 bytes, regardless the number of bytes to
+be encrypted provided (which leads to a possible buffer overflow).
+To avoid this situation, it is necessary not to pass
+3GPP_SAFE_BUFFERS as a compilation flag.
+For this, in the Makefile of the library, make sure that this flag
+is commented out.::
+
+ #EXTRA_CFLAGS += -D_3GPP_SAFE_BUFFERS
+
+
Initialization
--------------
--
2.9.4
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation
2017-07-13 5:36 [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Pablo de Lara
` (4 preceding siblings ...)
2017-07-13 5:36 ` [dpdk-dev] [PATCH 5/5] doc: extend installation section on SNOW3G/KASUMI PMDs Pablo de Lara
@ 2017-07-13 17:00 ` Declan Doherty
2017-07-16 10:52 ` De Lara Guarch, Pablo
6 siblings, 0 replies; 10+ messages in thread
From: Declan Doherty @ 2017-07-13 17:00 UTC (permalink / raw)
To: Pablo de Lara, fiona.trahe, john.griffin, deepak.k.jain; +Cc: dev
On 13/07/2017 6:36 AM, Pablo de Lara wrote:
> Patchset with some fixes/additions for crypto PMDs
> documents.
>
> Pablo de Lara (5):
> doc: fix supported algorithm table for AESNI GCM PMD
> doc: remove incorrect limitation on QAT PMD
> doc: remove incorrect limitation on AESNI MB PMD
> doc: add missing algorithm in limitations for QAT
> doc: extend installation section on SNOW3G/KASUMI PMDs
>
> doc/guides/cryptodevs/aesni_mb.rst | 2 +-
> doc/guides/cryptodevs/features/aesni_gcm.ini | 1 +
> doc/guides/cryptodevs/kasumi.rst | 12 ++++++++++
> doc/guides/cryptodevs/qat.rst | 5 ++--
> doc/guides/cryptodevs/snow3g.rst | 11 +++++++++
> test/test/test_cryptodev.c | 19 +++++++++++++++
> test/test/test_cryptodev_hash_test_vectors.h | 36 ++++++++++++++++++----------
> 7 files changed, 70 insertions(+), 16 deletions(-)
>
Series Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation
2017-07-13 5:36 [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Pablo de Lara
` (5 preceding siblings ...)
2017-07-13 17:00 ` [dpdk-dev] [PATCH 0/5] Fix crypto PMDs documentation Declan Doherty
@ 2017-07-16 10:52 ` De Lara Guarch, Pablo
6 siblings, 0 replies; 10+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-16 10:52 UTC (permalink / raw)
To: Doherty, Declan, Trahe, Fiona, Griffin, John, Jain, Deepak K; +Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Thursday, July 13, 2017 6:37 AM
> To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Griffin, John <john.griffin@intel.com>; Jain,
> Deepak K <deepak.k.jain@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH 0/5] Fix crypto PMDs documentation
>
> Patchset with some fixes/additions for crypto PMDs documents.
>
> Pablo de Lara (5):
> doc: fix supported algorithm table for AESNI GCM PMD
> doc: remove incorrect limitation on QAT PMD
> doc: remove incorrect limitation on AESNI MB PMD
> doc: add missing algorithm in limitations for QAT
> doc: extend installation section on SNOW3G/KASUMI PMDs
>
> doc/guides/cryptodevs/aesni_mb.rst | 2 +-
> doc/guides/cryptodevs/features/aesni_gcm.ini | 1 +
> doc/guides/cryptodevs/kasumi.rst | 12 ++++++++++
> doc/guides/cryptodevs/qat.rst | 5 ++--
> doc/guides/cryptodevs/snow3g.rst | 11 +++++++++
> test/test/test_cryptodev.c | 19 +++++++++++++++
> test/test/test_cryptodev_hash_test_vectors.h | 36
> ++++++++++++++++++----------
> 7 files changed, 70 insertions(+), 16 deletions(-)
>
> --
> 2.9.4
Applied to dpdk-next-crypto, after modification suggested by Fiona.
Pablo
^ permalink raw reply [flat|nested] 10+ messages in thread