From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 0917F2BAA for ; Thu, 13 Jul 2017 09:05:06 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id 62so14178921wmw.1 for ; Thu, 13 Jul 2017 00:05:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VeCnGKzWTSjsyMJabTPWOg5T/HKqwZrgUtXv2Dmnz2I=; b=SwOyeEOldF9tpGk7/VwN13Xz8+Pra5RUvE7Q2bopBft5qgkHfp/kXouhbuV38HR58b zdFWqgeFmglmJ02XR7XOBVUTpTX0PFcLqXwEYpUWgmkFFMsosEJIcvYTXVHhoDJx+RG6 zznk6ysAp6Jo0jo4vykd+Rx7+J32VIeacgTmCH2bQqAgY229kaou3BkiimPWQbkWbYpT c6MaqF3fN+Oaltlp13Qsez6d7spchoL+i0nQC/b+V2LCXUKpK4TRCOYTE5QLTtniKY5h dhIUpaLhPuifGVNfzVJsD0i+4f3NECiOA5NkVTLVP+XHXF6DelL/z42kk8zCEH1shvXI q9vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=VeCnGKzWTSjsyMJabTPWOg5T/HKqwZrgUtXv2Dmnz2I=; b=ZbJFxSr0f+Gk+4i/jQULSJhBNGJB2k5o2UBqs8Ew5+Rb9P547RmIIKm3ZSfqBqdv38 asQO8BWBcPknQium5lWCmK837yPzNWtDzjPjBLWl2hE3hctzTXS3aIgCGbYWPPjGG0ey UL8BjcZsPzplA5jdHIgCfMtQb8ugTiqeda1BgBpGZe/TisX9R0RfXOI3krO38RaOTyG0 gqui8GdSYbTnjowM3fMOy+6xuG7FDoQHDD4iX0vrWeHArW2SSjSJv+aMSXu/AlXED+ql DibMK8m7f2Pjzi7MliJ9dWVYimqMHFluqnQWyInI0CBk/Ks10xj4NQRmbdyHxqGfHje8 8KQg== X-Gm-Message-State: AIVw113Y4Ec3quDxlWROJaCAMMPkIi2llDUXbvUbzYQ6YXPToaQEDDRi tspf8BaYP26g12jh X-Received: by 10.28.66.67 with SMTP id p64mr777498wma.93.1499929505636; Thu, 13 Jul 2017 00:05:05 -0700 (PDT) Received: from shalom (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k12sm4432984wrc.10.2017.07.13.00.05.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 13 Jul 2017 00:05:05 -0700 (PDT) Date: Thu, 13 Jul 2017 09:04:40 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: ferruh.yigit@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com Message-ID: <20170713070439.bcie7ar5wvh752iy@shalom> References: <20170712220954.35375-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170712220954.35375-1-yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: change start pointer of compressed completion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2017 07:05:06 -0000 On Wed, Jul 12, 2017 at 03:09:54PM -0700, Yongseok Koh wrote: > On a host having 128B cacheline size, some devices insert 64B padding in > each completion entry to avoid partial cacheline write by HW. But, as the > padding is ahead of completion data, casting a completion entry to > compressed mini-completions must start from the middle of the completion. > > Signed-off-by: Yongseok Koh > Acked-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index ab6df19eb..29ce91b05 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1556,7 +1556,7 @@ mlx5_rx_poll_len(struct rxq *rxq, volatile struct mlx5_cqe *cqe, > if (zip->ai) { > volatile struct mlx5_mini_cqe8 (*mc)[8] = > (volatile struct mlx5_mini_cqe8 (*)[8]) > - (uintptr_t)(&(*rxq->cqes)[zip->ca & cqe_cnt]); > + (uintptr_t)(&(*rxq->cqes)[zip->ca & cqe_cnt].pkt_info); > > len = ntohl((*mc)[zip->ai & 7].byte_cnt); > *rss_hash = ntohl((*mc)[zip->ai & 7].rx_hash_result); > @@ -1604,7 +1604,7 @@ mlx5_rx_poll_len(struct rxq *rxq, volatile struct mlx5_cqe *cqe, > volatile struct mlx5_mini_cqe8 (*mc)[8] = > (volatile struct mlx5_mini_cqe8 (*)[8]) > (uintptr_t)(&(*rxq->cqes)[rxq->cq_ci & > - cqe_cnt]); > + cqe_cnt].pkt_info); > > /* Fix endianness. */ > zip->cqe_cnt = ntohl(cqe->byte_cnt); > -- > 2.11.0 > Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND