From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 8C93D29D9 for ; Thu, 13 Jul 2017 15:17:22 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id r103so52995863wrb.0 for ; Thu, 13 Jul 2017 06:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=GdnBRRLIaUC9UNY2anVxhvlH3n4PE6yInvTPtbhTibs=; b=SorqqTLi9sihnwZGwAaJ1un6B8ht/M94CAESp/+bIcfj2koNfS+nUSb7FIXqTouHbs QvuUyG9967b8sLZc115DfiB/H5YOCD7juI+GUajtB6MXNCePkmVjC0Ma0oGyYXzQbQRu 6VZ6DfygLSNUbo4gGADpzJNYkAm/ZZFbcVsIpVJoQNEgg6HZCS5wccku1ezAufvTrQ/7 X+QZRil79ip8/djQK9Z6LlBh1OOVWUWRbsUxGhGxuD4pI7eDtD9k4iDcJ1mFrmZVB9lR /NG+xCFxbHkBpdk39l9P32PyE8ts846r7J+9pAFKUb+PzpJbkTmvIJO3jbu5S+9Xo0Fi /9fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=GdnBRRLIaUC9UNY2anVxhvlH3n4PE6yInvTPtbhTibs=; b=f38mBQAybjWNpriJ2R3HuDoz6HIt88KSgZkmv7qmLtCIn1aE9naoyuC2k9nLdvuSH9 fH/I9wQj8VPjiHChCs3AF5cF30oBvn2L9LSEe7SuLZ2Up8IRAfSxh2EZE/hr613ESVm7 6sqyV+V26Vjk0H6S11u0LljAsL1Dn7z9EIy/iC/0CdJb8OZoDHWZmPHS0IUJxGrTq/eM W81EaDk5/x42ZRSgyi8b7puPxh+NFtMaPSbaWbvBe9wSAZVKGXo5YMnpT3FTg0m3n1Rj qdCTTQWUsPDIstOTF1AMUXM8iAO/HKmjLW4T6pyVL29ur/WzonhQF05cAGzjhNaBvzXJ e6BA== X-Gm-Message-State: AIVw1130Yo/5GAzWok7oEw+I+9H6+J1fN7df7JqWpu3tn3iPe5l1vVaE h+MtMn5QHvYtCEh2opk= X-Received: by 10.223.129.6 with SMTP id 6mr1540006wrm.23.1499951841616; Thu, 13 Jul 2017 06:17:21 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q17sm6050202wmd.4.2017.07.13.06.17.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Jul 2017 06:17:20 -0700 (PDT) Date: Thu, 13 Jul 2017 15:17:12 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Jan Blunck Cc: dev@dpdk.org Message-ID: <20170713131712.GJ11154@bidouze.vm.6wind.com> References: <20170711232512.54641-1-jblunck@infradead.org> <20170711232512.54641-8-jblunck@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170711232512.54641-8-jblunck@infradead.org> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 07/13] devargs: add busname string field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jul 2017 13:17:22 -0000 On Tue, Jul 11, 2017 at 07:25:06PM -0400, Jan Blunck wrote: > This adds the busname as a string to struct rte_devargs. The function > rte_eal_devargs_add() is adding the busname based on the devtype which > is ok for now since the function is deprecated anyway. > > As a side-effect this is also no longer validating the PCI device name. > This was done only for PCI devices anyway but didn't guarantee that this > device exists. > Why add the bus name as a string instead of using the bus handle already present within the rte_devargs? I don't understand the need for this commit, can you explain the problem you are solving? -- Gaëtan Rivet 6WIND