From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f45.google.com (mail-pg0-f45.google.com [74.125.83.45]) by dpdk.org (Postfix) with ESMTP id D37AB2BAA for ; Fri, 14 Jul 2017 20:30:37 +0200 (CEST) Received: by mail-pg0-f45.google.com with SMTP id t186so49536149pgb.1 for ; Fri, 14 Jul 2017 11:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=hG7MrZE779N+3K2Dcgtue4lonlXn5331GMAD77Q+3hQ=; b=wwBaIGC7M/X46WVyx2mgewzyh/D0E/aAhq0NWSNTVTKQmK8PSt4BFyhQn8WoB++kwA ZGOm20g0OMRgvIQddEsM8H77W53Fq7pV0x7CkuquBh41Cdfan3Le1oyeYVwREv5HzaeK Wq7792Bc8LmSTmZNSEMXvnmlHgk+ghuOIlBmyuFcZXfuO3mkiUd/xBUWklfCE6+b8wPZ valzwhg92/LkWI+NYeveFnyqmkLKvQgnW1z9sWMxo1d6yJhVOZbBrjubn53bYVpZ4i3R tgTJULQNk5smdXvksr06CiIM3MVGv8okHtSqMj1rsjz1dQ2Q6W6R9u6ZI55zZ324tVx1 C4Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=hG7MrZE779N+3K2Dcgtue4lonlXn5331GMAD77Q+3hQ=; b=rhqHGEgzE/3wvhc6Twyj/jdGroCBgqW1oV72XxBv0jGTabpEcPbXZGd+cER0hoh6Zp pBBnZLntmEHOhVaHAjFJ/zuRTimdb5L1ltqnnPpRdaxDOzIkCAdi2Olv8uQRZjA8f4J5 GCGXar6AILzFWHFvgFrOR0E+4IUMzzbxdUEiUvXWzlJMK74p06hB8D2Xr/FDq7Vjiv3v fHqO8ajU6IkYHE3mLIRByxl/dMg9iUaXTyULcm2CNkFqWnmrMMhgXebp0aOffWiQtHzG l7/8cfUFLx7NhF3VAgsdES8fUI1L/MRTwjm5TgnDfY+k5lQH50kJOZxVg7X0N7DhYBLi 1nXA== X-Gm-Message-State: AIVw112UpGPUxAoNHYwR3X58D9i5D5DwE/sS/CCX5et41e5Tnu8Mm4eB Esi+LYMt6R0tKYLK7e+fmw== X-Received: by 10.99.143.21 with SMTP id n21mr16257703pgd.145.1500057034759; Fri, 14 Jul 2017 11:30:34 -0700 (PDT) Received: from xeon-e3.wavecable.com (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id r9sm22711163pfi.114.2017.07.14.11.30.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jul 2017 11:30:33 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Fri, 14 Jul 2017 11:30:13 -0700 Message-Id: <20170714183027.16021-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [RFC 00/14] link status API improvement and bugfixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 18:30:38 -0000 While writing new driver, I noticed a lot of unnecessary duplication of code in drivers for handling the eth_dev link status information. While consolidating this, it also became obvious that several drivers have bugs in this are because they don't return the correct value. Also, some drivers were not fully initializing all the space (including padding). This is compile test only at this point, I don't have any of the hardware available (except virtio) to test. Stephen Hemminger (14): ethdev: add link status read/write functions virtio: use eth_link_read/write (and bug fix) bnxt: use rte_link_update vmxnet3: use rte_eth_link_update dpaa2: use rte_eth_link_update nfp: use rte_eth_link_update e1000: use rte_eth_link_update ixgbe: use rte_eth_link_update sfc: use new rte_eth_link helpers i40e: use rte_eth_link_update (and bug fix) liquidio: use _rte_eth_link_update thunderx: use _rte_eth_link_update szedata: use _rte_eth_link_update enic: use _rte_eth_link_update drivers/net/bnxt/bnxt_ethdev.c | 21 +------- drivers/net/dpaa2/dpaa2_ethdev.c | 66 +++--------------------- drivers/net/e1000/em_ethdev.c | 70 ++------------------------ drivers/net/e1000/igb_ethdev.c | 71 ++------------------------ drivers/net/enic/enic_ethdev.c | 5 +- drivers/net/enic/enic_main.c | 16 +++--- drivers/net/i40e/i40e_ethdev.c | 44 +++------------- drivers/net/i40e/i40e_ethdev_vf.c | 19 +------ drivers/net/ixgbe/ixgbe_ethdev.c | 89 +++++---------------------------- drivers/net/liquidio/lio_ethdev.c | 76 +++++++--------------------- drivers/net/nfp/nfp_net.c | 74 +++------------------------ drivers/net/sfc/sfc_ethdev.c | 27 +++------- drivers/net/sfc/sfc_ev.c | 23 ++------- drivers/net/szedata2/rte_eth_szedata2.c | 18 +++---- drivers/net/thunderx/nicvf_ethdev.c | 17 +------ drivers/net/virtio/virtio_ethdev.c | 54 +++----------------- drivers/net/vmxnet3/vmxnet3_ethdev.c | 66 ++---------------------- lib/librte_ether/rte_ethdev.c | 36 +++++++++++++ lib/librte_ether/rte_ethdev.h | 28 +++++++++++ 19 files changed, 171 insertions(+), 649 deletions(-) -- 2.11.0