From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50]) by dpdk.org (Postfix) with ESMTP id 0B2362C2B for ; Fri, 14 Jul 2017 20:30:37 +0200 (CEST) Received: by mail-pg0-f50.google.com with SMTP id t186so49536380pgb.1 for ; Fri, 14 Jul 2017 11:30:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ybkRLIkpaO2C50bDvRwnrDGN6dDSxCeFEyPnihWpVtc=; b=wW2n2b9owyCNKYbe7TIiUxZNkM7f/mgRypGJZBkhwKZYu7pDSSFsl7/EQ/d16klbc3 ocrlwoovy49ynCLrGsrA+P5A5Tg7pxil4wZaP39hAhQpuA7XA9K1cepfQxOCarIYEhHY ZLQc+XgpmMSxTrCiaf6qjFW+MruyjumXmu8qDd4mc1hRibtGLarIxnzTO7p8lKinJDGi tTYcqd3ThH5RHe3k8F7w3L1AW5P2T6051x7NqZWB42ricVr6CT3quJ12lX1aYykSm8ij rxAYRV+57FZaUCKnjb7cSHaZJ9lGxmQqe6Hc87GXUGzOZCaWTqyjCZmn4evQ/RSuRKOm DbLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ybkRLIkpaO2C50bDvRwnrDGN6dDSxCeFEyPnihWpVtc=; b=YV4w1Z4KaaTcQbkY/mHqAIQxAhZ1fNzlTxokUC9AdGwHQeuHFbziGe0+5JJ6WXdi2l Q0H0RFTSK7bcVk0cXUhrpAoIZodTqUgqCdabWNtq8rDQLSfJyKMKgiRjYw7iF6n6Q7P2 TaqIkzrpO7KA5ZK494J00TsFSnpxa4AerOGnk19wMl2ThhiIbJQXo/9Z7JQevB73ump+ EFJFeGzZkZUTVtdbeBzNYyyWTdLyrWYUvFbbG6frjc1XN3wuE4NqfuxIZ8S1l5aAqqbA YZ/gsPBdIQKPDzLYt+EY5Uec8Kl5R1L0DdaGZnZvkEX4p/OmF/eRt6Bs4PNOt8tkRodq U92w== X-Gm-Message-State: AIVw112/D0Q85uDSkj/WsuTYK0VZuDsBF32VnVRSHOI9HkRtJadJpe3N jVgp9T8RoWG8nHhCqGewEw== X-Received: by 10.101.91.203 with SMTP id o11mr16266783pgr.206.1500057035977; Fri, 14 Jul 2017 11:30:35 -0700 (PDT) Received: from xeon-e3.wavecable.com (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id r9sm22711163pfi.114.2017.07.14.11.30.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jul 2017 11:30:34 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Fri, 14 Jul 2017 11:30:14 -0700 Message-Id: <20170714183027.16021-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170714183027.16021-1-stephen@networkplumber.org> References: <20170714183027.16021-1-stephen@networkplumber.org> Subject: [dpdk-dev] [RFC 01/14] ethdev: add link status read/write functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jul 2017 18:30:38 -0000 Many drivers are all doing copy/paste of the same code to atomicly update the link status. Reduce duplication, and allow for future changes by having common function for this. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.c | 36 ++++++++++++++++++++++++++++++++++++ lib/librte_ether/rte_ethdev.h | 28 ++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c index a1b744704f3a..7532fc6b65f0 100644 --- a/lib/librte_ether/rte_ethdev.c +++ b/lib/librte_ether/rte_ethdev.c @@ -1332,6 +1332,42 @@ rte_eth_link_get_nowait(uint8_t port_id, struct rte_eth_link *eth_link) } int +_rte_eth_link_update(struct rte_eth_dev *dev, + const struct rte_eth_link *link) +{ + volatile struct rte_eth_link *dev_link = &(dev->data->dev_link); + struct rte_eth_link old; + + RTE_BUILD_BUG_ON(sizeof(*link) != sizeof(uint64_t)); + + old = *dev_link; + + /* Only reason we use cmpset rather than set is + * that on some architecture may use sign bit as a flag value. + */ + while (rte_atomic64_cmpset((volatile uint64_t *)dev_link, + *(volatile uint64_t *)dev_link, + *(const uint64_t *)link) == 0) + continue; + + return (old.link_status == link->link_status) ? -1 : 0; +} + +void _rte_eth_link_read(struct rte_eth_dev *dev, + struct rte_eth_link *link) +{ + const uint64_t *src = (const uint64_t *)&(dev->data->dev_link); + volatile uint64_t *dst = (uint64_t *)link; + + RTE_BUILD_BUG_ON(sizeof(*link) != sizeof(uint64_t)); + + /* Note: this should never fail since both destination and expected + * values are the same and are a pointer from caller. + */ + rte_atomic64_cmpset(dst, *dst, *src); +} + +int rte_eth_stats_get(uint8_t port_id, struct rte_eth_stats *stats) { struct rte_eth_dev *dev; diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h index f6837278521c..974657933f23 100644 --- a/lib/librte_ether/rte_ethdev.h +++ b/lib/librte_ether/rte_ethdev.h @@ -2219,6 +2219,34 @@ void rte_eth_link_get(uint8_t port_id, struct rte_eth_link *link); */ void rte_eth_link_get_nowait(uint8_t port_id, struct rte_eth_link *link); + +/** + * @internal + * Atomically write the link status for the specific device. + * It is for use by DPDK device driver use only. + * User applications should not call it + * + * @param dev + * Pointer to struct rte_eth_dev. + * @param link + * New link status value. + * @return + * -1 if link state has changed, 0 if the same. + */ +int _rte_eth_link_update(struct rte_eth_dev *dev, + const struct rte_eth_link *link); + +/** + * @internal + * Atomically read the link speed and status. + * @param dev + * Pointer to struct rte_eth_dev. + * @param link + * link status value. + */ +void _rte_eth_link_read(struct rte_eth_dev *dev, + struct rte_eth_link *link); + /** * Retrieve the general I/O statistics of an Ethernet device. * -- 2.11.0