From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f172.google.com (mail-pf0-f172.google.com [209.85.192.172]) by dpdk.org (Postfix) with ESMTP id D598D47CD for ; Mon, 17 Jul 2017 18:02:32 +0200 (CEST) Received: by mail-pf0-f172.google.com with SMTP id q86so78529014pfl.3 for ; Mon, 17 Jul 2017 09:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sAfzCNw5rO/cs1wKW42wCb9jdGgymHWK1uZKu0eOGEM=; b=EDw37+T5D3xahXVcQI0yEAfjHlhYXPX6FW3tsAvYtFJzAJeHPQCgQl0vq+oJ7m9RZr 1gImFQyPc94XSF2oepzXAnq34CrhKAQsvOMAbTwOvfNzUaMGhF9TtWBwOtFsoVVNp2jv j42JHvPvaYuC7VxeYZLgammEaJXs+JT1Pd1Janv9WZBt4T3CrhhDcm5z9MQAdnRyfcBW X9YTk4yk4GTdpZcs/1aSoJhrEu09EFdXT1RtY+As8nj2cKhC/JpK6wXCXcJw6+xxkBEy rES9lQ7DQXvz9ef8Fbvo71vOOJ9neZCx71yifAM+XwqRM8Gj/nWeGpI6veFOL3DUIdxk Qfbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sAfzCNw5rO/cs1wKW42wCb9jdGgymHWK1uZKu0eOGEM=; b=l6gwTuA+2rDCEoyk5YfGMso1kdqpdF1/NHcuEUXkkr+Gc8H6fHYs5QEyvyekwDnrES QcTqWxK6HvA7XTmn3HFUZKklSOObvyVQV01Ygku19mIGQ9DyWe61wpn++J9Xk7i0C4Tf 1xfmajrA3gwVI5z/+6FoOISYeZToZLOQM2I33AgW/a1mKAadXuANkYw967pF+inu2tT2 LDChdtNX8RERWmd2Bi4a/76Kv8IPlqjOkWYahkkywBFB0JALg0MmrjSXM8hKw6bCdfqX rdvHn3qzeXOuwrxySYU5BN4ephTN0Wb25zGlqb1UjrbNaARdXbu4Tpeo8CpjfaCSYh1J m6qw== X-Gm-Message-State: AIVw110zmJjcnbmrFqm4Hq+6vHnUFnnDfzYF7dg1oq4pmI5gYEKgbV+0 k4o7hQYnC2TZgXm+r5xR8Q== X-Received: by 10.98.91.71 with SMTP id p68mr19343178pfb.209.1500307352056; Mon, 17 Jul 2017 09:02:32 -0700 (PDT) Received: from xeon-e3 (76-14-207-240.or.wavecable.com. [76.14.207.240]) by smtp.gmail.com with ESMTPSA id d89sm39334281pfl.7.2017.07.17.09.02.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Jul 2017 09:02:31 -0700 (PDT) Date: Mon, 17 Jul 2017 09:02:29 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Message-ID: <20170717090229.48abee36@xeon-e3> In-Reply-To: <60caca67-cfb9-c474-7fa9-faa7752fdaf1@solarflare.com> References: <20170714183027.16021-1-stephen@networkplumber.org> <20170714183027.16021-10-stephen@networkplumber.org> <60caca67-cfb9-c474-7fa9-faa7752fdaf1@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC 09/14] sfc: use new rte_eth_link helpers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jul 2017 16:02:33 -0000 On Sun, 16 Jul 2017 16:48:50 +0300 Andrew Rybchenko wrote: > On 07/14/2017 09:30 PM, Stephen Hemminger wrote: > > Use the new API (_rte_eth_link_update) to handle link status update. > > ALso fixes a bug where this driver was not returning -1 when link status changed. > > It is really good that you raise it, since: > - as far as I can see the return value of the link_update is never used > - return value is not described and it is unclear what is meant by "link > status changed" since initial point is unspecified > > We have interpreted link status change as change in data->dev_link > made in the current execution flow, but not in parallel execution flow. All drivers must do the same thing. Private interpretation is not good.