From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f181.google.com (mail-pf0-f181.google.com [209.85.192.181]) by dpdk.org (Postfix) with ESMTP id D3685376C for ; Tue, 18 Jul 2017 16:39:16 +0200 (CEST) Received: by mail-pf0-f181.google.com with SMTP id s70so3388951pfs.0 for ; Tue, 18 Jul 2017 07:39:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=a4+tLinD1+bpzDOShYsRPSXyNPUcxiTPiHn66lND0GA=; b=H54aC6fudhQ4C4TK2yNAsCfyAHnnNPY8FvGnoym4k9XsmNc1sweL9dPYCbNHN5YAvQ NOi4aifjR/4KtuW2VvUmFbm/9/pZrOaKXRC9+cVLqWVbg2TPSmwClGRLEHWPFTE6TlON YELLPXeoRLP3UI69OBQ/Leks3l01pBCoGS2JjPFI5fP4LW3rlLQ+26jbAEU0IqPBmgQZ 6pBYwtrnzi0qMEblmbji63En/15QNzLt/08/Qzy1XaSt7sZfutS9GFa12pua5yRaDyqS geI9N5AZ69/FnUvek+Vb0wlA9qzrYMFdXeOvDcFQ4gb/Bm0KDb3eeFGKrZorBqfjx/JS WBng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=a4+tLinD1+bpzDOShYsRPSXyNPUcxiTPiHn66lND0GA=; b=ByJxMVy6zgzur+RYj2bu4BR7JNGFaUZO3aD+NEWlH4nNx14ZoTdj/OUiW14pavzX7m +lmxN6mIZEd1QQ4ptMj8hB/HGZFzWnL7xY9Hk8grNbhwpTiPbmOX7s1h9G6B6n9aCVlL compUb4PdqrQpuJf52xCJMQa3luaR4V+6g3i0MLdx7QCT2qtzef/76MR6XOzs61qGRAX NzB0gyfJZF71cKUq1bew2SVXCvfAwkAUZ0/4eqqMO47q7kZ7unNf5urnq0RtYrhN6LX0 vI6F7ak4l05QZsp5ebBOdmLGLZD/tu+Uw4TSc3veEVaqfe1RF9NczXCDbYOp4NrZWP9v mQfw== X-Gm-Message-State: AIVw113BQKRT7Mf7eCgp0NVMqMRS1i4u8c1EPcQDl5uCPZ18UCQaW4Tu uuDIojxudOBSEfQ5 X-Received: by 10.84.140.235 with SMTP id 98mr2175190plt.26.1500388755950; Tue, 18 Jul 2017 07:39:15 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id k5sm6969959pfj.31.2017.07.18.07.39.13 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Jul 2017 07:39:14 -0700 (PDT) Date: Tue, 18 Jul 2017 22:39:07 +0800 From: Yuanhan Liu To: "De Lara Guarch, Pablo" Cc: Akhil Goyal , "dev@dpdk.org" , "stable@dpdk.org" , "hemant.agrawal@nxp.com" Message-ID: <20170718143907.GV11626@yliu-home> References: <20170718073356.14288-1-akhil.goyal@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH v2] crypto/dpaa2_sec: fix the return of supported API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Jul 2017 14:39:17 -0000 On Tue, Jul 18, 2017 at 10:26:39AM +0000, De Lara Guarch, Pablo wrote: > Hi Akhil, > > > -----Original Message----- > > From: Akhil Goyal [mailto:akhil.goyal@nxp.com] > > Sent: Tuesday, July 18, 2017 8:34 AM > > To: dev@dpdk.org; stable@dpdk.org > > Cc: hemant.agrawal@nxp.com; De Lara Guarch, Pablo > > ; yliu@fridaylinux.org; Akhil Goyal > > > > Subject: [PATCH v2] crypto/dpaa2_sec: fix the return of supported API > > > > call to dpaa2_sec_dev_configure() is made mandatory, but dpaa2_sec_pmd > > returns a ENOTSUP which results in device not getting configured. > > > > dpaa2_sec PMD does not need any further configuration to be done in > > dpaa2_sec_dev_configure, hence returning 0 > > > > Fixes: e5cbdfc53765 ("crypto/dpaa2_sec: add basic operations") > > > > Cc: stable@dpdk.org > > > > Signed-off-by: Akhil Goyal > > Looks ok to me, but this is only applicable in the stable branch, > so no need to send it to dev@dpdk.org. Why? We already have such fix in upstream? Normally, we just pick upstream commits (but not patches: the emails) to stable release. --yliu