From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id 068FE374C for ; Wed, 19 Jul 2017 13:08:52 +0200 (CEST) Received: by mail-pg0-f65.google.com with SMTP id z1so6552688pgs.0 for ; Wed, 19 Jul 2017 04:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=flK4axP9KdglKK3q2LKoInWLfYHjZxxjX7HGNDIOTYc=; b=JBKQ9rFcP+LVkVe6B8UwYlz0jc9tbdW+H/GeVflteHjzVtEEn82FpSBIpJP+vhSARY ZlWdo5sNHAexhS1MiQpjDkqylCTFkLy0DSlFi8UJWojpHYuz1ZPcxHf3IkC0JQgk3elM PFxdDvQCWdi1CPdmxdDmS1wJJ2fh6c+J3ut1h0vxeJJifPT0sa7p/840ajXlULbqvzqD EECGjCNyOYc0ADTetNgSKZc7JSC+VtBe8nQ3zewO7MMVfBBiq4WKFXzdToo2q+8UYzdf 6oiROCCl/kgv4i1uEBkMvSxiNsIfa+8jNJrbWSqs89FNmWGFAmi7j4PGZ3rJ+yU7rIfM 43RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=flK4axP9KdglKK3q2LKoInWLfYHjZxxjX7HGNDIOTYc=; b=kr7p+DbL3asLi/0ZQSdp9BVTZHVniaemBAu5twZdpaBNFSz8Ge5yG4GfnmNP1zDIsO QAeu7rTLSraJeUociinPQ1JhCOGfUrKtshKw4w+ZI5oMoJKDxsMfIeUX9kme26c5M/U+ Z01Irx6ovWU5BJZHlkgj8Z1CY0qNqVQODwHjvKtYNRI4VNt0100ob1pYZOfZx+31gPgb AuEq5EjCwIhF5wEICcAzONJ0DOVbW3v9uJ0i6BUQdWPxUexuiOr1tBIw0IW+XIS3scey /ej+SphhM6RS377RJzhHYk6v45PUAq136mcNw9AwmtHUfxupZUjhEvv7/+ZrX0hEYwt6 0TxQ== X-Gm-Message-State: AIVw110rUsI9poeLKWvhGZ7Cb34szdoSzIMd5g/x27QPDxESY+ZMHS5s BAQztVYmq+F3mh7Y X-Received: by 10.99.164.10 with SMTP id c10mr2390609pgf.163.1500462532076; Wed, 19 Jul 2017 04:08:52 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id v70sm11752376pfi.110.2017.07.19.04.08.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 19 Jul 2017 04:08:50 -0700 (PDT) Date: Wed, 19 Jul 2017 19:08:45 +0800 From: Yuanhan Liu To: Jiayu Hu , "Tan, Jianfeng" Cc: dev@dpdk.org, lei.a.yao@intel.com, stable@dpdk.org Message-ID: <20170719110845.GX11626@yliu-home> References: <1500434303-12975-1-git-send-email-jiayu.hu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500434303-12975-1-git-send-email-jiayu.hu@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix fail to configure rxq interrupt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 11:08:53 -0000 On Wed, Jul 19, 2017 at 11:18:23AM +0800, Jiayu Hu wrote: > When use rte_eth_dev_configure() to enable rx queue interrupt for virtio > devices, virtio_configure_intr() isn't called to set up the interrupt > environment, which causes rx queue interrupt setup failed. This patch is > to fix this issue. Hmm, how was this supposed to work in the begining when this feature was introduced? Jianfeng? --yliu > > Fixes: 26b683b4f7d0 ("net/virtio: setup Rx queue interrupts") > Cc: stable@dpdk.org > > Signed-off-by: Jiayu Hu > --- > drivers/net/virtio/virtio_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 00a3122..66656ed 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1688,6 +1688,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) > return -ENOTSUP; > } > > + if (dev->data->dev_conf.intr_conf.rxq) { > + if (virtio_configure_intr(dev) < 0) { > + PMD_DRV_LOG(ERR, "failed to configure interrupt"); > + return -ENOTSUP; > + } > + } > + > if (dev->data->dev_flags & RTE_ETH_DEV_INTR_LSC) > /* Enable vector (0) for Link State Intrerrupt */ > if (VTPCI_OPS(hw)->set_config_irq(hw, 0) == > -- > 2.7.4