From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 2FFF1231E for ; Thu, 20 Jul 2017 10:46:23 +0200 (CEST) Received: by mail-wr0-f181.google.com with SMTP id f21so11307824wrf.5 for ; Thu, 20 Jul 2017 01:46:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lkwXZfjGHCJB+wJWprUgUkPA5MlEPp9yZRLjGdKxWJE=; b=roy/e2iSdS5pFnbHOn0PFB8f28xzRm6okvQQWkKSxRPPnOOZzc43151Fxlvj5jaMvG 87tDoyQzm7W5kD31jFrlg/7rAf46ghlJx+EEanAmCqS6FUfGhK6Hh1ECyIgWpJ99rYpg zy5WiOU0D0af8UsYgHoS0wKFEQ991Npnt0iEZ69NenQkzgF0Fo2ckTY3burGyezV2fJK 5XWH+q0efddRMiA5RFjehxlCHQHNnryE/lPFcOhyrw+Zx3GBBMXDzSyA0gfR2nJyW6S3 hTahsJry2XW/JeYhfjTiT5AfWbkIBI/sC6Sm7haCprzq65G6d1gC38z+V4ERcmFpPTaB j6Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lkwXZfjGHCJB+wJWprUgUkPA5MlEPp9yZRLjGdKxWJE=; b=MT20pWju+GuXWmKWR6O5DJd5mA0dB3x+6zt7zUrmORrBfMFxucXFZFDBnY20NsnF6P cm4couQreOhgmCkroqyQWHsOAxvpE75KClzriPAeJwZ4ocM+6PBQ9xamSkbHTFRpWvGW novGWT0+okLo0RS7O5mnjSYuyyF9u6KIWOESERbUzVsB+uHQ2d+0uwDLADBrP6aMbzIw qdZqk1odR3rB2Q9RFjZDHCU7NXGeqPkiFyZBIYu3i8HyJ0R9eulxkUkoN5vBZSrkuOe/ 8QmyCNFA0LUfbW7hNFm0+vVlHBgDRF7T9XQ1KYyg0OVCADoH0vhoGROHrEvtrMe/XkfU 1tcw== X-Gm-Message-State: AIVw111tvI/AkEAwRIkx8gmOUHwfy36plegAnxyximXYRO+IXmrq2tIN Q6AiTy4NCoe9E99r X-Received: by 10.223.169.41 with SMTP id u38mr2560589wrc.286.1500540382866; Thu, 20 Jul 2017 01:46:22 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id t62sm1604868wmb.24.2017.07.20.01.46.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jul 2017 01:46:22 -0700 (PDT) Date: Thu, 20 Jul 2017 10:46:19 +0200 From: Olivier Matz To: Santosh Shukla Cc: dev@dpdk.org, thomas.monjalon@6wind.com, jerin.jacob@caviumnetworks.com Message-ID: <20170720104619.06a5921f@platinum> In-Reply-To: <20170713091231.13314-1-santosh.shukla@caviumnetworks.com> References: <20170713091231.13314-1-santosh.shukla@caviumnetworks.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] mempool: add notice to change mempool API/ABI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jul 2017 08:46:23 -0000 On Thu, 13 Jul 2017 09:12:31 +0000, Santosh Shukla wrote: > [PATCH] mempool: add notice to change mempool API/ABI I think the usual titles for these notices are more: doc: announce API/ABI changes for mempool Ideally, the title should describe more precisely the kind of changes. In that particular case, it looks quite difficult, so just saying "mempool" looks okay. Maybe Thomas will prefer one entry per change, I don't know. > An API/ABI change is planned for 17.11 to change following > > * Remove unused flag param from rte_mempool_generic_get and _put. > * Change data type for mempool 'flag' from int to unsigned int. > Refer [1]. > * Add struct rte_mempool * param into func rte_mempool_xmem_size, > rte_mempool_xmem_usage to make it mempool aware. > Refer [2]. > > [1] http://dpdk.org/dev/patchwork/patch/25603/ > [2] http://dpdk.org/dev/patchwork/patch/25605/ > > Signed-off-by: Santosh Shukla > --- > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 257dcba32..7abb30f5f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -64,3 +64,11 @@ Deprecation Notices > be removed in 17.11: > > - ``rte_eal_parse_devargs_str``, replaced by ``rte_eal_devargs_parse`` > + > +* mempool: The following will be modified in 17.11: I think an empty line is required here, else the generated pdf will be incorrect. > + - ``rte_mempool_xmem_size`` and ``rte_mempool_xmem_usage`` need to know > + the mempool flag status so adding new param rte_mempool in those API. > + - Removing __rte_unused int flag param from ``rte_mempool_generic_put`` > + and ``rte_mempool_generic_get`` API. > + - ``rte_mempool`` flags data type will changed from int to > + unsigned int.