From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 71DB81F5 for ; Mon, 24 Jul 2017 17:07:12 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id m85so20087256wma.1 for ; Mon, 24 Jul 2017 08:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+OJlVdpC6oJ+xR0wnGhKEcgPz/ZbK1Vbz3r5U4AHAnQ=; b=Sc8OvlrZReQVm/RV45Ap72mmMyHC2uPkQxNtGj/raJdaYMt6GVQFs9pBfaycuyLSzb fcP1kk2WNn91zJZ4Mk17e2hpq6Aq2rgq9yXhuym6btiaDmEpM/Dt8MdWHkBRScnyA756 Bi5TkyQUHGzcFQoFm0Ot4x62WR6tJWGbOML8cakrsC0k9f3hsSru5Nwx0bbQ2UNDWrAS RqqZ9cnJrKmIio+Y087GbNrdA7DzOZ+MwSTQoXnzCmLVlTKT0yKBtzepFjuvkZRNQ6Mo QJbr0KofTavHbkYlG2luWhinZTd+0fPyixpDGOlYYKLS4RNLRTusWFeWpE8exZ8wcXTp QLwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+OJlVdpC6oJ+xR0wnGhKEcgPz/ZbK1Vbz3r5U4AHAnQ=; b=t2Yalh29groZaqs3ueNKhVhfcx4UCMhJoH3oMKhLSMOqyFkrBQ5OasVnYHsO0S1hbF YUAiuF7fIZwN6yOMzF43FGN2sU+0s/8Zjh+gJJVp/mbd9tZH6HFzJVhRT+HvUAV8six/ oi0uHVklfLr8qqBbTFRpV7TV7flKh2COwVAphQc4kn1CkJBcRBz46CjTDeDirwpPsVQV NlxGkCD3iqZ0g/2j4IESaRGZpLDpmkSXcWJBUoUI/GoBPF9FpJL+2wPSCFlQrsMowxpu CWKJ6rfvfX69whJltqdQ2P+1Cj1Y9xroZnsv+lQdd1HjHow6U4DdvWKfgYNMGiM5w7fc 9zHQ== X-Gm-Message-State: AIVw110UKT0xf+LHkNfmWuB0sIlDIE4fkhYTnYI9E20C0iUmmTkUZeks fTDbb+ZKU/RScPbS9H4= X-Received: by 10.28.13.138 with SMTP id 132mr5083185wmn.23.1500908832084; Mon, 24 Jul 2017 08:07:12 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o99sm10679582wrb.76.2017.07.24.08.07.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Jul 2017 08:07:11 -0700 (PDT) Date: Mon, 24 Jul 2017 17:07:03 +0200 From: Adrien Mazarguil To: Harry van Haaren Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20170724150703.GD19852@6wind.com> References: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1499866732-17085-1-git-send-email-harry.van.haaren@intel.com> Subject: Re: [dpdk-dev] [PATCH] doc: add author on cc to git fixline alias X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jul 2017 15:07:12 -0000 On Wed, Jul 12, 2017 at 02:38:52PM +0100, Harry van Haaren wrote: > With this commit, the correct method to use git fixline to indicate > a fix of a previous commit has changed. The new rules require the > author of the original code that is being fixed to be on CC. > > The logic behind this improvement is that if there is a genuine bug, > one of the ideal people to review is the author of the original code > being fixed. Adding them on Cc makes them aware of the patch, avoiding > it from being passed by accidentally while reading the mailing-list. > > Given that the original author (now on Cc:) might not actually review, > there is no value in keeping the Cc: in git commit history. If the > original author performs a review, their Reviewed-by: or Acked-by: is > stored in git history (same as now). > > Signed-off-by: Harry van Haaren Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND