* [dpdk-dev] [PATCH] net/mlx5: fix counting consumed Tx descriptors
@ 2017-07-25 16:42 Yongseok Koh
2017-07-31 16:19 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2017-07-25 16:42 UTC (permalink / raw)
To: adrien.mazarguil, nelio.laranjeiro; +Cc: dev, Yongseok Koh
When advancing Tx ring index (txq->wqe_ci) in txq_scatter_v(), the title
descriptor of multi-packet send isn't taken into account if it doesn't
cross 64B boundary.
Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
index 95e96baa2..0a65502fb 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c
@@ -288,8 +288,7 @@ txq_scatter_v(struct txq *txq, struct rte_mbuf **pkts, uint16_t pkts_n)
(*txq->elts)[elts_head++ & elts_m] = buf;
buf = buf->next;
} while (--segs_n);
- if (ds % nb_dword_per_wqebb)
- ++wqe_ci;
+ ++wqe_ci;
/* Fill CTRL in the header. */
ctrl = _mm_set_epi32(0, 0, txq->qp_num_8s | ds,
MLX5_OPC_MOD_MPW << 24 |
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix counting consumed Tx descriptors
2017-07-25 16:42 [dpdk-dev] [PATCH] net/mlx5: fix counting consumed Tx descriptors Yongseok Koh
@ 2017-07-31 16:19 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2017-07-31 16:19 UTC (permalink / raw)
To: Yongseok Koh, adrien.mazarguil, nelio.laranjeiro; +Cc: dev
On 7/25/2017 5:42 PM, Yongseok Koh wrote:
> When advancing Tx ring index (txq->wqe_ci) in txq_scatter_v(), the title
> descriptor of multi-packet send isn't taken into account if it doesn't
> cross 64B boundary.
>
> Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86")
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-31 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-25 16:42 [dpdk-dev] [PATCH] net/mlx5: fix counting consumed Tx descriptors Yongseok Koh
2017-07-31 16:19 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).