From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 08D429173 for ; Fri, 28 Jul 2017 11:28:04 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jul 2017 02:28:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,425,1496127600"; d="scan'208";a="883713534" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.72]) by FMSMGA003.fm.intel.com with SMTP; 28 Jul 2017 02:28:01 -0700 Received: by (sSMTP sendmail emulation); Fri, 28 Jul 2017 10:28:00 +0100 Date: Fri, 28 Jul 2017 10:28:00 +0100 From: Bruce Richardson To: asomers@gmail.com Cc: dev@dpdk.org Message-ID: <20170728092800.GA24312@bricha3-MOBL3.ger.corp.intel.com> References: <20170727204146.9574-1-asomers@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727204146.9574-1-asomers@gmail.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jul 2017 09:28:05 -0000 On Thu, Jul 27, 2017 at 02:41:46PM -0600, asomers@gmail.com wrote: > From: Alan Somers > > "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > > Signed-off-by: Alan Somers > --- > examples/performance-thread/l3fwd-thread/test.sh | 2 +- > usertools/dpdk-setup.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/performance-thread/l3fwd-thread/test.sh b/examples/performance-thread/l3fwd-thread/test.sh > index b7718b622..eb1fe2dc2 100755 > --- a/examples/performance-thread/l3fwd-thread/test.sh > +++ b/examples/performance-thread/l3fwd-thread/test.sh > @@ -1,4 +1,4 @@ > -#!/bin/bash > +#!/usr/bin/env bash > > case "$1" in > This script doesn't look to be using any bash specific features to me, so a better fix might be to change it to use /bin/sh rather than requiring bash itself. [Needs testing, to check there isn't something bash-specific hidden away, obviously] > diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh > index c4fec5a63..ebf36f830 100755 > --- a/usertools/dpdk-setup.sh > +++ b/usertools/dpdk-setup.sh > @@ -1,4 +1,4 @@ > -#! /bin/bash > +#! /usr/bin/env bash > > # BSD LICENSE > # > -- Not sure having this linux-specific is a problem for dpdk-setup.sh, since I don't think large parts of that script work with BSD anyway, e.g. it assumes a linux hugetlbfs filesystem for hugepage setup. Not that there is any harm in making the change you suggest either. /Bruce