DPDK patches and discussions
 help / color / mirror / Atom feed
From: Yuanhan Liu <yliu@fridaylinux.org>
To: Jianfeng Tan <jianfeng.tan@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org,
	Zhihong Wang <zhihong.wang@intel.com>,
	Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix MAC addr not correct read
Date: Mon, 31 Jul 2017 10:31:03 +0800	[thread overview]
Message-ID: <20170731023103.GB9612@yliu-home> (raw)
In-Reply-To: <1501282874-127700-1-git-send-email-jianfeng.tan@intel.com>

On Fri, Jul 28, 2017 at 11:01:14PM +0000, Jianfeng Tan wrote:
> When virtio-net devices are bound to uio_pci_generic, we get
> the wrong mac addr by virtio PMD. The wrong mac addr is a
> addr that is 4-byte left shift of the correct addr.
> 
> It's a regression bug introduced by the cleanup patch below.
> The condition of if we set use_msix should be if msix is
> actually enabled. Only to check if there is a capability list
> is not enough. For example, binding a transitional device
> to uio_pci_device would trigger the wrong assignment of use_msix.
> 
> To correct that, we also check the flags of msix capability to
> make sure it's enabled.
> 
> Fixes: ee1843bd8907 ("net/virtio: remove redundant MSI-X detection")
> Cc: stable@dpdk.org
> Cc: Zhihong Wang <zhihong.wang@intel.com>
> Cc: Yuanhan Liu <yliu@fridaylinux.org>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu

      reply	other threads:[~2017-07-31  2:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 23:01 Jianfeng Tan
2017-07-31  2:31 ` Yuanhan Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170731023103.GB9612@yliu-home \
    --to=yliu@fridaylinux.org \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).