[dpdk-dev] [PATCH] net/virtio: fix MAC addr not correct read

[dpdk-dev] [PATCH] net/virtio: fix MAC addr not correct read

[Jianfeng Tan]

When virtio-net devices are bound to uio_pci_generic, we get
the wrong mac addr by virtio PMD. The wrong mac addr is a
addr that is 4-byte left shift of the correct addr.

It's a regression bug introduced by the cleanup patch below.
The condition of if we set use_msix should be if msix is
actually enabled. Only to check if there is a capability list
is not enough. For example, binding a transitional device
to uio_pci_device would trigger the wrong assignment of use_msix.

To correct that, we also check the flags of msix capability to
make sure it's enabled.

Fixes: ee1843bd8907 ("net/virtio: remove redundant MSI-X detection")
Cc: stable@dpdk.org
Cc: Zhihong Wang <zhihong.wang@intel.com>
Cc: Yuanhan Liu <yliu@fridaylinux.org>
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>

Reported-by: Vipin Varghese <vipin.varghese@intel.com>
Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
---
 drivers/net/virtio/virtio_pci.c | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio/virtio_pci.c b/drivers/net/virtio/virtio_pci.c
index e6eda75..e6da680 100644
--- a/drivers/net/virtio/virtio_pci.c
+++ b/drivers/net/virtio/virtio_pci.c
@@ -580,6 +580,8 @@ get_cfg_addr(struct rte_pci_device *dev, struct virtio_pci_cap *cap)
 	return base + offset;
 }
 
+#define PCI_MSIX_ENABLE 0x8000
+
 static int
 virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)
 {
@@ -606,8 +608,17 @@ virtio_read_caps(struct rte_pci_device *dev, struct virtio_hw *hw)
 			break;
 		}
 
-		if (cap.cap_vndr == PCI_CAP_ID_MSIX)
-			hw->use_msix = 1;
+		if (cap.cap_vndr == PCI_CAP_ID_MSIX) {
+			/* Transitional devices would also have this capability,
+			 * that's why we also check if msix is enabled.
+			 * 1st byte is cap ID; 2nd byte is the position of next
+			 * cap; next two bytes are the flags.
+			 */
+			uint16_t flags = ((uint16_t *)&cap)[1];
+
+			if (flags & PCI_MSIX_ENABLE)
+				hw->use_msix = 1;
+		}
 
 		if (cap.cap_vndr != PCI_CAP_ID_VNDR) {
 			PMD_INIT_LOG(DEBUG,
-- 
2.7.4

Re: [dpdk-dev] [PATCH] net/virtio: fix MAC addr not correct read

[Yuanhan Liu]

On Fri, Jul 28, 2017 at 11:01:14PM +0000, Jianfeng Tan wrote:
> When virtio-net devices are bound to uio_pci_generic, we get
> the wrong mac addr by virtio PMD. The wrong mac addr is a
> addr that is 4-byte left shift of the correct addr.
> 
> It's a regression bug introduced by the cleanup patch below.
> The condition of if we set use_msix should be if msix is
> actually enabled. Only to check if there is a capability list
> is not enough. For example, binding a transitional device
> to uio_pci_device would trigger the wrong assignment of use_msix.
> 
> To correct that, we also check the flags of msix capability to
> make sure it's enabled.
> 
> Fixes: ee1843bd8907 ("net/virtio: remove redundant MSI-X detection")
> Cc: stable@dpdk.org
> Cc: Zhihong Wang <zhihong.wang@intel.com>
> Cc: Yuanhan Liu <yliu@fridaylinux.org>
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>

Applied to dpdk-next-virtio.

Thanks.

	--yliu