From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com (mail-pg0-f68.google.com [74.125.83.68]) by dpdk.org (Postfix) with ESMTP id 8AD8E99C9 for ; Mon, 31 Jul 2017 04:31:10 +0200 (CEST) Received: by mail-pg0-f68.google.com with SMTP id y129so29168051pgy.3 for ; Sun, 30 Jul 2017 19:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fridaylinux-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+19aoyYxMC/FlzWsO23hW8+BbZtM6zVTUBzYOCGE45M=; b=xgOlg1Kk7WKd/kXEd5j+GCZ80/R1WJC8omYqeN1UG0Oda40y8dSiT99OZTPdf4u7k+ ljIwlKm1QPv/Th3oN/k60dmgpI5/NT4R6xXqZ7oOCXwnDeg98fg3ipyMcXlCSW4mzxgh BseKAC4W6jZyDXWbFq4Jm0DRPQPlfS1fgXQ2If5YR1aWj6JYJ+BwQ0mNYIwnx0Auc8uL 1C1gKruLJBZ+94/QWxq3Aq4mTdreXQapmx6feMQuo7albriTd1RETYwEHJxijned786c bUaW5KS/56+bL7yzi1PWKQxCRMBvJW0f1C6ZFbSd2YYt5dZu5b9W9u3owhmrMXJkWp43 Erdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+19aoyYxMC/FlzWsO23hW8+BbZtM6zVTUBzYOCGE45M=; b=FHiFSurzuUTD5HGnDrGjNL5eHkiYwVQTUtAp0CIUhz3kC/cc1bN5ZHiF45QDAhWYxP P09yIUuh6PHov08TDvZg9N2ysurjtuBd0aU9VEeM2mHntTpgjpagYaqQpmkezkZT376Z W4vcAJwap73bkpTc9+Bj6zPeLOcm6dlN40K3+pcyp7eXtHrP2F9wl7FxyI2Mq7zbwMu1 zo4TgFQYN7+lwSAJcFCW2YW5myzc2o018XCJwG3vwp9O7dGnIByPbckQtJGSJ8HQoVHv tFZs8Q3csJwwUkj1rUvCCqhl/YzWXecvWIQEdUHndUskjyC+7H0EFpPdXuP8YE5d6WqK C1hA== X-Gm-Message-State: AIVw112Jkr3fDMwEQjcyZZlt2giZo4I+aq7LiubfeMAneW0ETNwxjEk3 cqvO3VAhBABeFiAbIb9R5Q== X-Received: by 10.98.18.131 with SMTP id 3mr13933286pfs.19.1501468269806; Sun, 30 Jul 2017 19:31:09 -0700 (PDT) Received: from yliu-home ([45.63.61.64]) by smtp.gmail.com with ESMTPSA id y189sm49207771pfg.44.2017.07.30.19.31.07 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 30 Jul 2017 19:31:08 -0700 (PDT) Date: Mon, 31 Jul 2017 10:31:03 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, stable@dpdk.org, Zhihong Wang , Maxime Coquelin Message-ID: <20170731023103.GB9612@yliu-home> References: <1501282874-127700-1-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501282874-127700-1-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [dpdk-dev] [PATCH] net/virtio: fix MAC addr not correct read X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 02:31:10 -0000 On Fri, Jul 28, 2017 at 11:01:14PM +0000, Jianfeng Tan wrote: > When virtio-net devices are bound to uio_pci_generic, we get > the wrong mac addr by virtio PMD. The wrong mac addr is a > addr that is 4-byte left shift of the correct addr. > > It's a regression bug introduced by the cleanup patch below. > The condition of if we set use_msix should be if msix is > actually enabled. Only to check if there is a capability list > is not enough. For example, binding a transitional device > to uio_pci_device would trigger the wrong assignment of use_msix. > > To correct that, we also check the flags of msix capability to > make sure it's enabled. > > Fixes: ee1843bd8907 ("net/virtio: remove redundant MSI-X detection") > Cc: stable@dpdk.org > Cc: Zhihong Wang > Cc: Yuanhan Liu > Cc: Maxime Coquelin > > Reported-by: Vipin Varghese > Signed-off-by: Jianfeng Tan Applied to dpdk-next-virtio. Thanks. --yliu