From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 5F2F199A1 for ; Mon, 31 Jul 2017 10:57:37 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id t201so43000902wmt.0 for ; Mon, 31 Jul 2017 01:57:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DZfEZaalP7dp4mp/C+XzTvgG1jle5+L7TNi83lBinV8=; b=Y43YoU/ZmEzBCZvWtATYmfxRYh/E/F7d5PClIf9pQe2kcAhooJAV5MHFezezE15y+M /bVOvcfo/PKCYE4u/Spbffuajq7hHyC8bdarq9LJt8FPDFsJiyY4J+g4ySv3EyrprtuQ DQoaoVqU0kCtMXixeKO4P6uWEzEU9lUQk2bjg/A4NCkgtt7VlsGzDKi1pfSyPufo3gt8 u80YasBDthFBL/8NV8BAbk8M0XSJMCSzpUwVpI9+NvfVb7QJ1KR9yD77kizPrb+Saxne oR8YTf3Q+oPu9xI3S71JLbXSviEKFab2vn4OE6y0Q0U28niFEEMsF3OSaXnxIE5KjOLe s1+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DZfEZaalP7dp4mp/C+XzTvgG1jle5+L7TNi83lBinV8=; b=Ndowkp6+fMFnjCLpaNRm4GlfikMZNGeb0nE9LaFEziod4VQnYGPFo9ZzBKlnPHHlPO eyT5UXIDwAzYD2kUsf5TJmfpoYhbS5ahx1Ulaivc2iid79OXJ42SH8w/b0GHHyGTKN9K g2poAHmOlc2WBOo/mwLgAtDAFnoTWY16Oze/WQSRfq/11fz66yqug1DuFiGKIS9CEj5U Mm+WA93nvEQZ7Lzx6Uikf/EKbdHE46u88+Ik3DiISx97zc84KQlGQvnMLNtJHIzdGeYC 00tKf62Egj7Ani9pcy0sdt+e0TULRlijY0RHG0fyP3ilXf8540Z3AUwcchSplgkLlgZh BHSA== X-Gm-Message-State: AIVw112wDHDqrJ/+o+IFl5Ykhu7iDCNJwNJgu2u8xgKgdjISBeHFXEv1 A82Xl7nvQGWA3hke X-Received: by 10.28.7.213 with SMTP id 204mr1443495wmh.113.1501491456820; Mon, 31 Jul 2017 01:57:36 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id o30sm18992838wrb.76.2017.07.31.01.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Jul 2017 01:57:35 -0700 (PDT) Date: Mon, 31 Jul 2017 10:57:27 +0200 From: Adrien Mazarguil To: Gaetan Rivet Cc: dev@dpdk.org, Thomas Monjalon , Shachar Beiser , Nelio Laranjeiro Message-ID: <20170731085727.GM19852@6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v2 0/6] fix ethdev device detach X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 08:57:37 -0000 On Wed, Jul 26, 2017 at 03:35:51PM +0200, Gaetan Rivet wrote: > Device detach in librte_ether is rough right now. > > - Device hotplug capability is not properly checked > - Device state should be set after a successful detach > - MLX drivers are lacking the relevant flag > - And this flag should actually be removed, thus occuring an API change > for v17.11. An announce follows. > > Without this series on an MLX4 port: > > testpmd> port close 0 > Closing ports... > Port 0 is now not stopped > Done > testpmd> port stop 0 > Stopping ports... > Checking link statuses... > Done > testpmd> port close 0 > Closing ports... > Done > testpmd> port detach 0 > Detaching a port... > testpmd> show port info 0 > Segmentation fault (core dumped) > > With this series: > > testpmd> port stop 0 > Stopping ports... > Checking link statuses... > Done > testpmd> port detach 0 > Detaching a port... > Please close port first > testpmd> port close 0 > Closing ports... > Done > testpmd> port detach 0 > Detaching a port... > Port '00:03.0' is detached. Now total ports is 0 > Done > testpmd> show port info 0 > Invalid port 0 > Valid port range is [0] > > v2: > > - remove coredump from patchset > > Gaetan Rivet (6): > ethdev: fix device state on detach > ethdev: properly check detach capability > net/mlx4: advertize the detach capability > net/mlx5: advertize the detach capability > app/testpmd: let the user know device detach failed > doc: announce ethdev API change for detach flag > > app/test-pmd/testpmd.c | 9 ++++++--- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > drivers/net/mlx4/mlx4.c | 1 + > drivers/net/mlx5/mlx5.c | 1 + > lib/librte_ether/rte_ethdev.c | 11 +---------- > 5 files changed, 15 insertions(+), 13 deletions(-) > > -- > 2.1.4 > Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND