From: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code
Date: Mon, 31 Jul 2017 16:42:58 +0200 [thread overview]
Message-ID: <20170731144258.GM11154@bidouze.vm.6wind.com> (raw)
In-Reply-To: <20170728081014.48104-1-zhiyong.yang@intel.com>
Hi Zhiyong,
On Fri, Jul 28, 2017 at 04:10:14PM +0800, Zhiyong Yang wrote:
> The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code
> in the function rte_eth_copy_pci_info(), remove it here.
>
> Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> lib/librte_ether/rte_ethdev_pci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h
> index c3f7f721c..fe2e0f64c 100644
> --- a/lib/librte_ether/rte_ethdev_pci.h
> +++ b/lib/librte_ether/rte_ethdev_pci.h
> @@ -117,7 +117,6 @@ rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size)
> }
>
> eth_dev->device = &dev->device;
> - eth_dev->intr_handle = &dev->intr_handle;
> rte_eth_copy_pci_info(eth_dev, dev);
> return eth_dev;
> }
> --
> 2.13.3
>
--
Gaëtan Rivet
6WIND
next prev parent reply other threads:[~2017-07-31 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 8:10 Zhiyong Yang
2017-07-31 14:42 ` Gaëtan Rivet [this message]
2017-07-31 15:04 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170731144258.GM11154@bidouze.vm.6wind.com \
--to=gaetan.rivet@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).