From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id C425A58CB for ; Mon, 31 Jul 2017 16:43:08 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id v105so149959426wrb.0 for ; Mon, 31 Jul 2017 07:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=PRHlAacEfmQ0BSNJBlSdJ7ffpbENLv1AiaaQXYwZjW4=; b=SSEPPbhTPZuieF4v22a5BDMKYLkvvBY4tojunCt6p2Y7tXgW76p31W5YeOJ2jzU3xp JxPGskiHsk/SSrZ1NBfmc/MRBwV3pHLDD7eDjX0EpwYkTgJwJ0FWf1z6sr2yTmQkdbIg yLjgcGYM2q3dCXtddW462NO9jSdKF4pIyRxJcJ+2pUqeNvcxqyx0fhxof/P8rSkqGgzi WP3o8Xc1mEr8s+AkAfEThEsRBt3KBvZywRnBuljgubGfckMmMBxijkrryRTzgJLVCVJ2 8YHR2wvrWX9A+chHDJg2cqFysihfuSNCVnZAnsLfgLdhSbOsi3G3U44G+p4T6kMPyiW3 EwQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=PRHlAacEfmQ0BSNJBlSdJ7ffpbENLv1AiaaQXYwZjW4=; b=liK6+1m1aVYGR9pub6n9hNmPnaLNR2ZYgy012S4NSYD1kmNf1ySfHv0t9wd2zWdTSA iNCyT37ahO7H5H3AE42aJaPrt6let9VRteGIFgvc9WlTrmAz2gYe8+ALT2XuA2TbSRgB R5ejEhyq1hZ6a/D+nenaLy10UtG5NXCk1XLDhlLEU2E/myophl3HHcLPNMJyaj0KHW8H heXT4/JY/z0oovwZh2/hhwv1fl9gaJXcZHJ8rqpqFp/CXLx0ckP8EmqSPqyXMi5YPlOu J09XetfZvW46zzzxPMiXv/PiegCSDXjrHkkp2TQ8xXTyePrNfsyUZ/srevoZsYFxopGn UZhw== X-Gm-Message-State: AIVw112awX7P3bEfEXNdOgwELs4cNcgnP2TiaUN3Z7S2u/PEJKElxBnG RLBR+8gcOUSeHbWA X-Received: by 10.223.130.137 with SMTP id 9mr12634547wrc.0.1501512188200; Mon, 31 Jul 2017 07:43:08 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id u11sm10561920wma.22.2017.07.31.07.43.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 31 Jul 2017 07:43:07 -0700 (PDT) Date: Mon, 31 Jul 2017 16:42:58 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Zhiyong Yang Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20170731144258.GM11154@bidouze.vm.6wind.com> References: <20170728081014.48104-1-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170728081014.48104-1-zhiyong.yang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] lib/librte_ether: remove the repeat code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 14:43:09 -0000 Hi Zhiyong, On Fri, Jul 28, 2017 at 04:10:14PM +0800, Zhiyong Yang wrote: > The code eth_dev->intr_handle = &dev->intr_handle; has duplicate code > in the function rte_eth_copy_pci_info(), remove it here. > > Signed-off-by: Zhiyong Yang Acked-by: Gaetan Rivet > --- > lib/librte_ether/rte_ethdev_pci.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/lib/librte_ether/rte_ethdev_pci.h b/lib/librte_ether/rte_ethdev_pci.h > index c3f7f721c..fe2e0f64c 100644 > --- a/lib/librte_ether/rte_ethdev_pci.h > +++ b/lib/librte_ether/rte_ethdev_pci.h > @@ -117,7 +117,6 @@ rte_eth_dev_pci_allocate(struct rte_pci_device *dev, size_t private_data_size) > } > > eth_dev->device = &dev->device; > - eth_dev->intr_handle = &dev->intr_handle; > rte_eth_copy_pci_info(eth_dev, dev); > return eth_dev; > } > -- > 2.13.3 > -- Gaëtan Rivet 6WIND