From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id CAD422BB0 for ; Mon, 31 Jul 2017 17:22:20 +0200 (CEST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2017 08:22:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,442,1496127600"; d="scan'208";a="131565333" Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.13.127]) by orsmga005.jf.intel.com with SMTP; 31 Jul 2017 08:22:17 -0700 Received: by (sSMTP sendmail emulation); Mon, 31 Jul 2017 16:22:16 +0100 Date: Mon, 31 Jul 2017 16:22:16 +0100 From: Bruce Richardson To: alan somers Cc: dev@dpdk.org Message-ID: <20170731152216.GA33288@bricha3-MOBL3.ger.corp.intel.com> References: <20170727204146.9574-1-asomers@gmail.com> <20170728092800.GA24312@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] Fix bash path in shebangs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Jul 2017 15:22:21 -0000 On Mon, Jul 31, 2017 at 09:11:11AM -0600, alan somers wrote: > On Fri, Jul 28, 2017 at 3:28 AM, Bruce Richardson > wrote: > > On Thu, Jul 27, 2017 at 02:41:46PM -0600, asomers@gmail.com wrote: > >> From: Alan Somers > >> > >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > >> > >> Signed-off-by: Alan Somers > >> --- > >> examples/performance-thread/l3fwd-thread/test.sh | 2 +- > >> usertools/dpdk-setup.sh | 2 +- > >> 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/examples/performance-thread/l3fwd-thread/test.sh b/examples/performance-thread/l3fwd-thread/test.sh > >> index b7718b622..eb1fe2dc2 100755 > >> --- a/examples/performance-thread/l3fwd-thread/test.sh > >> +++ b/examples/performance-thread/l3fwd-thread/test.sh > >> @@ -1,4 +1,4 @@ > >> -#!/bin/bash > >> +#!/usr/bin/env bash > >> > >> case "$1" in > >> > > This script doesn't look to be using any bash specific features to me, > > so a better fix might be to change it to use /bin/sh rather than > > requiring bash itself. [Needs testing, to check there isn't something > > bash-specific hidden away, obviously] > > True. Unfortunately, I can't test it right now because I can't get > DPDK to build on either Linux or FreeBSD, and I'm out of time to debug > the build failures for now. Would you like me to resubmit the patch, > altered to use /bin/sh, without testing? > > > I'm not sure it's that important a change that we need to rush into doing so. What difficulties are you having getting DPDK to build? Is it just platform setup issues? /Bruce