From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <sluong99@gmail.com>
Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com
[209.85.192.194]) by dpdk.org (Postfix) with ESMTP id C27D190F3
for <dev@dpdk.org>; Tue, 1 Aug 2017 18:17:36 +0200 (CEST)
Received: by mail-pf0-f194.google.com with SMTP id c65so2891074pfl.0
for <dev@dpdk.org>; Tue, 01 Aug 2017 09:17:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=from:to:cc:subject:date:message-id;
bh=EoJtRJ3tl5FCpj58mNw2fwzUaYoE0w5qvXBGmuq4Otw=;
b=e40qva9qPwmQOI7hwSAKzsB5PF947gX+WajFsEKKF0dd2HMjY2q/P/u86gILqBboVF
5iNJxD9BveXLIIHbR6nKnHE+kFAiAIxuf731kdyACQc/XKRrOmX2vlztvXfD4D8iocOK
QVUzSTy0XMp8XuONjnPKm/499Fy0+3vtfu+PDBLvp53DylIuGTOnbGvteqLeWL4HXXmc
o/S2nMl15GOYMpnNYaItSYPUu/j5EbLm0z22WRDfVk3ZO/LHgNHhSaMQ5rzQkK5vo4YE
FdtNq1H+2+0enOSTI5AvY/oeGO+ilpZkspAjK5c4iRPf3A6+n7zeKQr/H8OgazuySZdH
wa8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:cc:subject:date:message-id;
bh=EoJtRJ3tl5FCpj58mNw2fwzUaYoE0w5qvXBGmuq4Otw=;
b=I97oatKO6Pk/xbNCUxvqrEszY0hlbOcFGCKYaFeQS5iYnnSBTwpmG/sE2esPznOUpV
2rkMl+AfOhPniqtcrZLn2RS7EpDNk1TGxmHxrdCTLE8UfYedfYL70h2OnvqXH75SqeFl
2NCFgrW7ROXjYx5oejzsT7ZYrW0X8UlxWvRU62IBXo2N80VZnnVm8/3v3/HtsdWyh0SG
6t+cwDQIrknlUHQU3C0bl3kTbl9YFoEdgWkEgHL5Fe99cuflhrsjRlnN4ye7TDcKVpd/
TEPd2G8ggQUlFY46EGf9xruHRlaGYyga/l21sZoxjxELqJ8BlsO3a+f/kEWd7A/2dSQG
y+Cw==
X-Gm-Message-State: AIVw111WeJlvqPSBWd/FQ2if6BoeRX6WxR0e+wTTBPQRybI1GTdckmXB
LHDWGY7CvI4m3w==
X-Received: by 10.99.51.142 with SMTP id z136mr19601126pgz.275.1501604255966;
Tue, 01 Aug 2017 09:17:35 -0700 (PDT)
Received: from SLUONG-M-612A.cisco.com ([128.107.241.167])
by smtp.gmail.com with ESMTPSA id w82sm54928757pfa.39.2017.08.01.09.17.35
(version=TLS1 cipher=AES128-SHA bits=128/128);
Tue, 01 Aug 2017 09:17:35 -0700 (PDT)
From: Steven <sluong99@gmail.com>
X-Google-Original-From: Steven <sluong@cisco.com>
To: yliu@fridaylinux.org,
maxime.coquelin@redhat.com
Cc: dev@dpdk.org
Date: Tue, 1 Aug 2017 09:17:36 -0700
Message-Id: <20170801161736.83502-1-sluong@cisco.com>
X-Mailer: git-send-email 2.10.1 (Apple Git-78)
X-Mailman-Approved-At: Thu, 03 Aug 2017 19:24:59 +0200
Subject: [dpdk-dev] [PATCH] net/virtio-user: send kick to tx queue to notify
backend on initialization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Aug 2017 16:17:37 -0000
Acccording to the spec, https://fossies.org/linux/qemu/docs/specs/vhost-user.txt
client must start ring upon receiving a kick (that is, detecting that file
descriptor is reachable) on the descriptor specified by
VHOST_USER_SET_VRING_KICK.
The code sends a kick to the rx queue. It is missing sending a kick for the
tx queue. This patch is to add the missing code to comply with the spec.
Signed-off-by: Steven <sluong@cisco.com>
---
drivers/net/virtio/virtio_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 00a3122..6362e14 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1747,6 +1747,11 @@ virtio_dev_start(struct rte_eth_dev *dev)
virtqueue_notify(rxvq->vq);
}
+ for (i = 0; i < dev->data->nb_tx_queues; i++) {
+ txvq = dev->data->tx_queues[i];
+ virtqueue_notify(txvq->vq);
+ }
+
PMD_INIT_LOG(DEBUG, "Notified backend at initialization");
for (i = 0; i < dev->data->nb_rx_queues; i++) {
--
2.10.1 (Apple Git-78)