From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 64BD17CBC for ; Wed, 2 Aug 2017 17:13:17 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id 12so20028829wrb.1 for ; Wed, 02 Aug 2017 08:13:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=CV3uZ0Qq3pXaW1ESw9d6zaEUtuIRaZSIh2pLljC6sM4=; b=ldOJCZuop2TA8Zgf312B+dR3LsiG+0v4nDDHPIxQmSkxUZaMXtc1h5dOJnntjWRPcH R7qhq7kWqMbNXAknvO1whZWSVEtGHSt0MmaJ/Pm4flZ3JWOBStDe0C+Nfa0afm2nPMdV mOHn62hYRCilEe5fzdkaINlM0HsHgc0d2Err+QH+/wfMx8Fy5Ev6jT4f4JR9Jf+euGpG lkR7tgF+DLPGoj6mrsBrbmAjYfsPZibdoNtPmj/UUAqZKeHujT/ZyFysdluq+S+L/WjR HnVPeelLtGOrpI44V6qKjmntrpNGAIBDuYbt6B8Pm+sqdbmvoKF9NQtX/GygaimBG7AZ 3bFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=CV3uZ0Qq3pXaW1ESw9d6zaEUtuIRaZSIh2pLljC6sM4=; b=UL9OJ9EfZmFJms6rdbBV3trfnjg54aGG8hhejgcLqMQpjL1hB3xjOWvnQ1JINj7Vxp iozkOcwqr10ZQ7/D9MDKLOZa/0NvitobyJwPcdVr/lfgZJA+AnBWExWAlQghJVx/rUP1 UGE4kfrB1btggBKopNxw8iJ7xV208/w0/forkeQZQHeM5LXdyVj0f46SWriAxtYo3I/3 Grs92o1A8/u+JLw4t2OYQcP3EDk0GHRPBr5tUCbFvAmaY2+Q/adlxH8GdyQFpzBQHgXZ YjdE8tUl8oB//mktTlQdSFHCI1wIWNhk7IGXokOzhRBkSl6BEHPTURo4xU4igq7F9t52 Tbew== X-Gm-Message-State: AIVw112bn1bZrtrtEUUJi84avk3qZgSe+15B3pHWaUcjOAqHBcREt8T/ 1qM3P/VJzWGajfCaB6M= X-Received: by 10.223.152.172 with SMTP id w41mr10118477wrb.202.1501686796761; Wed, 02 Aug 2017 08:13:16 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q141sm6817788wmb.11.2017.08.02.08.13.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 08:13:15 -0700 (PDT) Date: Wed, 2 Aug 2017 17:13:07 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20170802151307.GB8124@bidouze.vm.6wind.com> References: <1970205.aClgWgp9Kr@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1970205.aClgWgp9Kr@xps> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] devargs: fix scan mode configuration in add X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2017 15:13:17 -0000 On Wed, Aug 02, 2017 at 04:32:38PM +0200, Thomas Monjalon wrote: > 02/08/2017 10:55, Gaetan Rivet: > > When adding rte_devargs to the list, a check is performed on the > > intended bus that should use this rte_devargs. This bus configuration is > > for the time being only set once when the first rte_devargs is added to > > it. If the bus configuration has previously been set, then the rte_devargs > > insertion fails. > > Sorry, I don't understand which logic is changed :) > Maybe it would be easier with an example? > Ok, I will send a more explicit v2. > > Failure occuring upon detection of the set configuration is an API > > change. While rules will certainly be enforced in the next rte_devargs > > API, none were previously enforced and this should be respected until > > this API is deprecated. > > > > The bus configuration is meant to evolve soon, but in the meantime it > > should strictly follow the current rte_eal_devargs_add API. > > > > The rte_devargs unit tests are failing due to this API change. Revert > > this evolution, it will be reintroduced properly in the next release if > > necessary. > > So this is a revert. > I think the title start with "revert" instead of "fix" as you seem > to go back to the old behaviour. This API change introduced by the bus configuration is a bug. It was meant to prepare the change, not enact it. Reverting to the old behavior is fixing this mistake. But revert is fine if you prefer. -- Gaëtan Rivet 6WIND