From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0062.outbound.protection.outlook.com [104.47.33.62]) by dpdk.org (Postfix) with ESMTP id 0EF2B2C5E for ; Thu, 3 Aug 2017 08:23:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=D8cDh1Z8l6uVwnJNyMlyvtT5CuWlxbmiQa9MyJA9Tb8=; b=ivBtoLwr4Yn4SN/1KfWT3NHH8uuHv4aRUWzb4nVU0JNXD3eoUuiLnwYY12JmtrcT8sx21wNNAV07nwBbng2vdeJRvZ3r3EcBTlgqY3jIm/vq+4HfTEEPTAkLTYezM/M5Ot0mkkbHX+EdWig/MOjNnyc6FF7bA45nSZ6dASzBsfs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (171.76.84.248) by BY2PR07MB2437.namprd07.prod.outlook.com (10.166.115.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.1.1304.22; Thu, 3 Aug 2017 06:23:40 +0000 Date: Thu, 3 Aug 2017 11:53:16 +0530 From: Jerin Jacob To: "Eads, Gage" Cc: "Rao, Nikhil" , "dev@dpdk.org" , "thomas@monjalon.net" , "Richardson, Bruce" , "Van Haaren, Harry" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "Vangati, Narender" , "Gujjar, Abhinandan S" Message-ID: <20170803062315.GA14704@jerin> References: <20170707155707.GA6245@jerin> <3d2d78cc-9572-bf95-6d25-9b350da62827@intel.com> <20170710104126.GA13609@jerin> <4197b5f1-9a15-5892-12d2-6bd142bc4d85@intel.com> <20170713184445.GA3659@jerin> <123ed8d6-4fd9-8bee-d86e-d270a092169e@intel.com> <20170729151252.GA25166@jerin> <7b9ca757-f428-3675-b997-794ec6e96f2a@intel.com> <20170801164242.GA6467@jerin> <9184057F7FC11744A2107296B6B8EB1E01F00701@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E01F00701@FMSMSX108.amr.corp.intel.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Originating-IP: [171.76.84.248] X-ClientProxiedBy: MA1PR01CA0108.INDPRD01.PROD.OUTLOOK.COM (10.174.56.152) To BY2PR07MB2437.namprd07.prod.outlook.com (10.166.115.17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dada893e-1d16-437a-a883-08d4da3830bb X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:BY2PR07MB2437; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 3:dpXz3hV7h1yFuDsXaBSTC2kPUVlkkds8/owxIgF/2npZAH77qaECqYDyRVBjc0ftbKctfi/RdoBQt2XFprUFQVxi00+p9Pws8E79ZfCzhBMKvzpFiTl6zm3onzc08bZvBOymzFL5AM81oU/Yl1ZW8lDjELMJDapk4dP8H2yT55jQ/fIAJAZypnZmSZln2FSOMWTeExH4xcPUvQ8WfpW457o/9jpC3zT5KKJO1Ymu3+cBRqbjPNLFOrxLvoNUsoUT; 25:rHe7fyyYHmQ3ZcjHAwZd0EKdDrCH4gA9RYO57bYAdCOUsh/EJRV5GspQyMa2SGo8W0m1LFweXR5PtUBAhUmOUrOJOsNUAwZxNfnX07j3IbHa6EaNVq0t0okBIgJkuwoxx2f11bAX+TrflWbbnEHyTb/WhVzmljlyQ9mchS1Y8OXSs2aC4ztxBx0+Wv+NmMdwLNGJFeG+ptPlMsRmGV37Fs4FIJKx5cqzxBnH1XI5LDtFmB4NRqXT4Rr29bgPwzTg0kB67wUt0Cm8oM0ST0ragrXxQ5WHUu42jAQ1ayInRQjSDL1CRrnkIkHxmiD8z0tITq/DS/YvOkOGubNm/a9nBA==; 31:cWRaOVRfMrmndPmgCOXT875y/ClSZ5NEGmm8HM3vw07cjM3StWnjlKkqECLuvt6NiQ9rhHOS7k8J0PUvcX2i9JDQYTw6HCP8+q5UiiR2a69f5ZmJUbVdSu558CCsmibnOvUlLt+bX3IxZorcg0zIj5TkYuA1zmKFh75PZ+fMtxAcu1o23SXsBNk0MpTw6TOinP9Ty52TdALzvyZntw+MrVf85TnFOMewELd8+xktxcE= X-MS-TrafficTypeDiagnostic: BY2PR07MB2437: X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 20:taArSOnVKPuHuv6lJX6uf74rqIcxMdQsmOp2XpSHUOnTMsJEtkgSn5+WQgZ33LhpowbPbn+3bLwGmMiJh8/P1ONsQ1ov9mFLUNduWFaGdhWfJA6Sc3gKBvz8vSXgdKiTDLE1nloQK9DB8l0C26s5Va4m4RU3t+vFtzs4EkE0RXKUd/GMLOA7Vx3nS0wahutHW82qZoMTTqTLGApem7obIp215cJATcfQ0QhCGdohqN8YQA7PS5ez6M3okoItsb87ww5xY1rtLrLirjNLOvsYD874vflAogMSVGf3eUydi+0mPLgdTe3H0V6yacRtbmxo2filVqDREXFISIfd7d2D86FLXT1UqhzOTgZ+TYUex9v/EmmznkEF9YchkLTEcdXpNsst9gA5fjkJo0lGx3r5FLwugO42BRpTQr+dPnYEgZu/coWQKnAQJsrtVUOdqH6ZhBrFuZQxpqZ6iVJIFHsc4l1zgWhQdfbQvX2kczKc6sUHKM/IQ0o1v/ctGtA+rVOVVqvaB0ggMeJZrOsHCiLvLxRSlGiuN5WLsdC0d+XzUZsuP3+EKDefwdhJzfSha8Ys/xjf8abjnJF4QTrgPysA7LN0Mzh9HMtMy3c0uFWHElw= X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(93006095)(100000703101)(100105400095)(3002001)(10201501046)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123558100)(20161123564025)(20161123562025)(20161123560025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:BY2PR07MB2437; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:BY2PR07MB2437; X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 4:jqXp3vloaCKQiRtbLDQDCR0xtV+TSuhcns2cyC6ASIj8/7JikAuOTXeIwH56scen0xbE0NQoXbX2vVC4HAy1QyHQ79HbGnSCz5AJwBEuKalePjkMGU1AT+BC4aRivWompcG3HixqLgEOwT4Ccol5Fvpr6d6GWA30+NE8NY1hY4ufQuj/imKiPDLD1I/SMlibbJkSKi4c6yNnSTxqFpi8wjN4dC00QJaApUfCBQhAhumuM1IzF1O8pOuM6klUcWV+EoD0VdauSyT/ILIzn7JKFZ2kP2HfixUu8kAS8qATt1FuD4gcxMH6h8+rZ+cJ6x7u5N4KTnvnePoKsMetjcN7eg== X-Forefront-PRVS: 03883BD916 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(7370300001)(6009001)(39400400002)(39410400002)(39450400003)(39830400002)(13464003)(199003)(189002)(2906002)(50466002)(4001350100001)(93886004)(81166006)(7736002)(305945005)(68736007)(83506001)(8676002)(47776003)(478600001)(81156014)(6916009)(42882006)(2950100002)(25786009)(66066001)(6666003)(4326008)(33716001)(229853002)(6496005)(7350300001)(101416001)(189998001)(106356001)(6116002)(42186005)(55016002)(53936002)(1076002)(8656003)(9686003)(97736004)(23726003)(38730400002)(110136004)(3846002)(54906002)(105586002)(5660300001)(72206003)(54356999)(7416002)(50986999)(76176999)(33656002)(6246003)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB2437; H:jerin; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BY2PR07MB2437; 23:evz0TB30ZovkmsolPMPvG8Fgwr81MqUoLSfTsVsmh?= =?us-ascii?Q?e5IXHCnCQokB7NXqGgppWvZ9SUmjwuiPtt/bi9syE0egsI2/+BknGUMHXTUL?= =?us-ascii?Q?IUHuF0N0AH2N6wC/rWp7tP5TaMGS1FYxAR5kNi5vzvkqt7+JvTdIVdZOwySk?= =?us-ascii?Q?YL5gYTE9PiClFeQ3c9Sb6IjxSw5kpNj8dXqIAbXmcL+UduVvz6getA5mEvKg?= =?us-ascii?Q?8pquobdB2lh80FLwwn/RC1g4avYGEmKHMF+KV+zvPw+ADWfpvieU5LNpoXYd?= =?us-ascii?Q?xNjJagX67s2IhqI1OqF/eLe0eEntvcSZeAdV4fgXR59mRlJuQgBI7w8xDNFz?= =?us-ascii?Q?ozmc4emOpYDq0xTGiKYkXy18hnpoBVuT/3Ax+DqDVL/QTIHtLSQxikENWJNR?= =?us-ascii?Q?KDQMaKrgJ3Btpx1UpOxI0zPiC2e7TfZN+EA9xFkaXF5NruxZQEfoZRxdQXkX?= =?us-ascii?Q?IQrtQbr/oCd6Bh7ozZNXIniehIQF7rLIIr1mYhrazi238oqzSfrElqsxN7CC?= =?us-ascii?Q?9RmdfnKtyzLRcpXkJIKCuPi+ujSa/FjjYPWT4nBhBNBDP7OZFvA7EM+qDZAO?= =?us-ascii?Q?dq/6eSL5ghMSV+AnhVy36a4UofEZBOxpsjOwLqMxqlMf5GngJY7mC9fh/qDB?= =?us-ascii?Q?LOt0845e7hPp59KurusUw/6DDsfmCyNE1Kdwu5LSYOtG3Oe+Nb0oH/68NKRF?= =?us-ascii?Q?SFl/64E3O0cNv8hchuKXKKNmlk8o4lflD/25GGVAfFGpqijso/W3Nu7od0Ln?= =?us-ascii?Q?Ghcym3FNnd31vAMfoCQL7jOb1D4qKqbt3Cb0FolNAf/ymIOZJCI8Yn34XEan?= =?us-ascii?Q?dHj5gl+AYaTS7KDMocMrn5Gbo5MYix1l/VhuLm1Shc/v9w0vA3UyAlOsdvfe?= =?us-ascii?Q?vr8V/twIXb9jab3td2iGtZonB5Qn0kGkwkI3VWFGJ609uxYDOpz56eodl+2r?= =?us-ascii?Q?P/5cECmTpdsjqJKATZdrloIvy9+HZRJpwfY3YcUU2ZtEL75IX68kxrm5gUlC?= =?us-ascii?Q?o6z9kzXWpvv9dj4OVPzbZJyaw2UjyHV+GhLB51ods3kjg/S8aN+W58kXs0WA?= =?us-ascii?Q?OeIrv1B8YchL5jV/MUtj928dG/GSdS0UcvByiAsxkLv0IquEhDPOmBBYLCR3?= =?us-ascii?Q?Y4r05KMrZ0Tm2jm4cFrrM8vT5XEe5m2YcL4sTXYzvcE55wVeT3ALwG54mXMc?= =?us-ascii?Q?JlrdpsGiu1bn+y+FPbmhu44Sgp/LXHMprcRM9cdmLoahOwgaYxL4Y6Kq9ok/?= =?us-ascii?Q?J9/ZtDsQ9Ocox34qyeU4JrhSY5BbUkmLi88wuY5Ud+0kDB/bCp/p3itO9EAb?= =?us-ascii?Q?tX6+OP9E++L6BhlNqb3X9hdLtZkzGttmFQIfVx0rslaIpK/mupbbkne37O2R?= =?us-ascii?Q?P9hXHjPikc9HKDIgAkqqUCUT/sWM6ql84H/UHREqIFTLOmAHWVl7mKrVWg8g?= =?us-ascii?Q?C+oYCwuw6UMdp9sWS67VX2BBHNn6kc=3D?= X-Microsoft-Exchange-Diagnostics: 1; BY2PR07MB2437; 6:px7rAY4h2Glj7WiYtWFuIcov8tkh6Z8/IoCQ00T2MXxt5mcyAFhBMZYanXpTt6RIxjsg4rcJRnSEbm54Aamjarn49stMzzWyP07HNWCFhLKuQHhlsTX/B0nFFmPWTENS8RsP2CEVCCDhNVVopmMI+FFMYtik1H4KYiJv5E5Xq/twu+dJyRBHTdh4nuwgnLGhlaQzrmsH+BcTpqJfHzzcxY0139aSjEq68QPegaycrVjH3JqVT4U7IBfquPTwzzGP+bMZ07U8Nk4gjMeRl14o3iIEmlQmNGa2K9qM5AlR0fsKHjeur6otDNT/E0ST8XyLQIWeSrYjaw56AZFgfmNR0Q==; 5:Ee96L4DzjiXgWFhrjaRVOBroUAle/nK2e8MblJ9SBD30StXqdNENVxryIBtOtKXGLDnANyafvdPzj4UAZqB4UUteXLDZCDjEJWyGQU44VSOGLPMA0JEV/icMo9bOfcTrfV/JVLmA/Q60CcPzOFP4DQ==; 24:PLEjWDhhrm24NXHTZtRKJCmPsUDUgaBo2rvAutrSperxIqrD5UZYIxC8u9lK6sHSC9E7czlOaTH1OQsXPLLthl6TrdXOhpJNfqK+ty0ZRiQ=; 7:F9kPvyy0qsfhwIXEEGvz1ds1wQO3/Kb/GdpBba8EJoiKQBrqv2q+Mzgb7rqhIgeyehnyYUp3sdyV2+erE6E2V0EPGIn1s7rSpuCzOL7BxWR+LaFuQyLcZdwEXMSNqAifC7Gfqjki18OlsdFM723Rk/aVGoT9X6KYfVGgjMdYqTsP4eLv/9BgwCnlgZsQ9V6nL8CSgdv2Kn/ijITVeQw1AJ5kjnCmtaOcXMlYL1x43+U= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2017 06:23:40.0303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB2437 Subject: Re: [dpdk-dev] [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 06:23:47 -0000 -----Original Message----- > Date: Wed, 2 Aug 2017 19:19:32 +0000 > From: "Eads, Gage" > To: Jerin Jacob , "Rao, Nikhil" > > CC: "dev@dpdk.org" , "thomas@monjalon.net" > , "Richardson, Bruce" , > "Van Haaren, Harry" , "hemant.agrawal@nxp.com" > , "nipun.gupta@nxp.com" , > "Vangati, Narender" , "Gujjar, Abhinandan S" > > Subject: RE: [PATCH 1/2] eventdev: add event adapter for ethernet Rx queues > > > > > > > > > > > > 5) specifying rte_event_eth_rx_adapter_conf.rx_event_port_id on > > > > rte_event_eth_rx_adapter_create() would waste one HW eventdev port > > > > if its happen to be used RX_ADAPTER_CAP_INBUILT_PORT on > > rte_event_eth_rx_adapter_queue_add(). > > > > unlike SW eventdev port, HW eventdev ports are costly so I think, We > > > > need to have another eventdev PMD ops to create service/producer ports. > > > > Or any other scheme that creates > > > > rte_event_eth_rx_adapter_conf.rx_event_port_id > > > > on demand by common code. > > > > > > > > > > One solution is: > > > > > > struct rte_event_eth_rx_adapter_conf { > > > uint8_t dev_id; > > > > > > int (*conf_cb)(uint8_t id, uint8_t port_id, uint32_t flags, struct > > > rte_event_eth_rx_adapter_conf *conf); > > > > > > unsigned int max_nb_rx; > > > > > > int event_port_id; > > > > > > char service_name[]; > > > } > > > > > > Where dev_id and conf_cb have to be specified in the create call, but > > > event_port_id and service_name will be filled in when conf_cb() is > > > invoked > > > > I was thinking like event_port_id will be rte_event_port_count() + 1. > > ie When adapter needs the additional port, It can > > - stop the eventdev > > - reconfigure with rte_event_queue_count() , rte_event_port_count() + 1 > > - start the eventdev. > > > > The only problem with callback is that all the application needs to implement it. > > If you think, application need more control then we can expose callback and if it > > is NULL then default handler can be called in common code. > > > > I don't think we can rely on there being another port available -- a user may have configured the sw eventdev with all 64 ports, for instance. On that case, irrespective any scheme(callback vs non callback) the adapter creation would fail. Right? > What if the user is required to calculate cfg.nb_event_ports as a function of the RX_ADAPTER_CAP_INBUILT_PORT capability (i.e. add a port if the capability is not set), such that a reconfigure is not required? We have only one NON INBUILT eventdev port per adapter. Right? i.e in the v1 spec it was rte_event_eth_rx_adapter_conf.event_port_id, How about it can be rte_event_port_count() + 1 ? Since we are NOT linking this port, the context call be kept in adapter itself. Right? > > As for application control: that would be a useful option in the conf_cb scheme. Some apps will want to configure the adapter's port (its new_event_threshold, its queue depths) differently from the default. struct rte_event_port_conf * can be passed on the adapter create if application needs more control. > > Thanks, > Gage