From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 24D51325D for ; Thu, 3 Aug 2017 12:16:28 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Aug 2017 03:16:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,315,1498546800"; d="scan'208";a="119115096" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.72]) by orsmga002.jf.intel.com with SMTP; 03 Aug 2017 03:16:24 -0700 Received: by (sSMTP sendmail emulation); Thu, 03 Aug 2017 11:16:23 +0100 Date: Thu, 3 Aug 2017 11:16:22 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: dev@dpdk.org Message-ID: <20170803101622.GA42296@bricha3-MOBL3.ger.corp.intel.com> References: <20170711171046.22558-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711171046.22558-1-thomas@monjalon.net> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.3 (2017-05-23) Subject: Re: [dpdk-dev] [PATCH] pci: fix level of scan debug log on BSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Aug 2017 10:16:30 -0000 On Tue, Jul 11, 2017 at 07:10:46PM +0200, Thomas Monjalon wrote: > Printing the number of scanned devices should be a debug log, > not an error. > > Signed-off-by: Thomas Monjalon > --- > lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c > index e321461d8..9335247d8 100644 > --- a/lib/librte_eal/bsdapp/eal/eal_pci.c > +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c > @@ -396,7 +396,7 @@ rte_pci_scan(void) > > close(fd); > > - RTE_LOG(ERR, EAL, "PCI scan found %u devices\n", dev_count); > + RTE_LOG(DEBUG, EAL, "PCI scan found %u devices\n", dev_count); > return 0; > would have gone for INFO level myself, but DEBUG works too - it's definitely not an error. The commit title also reads a bit strange to me. How about e.g.: "pci: log fix level of PCI scan summary message on BSD" Otherwise: Acked-by: Bruce Richardson